From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B175DC433E2 for ; Thu, 3 Sep 2020 22:05:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70AAE20678 for ; Thu, 3 Sep 2020 22:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v6/sBZ3S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="KSOF4MSb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70AAE20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IcSOO+rcPnV24DPlPVBaRRM5kdYsIzUCsVZJkuK1H4w=; b=v6/sBZ3Sadr8vtv82EnUG+mjA YAEReBUdKUXPcc08RyLZ8tuRUw367SuZbuRVRfJQqrP155HEsdYS6fXXiXvsiWMTMntBRP0mU0+Cy GTA/K794mRLsK0NEh7B+oZDhvd7lZy01YGv+e6B3UtE00IYy68ixH8ctGBOjjky9u/2BnyINckqLf IegS+xLH426786uJTwTKDRQw3D5gAqnQ3r1tqPcJz49vEObKVlXSMNavLq/1+qya5Cyli+ODsGN0K U7TE6b/sRhJiMqcgTmZJgTQFh5AeCI/foZ6yAGvwyqkdSZXjrqoA1k20xsXX7iiHI3lkniV1Jw79E MDG4P3zTA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxKd-0005ef-I1; Thu, 03 Sep 2020 22:03:47 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxKb-0005dU-9s for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:03:46 +0000 Received: by mail-ed1-x541.google.com with SMTP id n22so4213065edt.4 for ; Thu, 03 Sep 2020 15:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qVIO+W41RwcDMaSobjfrJM37v+XlNEpsXghdOpMJtkI=; b=KSOF4MSbX4S87IQK+in03uGEn+ytQl9cZGyW6vDNozCbdjEAgInLMiYQKelxpagMl5 df9b/zV8SpGeA2iaUig0Q+MwFtCPZ28+WIKxq9eXlq/Wqd7GExFDfcGlLp8y1mAoy6te zS6jijDRaye7xBQSACfoereqL7Lz3JDY21FkaYI+Fw7k67Kt0rdnapLXNgJhXsHyhm7Y hlEeZ4lRpKgWRNSwYIyS0ZNPVsv/wZ3NStKIflMJS4q4+n12JbEG9GPG0Q5FVCgUqH5k 1+abDI3c1WFNhWHsCv2v/A8XJ1YBYFMlewBw3NbKj1gZ1Og8okZuumffy5glY7Vb2XSt +iTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qVIO+W41RwcDMaSobjfrJM37v+XlNEpsXghdOpMJtkI=; b=g7CIlcTZv2//xYfl9+E5jfPt8I85nix12Zf1f1koxS3y1lk6/GiN7KC8cdzwnCjEV8 f/0dvR/FirW9FYBrNe+XQtGBWmE44htcThz+yd0GenjfJcXkM/bBzZmMHn1RD7IGpmhl tBfC7Rt7Fi/84edEgdK2Xp+vkbWfhLr8KadJdcNdiNT/MNMuIvm41yBjGwqSL7j6vL92 yur9bT9gKwST7lo5MydaSXUE3CRpZWHR5GoKH7/jaqqPHcd1X1n6N2S55POJMRP8lb/m Odzz/okFFXieAZz33mMP7Zc47eWBNqPOhv87zm+abx+SW3cQimecjEYOLuNVeuSM84DJ E6qw== X-Gm-Message-State: AOAM5300aTTMulO22h8SkVS1f+TBaV2ETwhyPPcLolNOrZiRX5obH2tT MXKnQoVqRLK+rnF6GbJW7yLvCPnZtvj9XPTA2NOWkw== X-Google-Smtp-Source: ABdhPJz8wZUegnpJXZZBut1xff7mQk50TpWZj/RnJoIZEh3bEYGVn9VJa+mmP5IBGCFzg96FVhHvLJwNs9ID1NpA3wM= X-Received: by 2002:a50:e004:: with SMTP id e4mr5429575edl.114.1599170621796; Thu, 03 Sep 2020 15:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-6-samitolvanen@google.com> <202009031450.31C71DB@keescook> In-Reply-To: <202009031450.31C71DB@keescook> From: Sami Tolvanen Date: Thu, 3 Sep 2020 15:03:30 -0700 Message-ID: Subject: Re: [PATCH v2 05/28] objtool: Add a pass for generating __mcount_loc To: Kees Cook X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_180345_380354_2AF6E6F5 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , X86 ML , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 3, 2020 at 2:51 PM Kees Cook wrote: > > On Thu, Sep 03, 2020 at 01:30:30PM -0700, Sami Tolvanen wrote: > > From: Peter Zijlstra > > > > Add the --mcount option for generating __mcount_loc sections > > needed for dynamic ftrace. Using this pass requires the kernel to > > be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined > > in Makefile. > > > > Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/ > > Signed-off-by: Peter Zijlstra > > Hmm, I'm not sure why this hasn't gotten picked up yet. Is this expected > to go through -tip or something else? Note that I picked up this patch from Peter's original email, to which I included a link in the commit message, but it wasn't officially submitted as a patch. However, the previous discussion seems to have died, so I included the patch in this series, as it cleanly solves the problem of whitelisting non-call references to __fentry__. I was hoping for Peter and Steven to comment on how they prefer to proceed here. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel