From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A80FC4346E for ; Mon, 21 Sep 2020 19:00:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A624D20888 for ; Mon, 21 Sep 2020 19:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cNkOe+qL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="VwM6SxPc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A624D20888 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OSWX53WpHy+/1sYRG6OmO2q7gfiPwmJWKqtZTFWA4SY=; b=cNkOe+qLfXgrKrtIXWI0WOzhl SH8dQHLJmxS/vYRetKG3Of5zMmJGpT1tXUfQMn193+xWQiFO1uYGgmb41zqdhG9iyOWRurHmnhu9g 4ruwnJVKBXiZa5w1evqCqA8UNb8EVjExt8XRPe2uc3BqV8pOr+lRDk+cQgYX974ThyxKbKX0cI1e6 iE8LtKpJFKVmPmrHdngLY4TjG10PoFttYh7hS+FsNrVwZwJALEvelqmDlu30Vq0umlyqmtKXHVTFu U1nMoNuSQgOImPu/aQjXGdsauh48wiAflp17NMmQhWMxQSvzAYRYy5WISmHypq/hoPPucSELCEWkx yGJP1KP2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKR1I-0006TZ-SR; Mon, 21 Sep 2020 18:58:36 +0000 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKR1G-0006S6-GF for linux-arm-kernel@lists.infradead.org; Mon, 21 Sep 2020 18:58:35 +0000 Received: by mail-ej1-x643.google.com with SMTP id q13so19240112ejo.9 for ; Mon, 21 Sep 2020 11:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rrEufNVuY5dCBzinzTyZLnRAK6NDit4k748EnZ9ZGyU=; b=VwM6SxPchzpHYvDq5MuGqptnfOCO+2u8UOZQsUHmvXP+yQTF+Z7wlraeVtjd/s9jlB wV193ZvJeoHSX0mG5NaEp1P+oe7FoNjVRmUSb2Z+JinKsMwFIqn+MpalsijQarctvj4U FH4y6mRhga1p9JKtJgLYS2O01gvN0JoRMzpIJ8sTPjHm+K3XvxLJoxyawOroxTt3ewXo 2erVwwtPxW6qCdmd6A02Wa5wSMbzwpQ/xA7DOELk4+u1Yv0Dw6Gb0gPjk1AInJx+Npb8 9g541oYiyMOVYQWN0p1s+dSK+qehJVoUb8ZcAzai39YkrQsAMRZIWHvBa3cE/5jkadoT Dtig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rrEufNVuY5dCBzinzTyZLnRAK6NDit4k748EnZ9ZGyU=; b=QQEqePcSvLUJTAneEHnTcmXOE62jEeunPMmTeabpmnfH4SnFpnds31ZYGJ429CAXtx zW5y5UUlijEImV7i1pZuh+OahCKPHchvSfIURWulVMVkFnNFhvMurXkYmTBBGSL9j8TU ALg3OYeneWY2YnRPKvnhIPoDw2VUwuHGgVru+ccInCvQ3r73+wHuaQBjf/VSy8e5G5Km +5eXs8lwkO/fk0t9yCBPMgOB9EQp3hRLFLo6a8lRyf7GZcsW1p+nHL9L5MjBIVVzh21U F1sV99O1uzEA/jKwSQ71M7NAGF/FZcgYwuJ7cwC2Xgsx1IxVYzeYVO1p0eRJkVwN7Vtv 2AWA== X-Gm-Message-State: AOAM530Bp9qpcVpjnifwcLa3wgIWOAMEXj3m696fI7MpffKdKkLd1C1c JG8K2cMpyq6ke0OXBIl2kfQaTaRdC5uYAWvFoYJJow== X-Google-Smtp-Source: ABdhPJwAs9ksH6re9qMXbI2fsKP5Ghj4mOoCzkBFQS+BQszgLy1pqKFO8fFSdMFWe7XQ/UpW1tcdUlWla4BBqoqymc8= X-Received: by 2002:a17:906:ecf1:: with SMTP id qt17mr960026ejb.158.1600714709946; Mon, 21 Sep 2020 11:58:29 -0700 (PDT) MIME-Version: 1.0 References: <20200918201436.2932360-1-samitolvanen@google.com> <20200918201436.2932360-14-samitolvanen@google.com> <202009181427.86DE61B@keescook> In-Reply-To: <202009181427.86DE61B@keescook> From: Sami Tolvanen Date: Mon, 21 Sep 2020 11:58:19 -0700 Message-ID: Subject: Re: [PATCH v3 13/30] kbuild: lto: postpone objtool To: Kees Cook X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200921_145834_549898_84A1558E X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , X86 ML , "Paul E. McKenney" , Kernel Hardening , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nick and 0-day bot both let me know that there's a typo in this patch, which I'll fix in v4: diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index f7daa59ff14f..00d7baaf7949 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -223,7 +223,7 @@ dtc_cpp_flags = -Wp,-MMD,$(depfile).pre.tmp -nostdinc \ objtool_args = \ $(if $(CONFIG_UNWINDER_ORC),orc generate,check) \ $(if $(part-of-module), --module,) \ - $(if $(CONFIG_FRAME_POINTER), --no-fp,) \ + $(if $(CONFIG_FRAME_POINTER),, --no-fp) \ $(if $(CONFIG_GCOV_KERNEL), --no-unreachable,) \ $(if $(CONFIG_RETPOLINE), --retpoline,) \ $(if $(CONFIG_X86_SMAP), --uaccess,) \ Sami On Fri, Sep 18, 2020 at 2:27 PM Kees Cook wrote: > > On Fri, Sep 18, 2020 at 01:14:19PM -0700, Sami Tolvanen wrote: > > With LTO, LLVM bitcode won't be compiled into native code until > > modpost_link, or modfinal for modules. This change postpones calls > > to objtool until after these steps, and moves objtool_args to > > Makefile.lib, so the arguments can be reused in Makefile.modfinal. > > > > Signed-off-by: Sami Tolvanen > > Thanks for reorganizing this! > > Reviewed-by: Kees Cook > > -- > Kees Cook > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202009181427.86DE61B%40keescook. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel