From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A78C4742C for ; Fri, 13 Nov 2020 22:56:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D91CB2225B for ; Fri, 13 Nov 2020 22:56:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XpjnJ3+/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="E/DaHCUs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D91CB2225B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TP7SV9cxprTsgFy4iW340t1pvZy6u4QYQx2ST5sRcGU=; b=XpjnJ3+/WAVa/Leg3uJ/hRtTp X24tRUXB+nKTrRTzfvjFmY08/rUKOCzHAwdVwigO3+nd0x0RJnyMdys8TNTyr/Y5DQmp0F/jyLaQa zbJJEHDs1ZlmNkr/hBStI0j/HOcwkUI2Fenyaqq4Jl46CmY9Zlhuvu4N3A8CC8zQFN6RqBgZHfXzl kTkMu2V/b3BMmnPE0gT+LO/smpjXIIIzFA3SZCGW04JdyPOVB5UAL1gd8N1OEFmhqRAsr98LH53WN dzuuxeWymUPE2O2yyDbMHeg/wOq6RLcQwOckfskfcJ7Tcrn3hjKvLk220lzih9DQ9ZpOAVu912Csz EIZGZzmLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdhxw-0006nn-Ak; Fri, 13 Nov 2020 22:54:48 +0000 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kdhxu-0006me-91 for linux-arm-kernel@lists.infradead.org; Fri, 13 Nov 2020 22:54:47 +0000 Received: by mail-vk1-xa43.google.com with SMTP id m184so2469287vkb.9 for ; Fri, 13 Nov 2020 14:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x7PN1px9ytV6KoYCs0MN8nIig7IfEqAMiUFMKSdwj8o=; b=E/DaHCUsxm9boUEUHR77XASfe1K99YXKl7duBooJylavKxm0tOGa/ZPK6xjyi2fAmj OYWDrTJOnFXwWt5S1pKJ6s8UxL+U3rZbepSwCXbZJRMhsO/oaNcGV6l2VgGjr5evZtSz yye6NpoiB+nakm0oK6uQ3sQViWHFOTTwEdtfu1R5mD/VgZzVhriCR2Y85MJT5y8nazB0 NR1BZldS24JnVXgr+Ovb7PrDJwr+3Atcw4eToXXk9DLqZMzDtjrCymZ+KKaYr49Oz2wG 03mdefjS8C7FER66kGpwiyb+EPHalvUWh8ADfLZXcOqSslaUx80S/cRhipC8ekjXSqmD cGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x7PN1px9ytV6KoYCs0MN8nIig7IfEqAMiUFMKSdwj8o=; b=hR3KR8mYK6Jc0ICzCUndCybR0L4UhXrt5GtDNPiU83+K3DTsuLtWn2DEjZzdNwoSl/ yA+trC16Zj23A7fGHfeVB5f8uP+70MlqqD7uaGhUPgg5lom/L72N9zHNbDelvcQn9zUq dOlTTIpvSdm/FGHovm1sCYV2/CNIdX+5yOJXmp/pkrD5M+aYynWqwcDiWrZb0I9CdgkE XAXB3+4xR2wkuNcVAztDhvq5q0bWpMWTIZUma2gOFq8yAWDTMjeAlOOEoir8m9Is9RE0 kF0UG1J5iLhYwEB2NqVa6w0SKUiGShu2zfFcaR2dY70Q/h/HNgTIAJigj/vMy4jU131U SuNw== X-Gm-Message-State: AOAM530fGvpvf5w4IxwcTYnSo7Bfy+Z7b64QQWITVpboYDVCBkc9oDxM kJxq9ameLDVMCd08hjIMEIOdcUyZUF1TenQgvyf8AQ== X-Google-Smtp-Source: ABdhPJygwOP2IUwJzonbqdQUEI4r2KfzeUcxt3t9CVTdz7Ir0TADwtgbrh1R8/xsj+WLPbsqPnxXtDMz7YsGC5N32I8= X-Received: by 2002:a1f:3655:: with SMTP id d82mr3109788vka.22.1605308083978; Fri, 13 Nov 2020 14:54:43 -0800 (PST) MIME-Version: 1.0 References: <20201021085606.GZ2628@hirez.programming.kicks-ass.net> <20201023173617.GA3021099@google.com> <20201110022924.tekltjo25wtrao7z@treble> <20201110174606.mp5m33lgqksks4mt@treble> <20201113195408.atbpjizijnhuinzy@treble> <20201113223412.inono2ekrs7ky7rm@treble> In-Reply-To: <20201113223412.inono2ekrs7ky7rm@treble> From: Sami Tolvanen Date: Fri, 13 Nov 2020 14:54:32 -0800 Message-ID: Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps To: Josh Poimboeuf X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201113_175446_395669_072E68C0 X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Jann Horn , Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , the arch/x86 maintainers , Nick Desaulniers , kernel list , Steven Rostedt , linux-kbuild , clang-built-linux , linux-pci@vger.kernel.org, Kernel Hardening , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 13, 2020 at 2:34 PM Josh Poimboeuf wrote: > > On Fri, Nov 13, 2020 at 12:24:32PM -0800, Sami Tolvanen wrote: > > > I still don't see this warning for some reason. > > > > Do you have CONFIG_XEN enabled? I can reproduce this on ToT master as follows: > > > > $ git rev-parse HEAD > > 585e5b17b92dead8a3aca4e3c9876fbca5f7e0ba > > $ make defconfig && \ > > ./scripts/config -e HYPERVISOR_GUEST -e PARAVIRT -e XEN && \ > > make olddefconfig && \ > > make -j110 > > ... > > $ ./tools/objtool/objtool check -arfld vmlinux.o 2>&1 | grep secondary > > vmlinux.o: warning: objtool: __startup_secondary_64()+0x2: return with > > modified stack frame > > > > > Is it fixed by adding cpu_bringup_and_idle() to global_noreturns[] in > > > tools/objtool/check.c? > > > > No, that didn't fix the warning. Here's what I tested: > > I think this fixes it: > > From: Josh Poimboeuf > Subject: [PATCH] x86/xen: Fix objtool vmlinux.o validation of xen hypercalls > > Objtool vmlinux.o validation is showing warnings like the following: > > # tools/objtool/objtool check -barfld vmlinux.o > vmlinux.o: warning: objtool: __startup_secondary_64()+0x2: return with modified stack frame > vmlinux.o: warning: objtool: xen_hypercall_set_trap_table()+0x0: <=== (sym) > > Objtool falls through all the empty hypercall text and gets confused > when it encounters the first real function afterwards. The empty unwind > hints in the hypercalls aren't working for some reason. Replace them > with a more straightforward use of STACK_FRAME_NON_STANDARD. > > Reported-by: Sami Tolvanen > Signed-off-by: Josh Poimboeuf > --- > arch/x86/xen/xen-head.S | 9 ++++----- > include/linux/objtool.h | 8 ++++++++ > 2 files changed, 12 insertions(+), 5 deletions(-) Confirmed, this fixes the warning, also in LTO builds. Thanks! Tested-by: Sami Tolvanen Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel