From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35614C433E9 for ; Tue, 16 Mar 2021 20:35:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1CCD64F80 for ; Tue, 16 Mar 2021 20:35:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1CCD64F80 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H8p4sqPNV9ynFxtVKeLGRZ9CqlXNasHiVvZBS8PwYIA=; b=cHpI+9ylHnPf2YZ3U2g3XjFev H542+6TnNPJX+TYtvFxrcAmJq3TIexZNVNYjEYIc9ll2q5senBPa3klQBtp/8T3UCc3NNIUQab1eQ FE03BzfjI2MSdCW5akqiwn+V9EfaSL9Fj7CXmQgmhD4Dsq1ydjX5yRodVfSFZoAuQGoTga8smk3bY 9bbXB8oXGtk2d+BrJIw0P78bEBiLWHwbZ0YIlFagJ2cjHeccvBS+Zyd98G43AVkeItNS5/jT5W/AB 9VTn+z2fNInufy05U/19Q5qWPhM8JAgQRt06yV/xzoDbPxx18hn/ZEkzNZrvgWfouhREMirJ6UinK GlyRpUrKg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMGOI-001omc-6j; Tue, 16 Mar 2021 20:34:10 +0000 Received: from mail-vs1-xe33.google.com ([2607:f8b0:4864:20::e33]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMGOE-001olI-IO for linux-arm-kernel@lists.infradead.org; Tue, 16 Mar 2021 20:34:08 +0000 Received: by mail-vs1-xe33.google.com with SMTP id v123so18961036vsv.9 for ; Tue, 16 Mar 2021 13:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xrwjt/kZB1RxVC21J+b2Rv85znrbxBlQ2xQVtgXaL8Q=; b=po1Ywby6SU2VWLEUyZ5fNbrtGcCnRgD8+IOMID+GlXWQNN/3aWjrKopHkVgecJy3yJ khd4+NGMXkdhaRRLq7oIG7sqA93cOIbt85nnBMxjdoTTob9e2Am24an2yQVbG1o0V5H8 7GVzuReTWAlfbF1CAQXu39fgGvH5SXGbKyaDGdlbOZBsDb8/16qHOkbAClu4ucjVnnpq puCa2KojBGupypPIcNHF88u0nBc0j5j5wmxJB5QqbuzbcGhuC3bdhL35d8XTmOmAH5Ze Rv/YonPUJZL/28fPFwgGqtGza8PZ38b3S3xCK35A47xteLDq+UaKkUNMlUmMa3ohiIUa It1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xrwjt/kZB1RxVC21J+b2Rv85znrbxBlQ2xQVtgXaL8Q=; b=TwG1z0LFf7wd8aLg1fcIZBsnqycWxjsm2+BDN+cxh4MYFQNzqxKPE98JMFEpZ2oCFO jr+YLismhIf547P1ye2HBFDNrzwfatJGkMiLyCtuKYVvWjappERp6qa3wLqAufS9tcmo P2xyd68u0gyq6j8ThmGauBUwxyeOCICNcgGwi3xEhA6G1bRg9USG+cTTyYCMzRzM01Zs oydr94hwJEN44VHwpXJGMzgvyz7giXRg5QK8pHluaPL6LDtvbxxJ+4wWaNqSzyUfKjQK EDhNwm8SI3L+gL04ddSBoqmsgXhDHxRuSfnK1CeoJcWHJk/mPdLRiRhuG/apMK+gAsgp /p/A== X-Gm-Message-State: AOAM531HRbAXbPwqPs0ZlMZ376Wk4ODKth6ZkLyEyBdQHMj4O0AaXjIO 0O8diY8MklR2YnzSL9d7iunLcGTT30LAy6UhJlgovA== X-Google-Smtp-Source: ABdhPJwadRPiAKyB9trsaH6fnnn3nCM/AdtJrbuHIQFIQoIMgPzfKSpazXNSL6neJgetXYxyVdUJ7AZv1KZY68p3ujw= X-Received: by 2002:a67:2803:: with SMTP id o3mr1486279vso.36.1615926844137; Tue, 16 Mar 2021 13:34:04 -0700 (PDT) MIME-Version: 1.0 References: <20210312004919.669614-1-samitolvanen@google.com> <20210312004919.669614-8-samitolvanen@google.com> <202103111843.008B935F8@keescook> In-Reply-To: <202103111843.008B935F8@keescook> From: Sami Tolvanen Date: Tue, 16 Mar 2021 13:33:53 -0700 Message-ID: Subject: Re: [PATCH 07/17] kallsyms: cfi: strip hashes from static functions To: Kees Cook Cc: Nathan Chancellor , Nick Desaulniers , Masahiro Yamada , Will Deacon , Jessica Yu , Arnd Bergmann , Tejun Heo , bpf@vger.kernel.org, linux-hardening@vger.kernel.org, linux-arch , linux-arm-kernel , linux-kbuild , PCI , LKML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210316_203406_959462_C108AF8F X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 6:45 PM Kees Cook wrote: > > On Thu, Mar 11, 2021 at 04:49:09PM -0800, Sami Tolvanen wrote: > > With CONFIG_CFI_CLANG and ThinLTO, Clang appends a hash to the names > > of all static functions not marked __used. This can break userspace > > tools that don't expect the function name to change, so strip out the > > hash from the output. > > > > Suggested-by: Jack Pham > > Signed-off-by: Sami Tolvanen > > (Is it possible we could end up with symbol name collisions? ... though > I guess we would have had collisions before?) Yes, these are static functions, so name collisions have always been possible. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel