From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15885C4332F for ; Wed, 4 Jan 2023 16:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iz34cROocLMnrmh4H44TJhkjtx9mAAwznbLNRXdYlrw=; b=rRxFI8akl1x1PD l/l7imP5XXjOjy71z3VTmYKMDvgAK29X8Y6aXkM/oIrT+PZJsG2acOWieOYty5DfF6E6L8lCV9H/p CxNzYXTDKWbAKbRF6aPE+nH3mrGBJjQQ66GpprqCxF4ENV/r+VSoljnFfFl1YzCvBtkktZYQzHKiq oXm+3g1REfVYLkPFtzdM/ZIvy3OTuhPq70DHTd21pt/8U83xp4sq/nkoFWIuuFinyGhVGPZ5P1czl m6SraxHVBU6omyvnuLyVw5/MxSv2LZKEWznHfiDqBdEs08QL92P33GJwTm8XUEcrshwPai6XjXg9m iHYj/3JQnuAf0f9oXxLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD6P8-00AKDD-9m; Wed, 04 Jan 2023 16:14:14 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD6KQ-00AIxL-4d for linux-arm-kernel@lists.infradead.org; Wed, 04 Jan 2023 16:09:24 +0000 Received: by mail-ed1-x535.google.com with SMTP id i9so49173993edj.4 for ; Wed, 04 Jan 2023 08:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7Fdz8ydnkLz5wna1uPMyDPqPnfgZcb47kfpiU1wAhAo=; b=GLxN5JXuiOtzMgmWrdYlcn0q2EhxBeBj1Rl8jzjd0XS6VAIeuEbKEWnWpKnCu4FZsi /M4yqOkCuBcCOPjewV8qkVtP4lrZJXY37qkXPCp125xA85llOpBibFgovnnHpVgVfCkZ UDkOFnE6O6SFEzF3Ov+SbSMj0cf6n2R3GNslY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7Fdz8ydnkLz5wna1uPMyDPqPnfgZcb47kfpiU1wAhAo=; b=v58ipuAZeYWfnTYB517jl8YJQ2fK3KZc/lFQP/5zTC8MGd3dB1LQRjPoO0rb9pOkFe hQVnXGPioEhM1NPQUjeHLjXJ/uuG+TQqWPRXuKKY4xRwMOnb9M1Q6GuFpawqz98iZ8Up hmf8E8r6qaB83m5bumhy6b1arQyUhX6oZQzMz1rJlFJkeI5ucbAqVdIBToqwsk+GK2gK RVYCNtwHgpKby5dxZDPyqzvMinHKDe8lteBrXljt7n6+BxFbpuNSPrMEmhkbHMomH5Yb Z+1PHnzxj83a4N9eEAZb6hV6vbfMGj4jxo53YBrBXEiQ+ZxZ652gLB5cJgQ2+srC0Qn7 0bcw== X-Gm-Message-State: AFqh2kq2m3ODiLM0Zrje5UzksGZIZVnhyFzYse2NXH0M11lE3WI2Fct7 NCXpnh1KjFNTZ+qN9UpwDwMCwQIEeCjxCgLA/W77+g== X-Google-Smtp-Source: AMrXdXsv1xg2M0bhVn1lwVtKy4iXv8iFGb+5mdRNNhgcOA/iAYMeYuCuQaM7J9fZy2xr9HWmpKkA9zSLNNe3G6JTUuY= X-Received: by 2002:aa7:d35a:0:b0:46c:4b56:8c06 with SMTP id m26-20020aa7d35a000000b0046c4b568c06mr4381025edr.230.1672848558235; Wed, 04 Jan 2023 08:09:18 -0800 (PST) MIME-Version: 1.0 References: <20230101175740.1010258-1-dario.binacchi@amarulasolutions.com> <73979439-2e41-c4ea-02e0-d382f7ae1459@denx.de> In-Reply-To: <73979439-2e41-c4ea-02e0-d382f7ae1459@denx.de> From: Dario Binacchi Date: Wed, 4 Jan 2023 17:09:07 +0100 Message-ID: Subject: Re: [RFC PATCH v2 00/11] clk: imx8mn: setup clocks from the device tree To: Marek Vasut Cc: linux-kernel@vger.kernel.org, angelo@amarulasolutions.com, michael@amarulasolutions.com, tommaso.merciai@amarulasolutions.com, Chen-Yu Tsai , linux-amarula@amarulasolutions.com, anthony@amarulasolutions.com, jagan@amarulasolutions.com, Abel Vesa , Adam Ford , Fabio Estevam , Krzysztof Kozlowski , Li Jun , Lucas Stach , Markus Niebel , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230104_080922_263706_8C9C464F X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Tue, Jan 3, 2023 at 12:04 AM Marek Vasut wrote: > > On 1/1/23 18:57, Dario Binacchi wrote: > > The idea for this series was born back from Dublin (ELCE 2022) after > > having attended the talk entitled "Updating and Modernizing Clock > > Drivers" held by Chen-Yu Tsai and the availability of a board with > > imx8mn SOC. > > > > This series aims to setup all imx8mn's clocks from the device tree and > > remove the legacy setup code with hardwired parameters. > > > > I am well aware that the series lacks patches for the DT bindings. The > > effort up to this point has been important and so I thought I'd ask for > > feedback from the community before proceeding to implement them. If it > > is positive I will add the DT binding patches starting from version 2. > > > > The series has been tested on the BSH SystemMaster (SMM) S2 board: > > https://www.apertis.org/reference_hardware/imx8mn_bsh_smm_s2pro_setup > > I might be wrong, but I vaguely recall AT91 (?) had this kind of massive > clock tree description in DT and they then switched to much simpler > clock description where the clock topology is encoded in the driver > instead (like what iMX does right now). It might be worth having a look > at that and the reasoning around that conversion. I took inspiration from Tero Kristo's work on the clock subsystem for TI platforms. I think he did a great job in both device tree definition and driver implementation. IMHO, this way the drivers are more flexible and the code can be more easily re-used on more platforms. Thanks and regards, Dario -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel