From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A606C433E1 for ; Sun, 12 Jul 2020 18:47:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63A662063A for ; Sun, 12 Jul 2020 18:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EjRvmr9z"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U/N/BqnU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63A662063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T38OMTaeKQmeVhYEZw316qrOaolYes1IjvbLMfXfP38=; b=EjRvmr9z8kwtsvmCXXrLp3swQ UfIHHbB4b6pjfha4B3uXt5m4DGYKYkm1/lKNtd1oWvWUvJvj/QwCQ+1f61Ign39kWBAuiM2pvofxY itX7yyHbiziwjbRgqEaB/9gaVcGtC900tzAg3f3RDftlodyRqmDslMZ93KzcKLiv02GBREW35BAiH qWTPTyZOD8uf6GKywl3CIUPhQcLeEpeZBhn0tfdGWs04PYZAGN1InpQjyzkayRG2GCzVheiI/gb6v LXz8cXispWK7iCswwmYb0KBfRNXi7LMI7np0Yx2dh7jjoDrWDgU3mWLVdqaQ/UOooz/KRA67Zlnzo imZwV7/Jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jugzK-00056n-Fd; Sun, 12 Jul 2020 18:46:10 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jugzH-00056C-Qs; Sun, 12 Jul 2020 18:46:08 +0000 Received: by mail-ej1-x641.google.com with SMTP id ga4so12413528ejb.11; Sun, 12 Jul 2020 11:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d6Qek2fkCB/2CxHUEUFljSHTbzdbT53VAPl6aQJ65nc=; b=U/N/BqnUCvWI0p7yxG2u7x1vPloQ9p/Em95pZUJPFerIQ2ouVRXGI8hZUnMn/VABwx TXKgQCLaH7No+8qniaeGoOxzVPHABpfGm/urW4tnTUdewTx14NpliaxCjWWpfT1mtqYh BQeNTcszQ7vOke9OlkuoxsGkDlZ4IAYdfrq3DQ2WGE8LjvWF1h2WFSmc1uoT6sGvaTdT 4IQQus/LxyRsRZMkQILkKsKUy5MhfM0USJIcMgPV4N51Jd5ZCwXkiKttJM5JfyDBBLUA h08Qv9sQ9chSfLi1rwMSDtIgTEDxaXNiUCiEuC8a7gHt6lwSVkI0q1ToIgMwf/9F53CZ DRlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d6Qek2fkCB/2CxHUEUFljSHTbzdbT53VAPl6aQJ65nc=; b=HAZu+bkDMlW4VqEgxvIoqgxK5XVc5SNAmZ0/WLMNFwu6UUSxXX9mQBucL6OsFYdA65 qWvyLc6C9NL2TBhQACmvdt3VE8GLyoz65ug0bcRkTHbqailliEtyUaHAnQh/NGWlPc9A CIXXOQHGjOgybaveDyw0r5cJIVQBflkfDOgKMeWnGetC4uNtviffu5cPgWxwRS6LwiRm 97Iefl8y/bnnxUjSeEPwBuP1t0G91QbqXY8/SrGpHulig+NcY581Hea9/xRIFrPwxSUg QhsgU8/rZfw/GgEelo1DfUhdiRD5dUdqaNUZzLSilLnLshDsXLxN5MDEYJJsvrOZk62K wCjw== X-Gm-Message-State: AOAM533fcsdHEV3+aY7rRma+7AQ0mG1piRBUOjT95LelWfEQIcOlpBG9 Nby2VPJyw+vg72Fv/BwHbiO4NdfOh1QkmL6X+KE= X-Google-Smtp-Source: ABdhPJwPn7kb6uSoDv+CUpFNn4npaWHCyaF2trLzwY77zvp/DeuKhGJnpDPtyB12EiCtBA3gqLudJYd+2yBlgvEE3k0= X-Received: by 2002:a17:906:1414:: with SMTP id p20mr69197044ejc.247.1594579564886; Sun, 12 Jul 2020 11:46:04 -0700 (PDT) MIME-Version: 1.0 References: <1593701576-28580-1-git-send-email-amittomer25@gmail.com> <1593701576-28580-11-git-send-email-amittomer25@gmail.com> <20200712173044.GL6110@Mani-XPS-13-9360> In-Reply-To: <20200712173044.GL6110@Mani-XPS-13-9360> From: Amit Tomer Date: Mon, 13 Jul 2020 00:15:28 +0530 Message-ID: Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7 To: Manivannan Sadhasivam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200712_144607_913897_6C2E4BD5 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Andre Przywara , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, cristian.ciocaltea@gmail.com, Rob Herring , =?UTF-8?Q?Andreas_F=C3=A4rber?= , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, Jul 12, 2020 at 11:00 PM Manivannan Sadhasivam wrote: > > On Thu, Jul 02, 2020 at 08:22:56PM +0530, Amit Singh Tomar wrote: > > This commit adds uSD support for Cubieboard7 board based on Actions Semi > > S700 SoC. SD0 is connected to uSD slot. Since there is no PMIC support > > added yet, fixed regulator has been used as a regulator node. > > > > Signed-off-by: Amit Singh Tomar > > --- > > Changes since v4: > > * No change. > > Changes since v3: > > * No change. > > Changes since v2: > > * No change. > > Changes since v1: > > * No change. > > Changes since RFC: > > * No change. > > --- > > arch/arm64/boot/dts/actions/s700-cubieboard7.dts | 41 ++++++++++++++++++++++++ > > arch/arm64/boot/dts/actions/s700.dtsi | 1 + > > 2 files changed, 42 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > index 63e375cd9eb4..ec117eb12f3a 100644 > > --- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > +++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts > > @@ -13,6 +13,7 @@ > > > > aliases { > > serial3 = &uart3; > > + mmc0 = &mmc0; > > }; > > > > chosen { > > @@ -28,6 +29,23 @@ > > device_type = "memory"; > > reg = <0x1 0xe0000000 0x0 0x0>; > > }; > > + > > + /* Fixed regulator used in the absence of PMIC */ > > + vcc_3v1: vcc-3v1 { > > + compatible = "regulator-fixed"; > > + regulator-name = "fixed-3.1V"; > > + regulator-min-microvolt = <3100000>; > > + regulator-max-microvolt = <3100000>; > > + }; > > Is this regulator used somewhere? This is something I copied from bubblegum dts as I wasn't sure what is right way to include these regulators. Also, another day tested it without having these regulators in , and still it seems to work. So should these be removed ? Thanks -Amit _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel