From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-spi <linux-spi@vger.kernel.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Harini Katakam <harinik@xilinx.com>,
linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: spi: convert Cadence SPI bindings to YAML
Date: Sat, 5 Jun 2021 09:24:32 +0900 [thread overview]
Message-ID: <CABMQnV+waVdAcnbdYJnxt8rM2JfdcTuPBnJ+XK0Pie1Twar0Fg@mail.gmail.com> (raw)
In-Reply-To: <20210604214608.GA3974358@robh.at.kernel.org>
Hi,
Thanks for your review.
2021年6月5日(土) 6:46 Rob Herring <robh@kernel.org>:
>
> On Mon, May 31, 2021 at 11:15:38PM +0900, Nobuhiro Iwamatsu wrote:
> > Convert spi for Cadence SPI bindings documentation to YAML.
> >
> > Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> > ---
> > .../devicetree/bindings/spi/spi-cadence.txt | 30 ---------
> > .../devicetree/bindings/spi/spi-cadence.yaml | 63 +++++++++++++++++++
> > 2 files changed, 63 insertions(+), 30 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/spi/spi-cadence.txt
> > create mode 100644 Documentation/devicetree/bindings/spi/spi-cadence.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.txt b/Documentation/devicetree/bindings/spi/spi-cadence.txt
> > deleted file mode 100644
> > index 05a2ef945664be..00000000000000
> > --- a/Documentation/devicetree/bindings/spi/spi-cadence.txt
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -Cadence SPI controller Device Tree Bindings
> > --------------------------------------------
> > -
> > -Required properties:
> > -- compatible : Should be "cdns,spi-r1p6" or "xlnx,zynq-spi-r1p6".
> > -- reg : Physical base address and size of SPI registers map.
> > -- interrupts : Property with a value describing the interrupt
> > - number.
> > -- clock-names : List of input clock names - "ref_clk", "pclk"
> > - (See clock bindings for details).
> > -- clocks : Clock phandles (see clock bindings for details).
> > -
> > -Optional properties:
> > -- num-cs : Number of chip selects used.
> > - If a decoder is used, this will be the number of
> > - chip selects after the decoder.
> > -- is-decoded-cs : Flag to indicate whether decoder is used or not.
> > -
> > -Example:
> > -
> > - spi@e0007000 {
> > - compatible = "xlnx,zynq-spi-r1p6";
> > - clock-names = "ref_clk", "pclk";
> > - clocks = <&clkc 26>, <&clkc 35>;
> > - interrupt-parent = <&intc>;
> > - interrupts = <0 49 4>;
> > - num-cs = <4>;
> > - is-decoded-cs = <0>;
> > - reg = <0xe0007000 0x1000>;
> > - } ;
> > diff --git a/Documentation/devicetree/bindings/spi/spi-cadence.yaml b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> > new file mode 100644
> > index 00000000000000..27a7121ed0f9ae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/spi-cadence.yaml
> > @@ -0,0 +1,63 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/spi-cadence.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Cadence SPI controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Michal Simek <michal.simek@xilinx.com>
> > +
> > +allOf:
> > + - $ref: "spi-controller.yaml#"
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - cdns,spi-r1p6
> > + - xlnx,zynq-spi-r1p6
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clock-names:
> > + items:
> > + - const: ref_clk
> > + - const: pclk
> > +
> > + clocks:
> > + maxItems: 2
> > +
> > + num-cs:
> > + description: |
> > + Number of chip selects used. If a decoder is used,
> > + this will be the number of chip selects after the
> > + decoder.
> > + minimum: 1
> > + maximum: 4
> > + default: 4
> > +
> > + is-decoded-cs:
>
> Needs a type ref. Despite being called a 'flag' looks like it's an
> uint32. Presumably, it also needs:
>
> enum: [ 0, 1 ]
Yeah, this is a flag, but the driver source code uses it as u32.
So, I will add ref and enum, thanks.
>
> > + description: |
> > + Flag to indicate whether decoder is used or not.
> > + default: 0
Best regards,
Nobuhiro
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-05 0:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 14:15 [PATCH] dt-bindings: spi: convert Cadence SPI bindings to YAML Nobuhiro Iwamatsu
2021-06-04 21:46 ` Rob Herring
2021-06-05 0:24 ` Nobuhiro Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABMQnV+waVdAcnbdYJnxt8rM2JfdcTuPBnJ+XK0Pie1Twar0Fg@mail.gmail.com \
--to=iwamatsu@nigauri.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=harinik@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).