From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65228C433B4 for ; Tue, 18 May 2021 04:31:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE0FB60E08 for ; Tue, 18 May 2021 04:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE0FB60E08 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W7v2EY4ZrX9vO0bhxKhkXgTqwBQQ2utwt/8+wCVQv0Y=; b=KpZvLQpiNhToXrx1FnwH+B6Pn QxH8mglitvYRdNB8rRuFApxdEYnyH9/fbOj6YxQX89SOCtyC+2G+4Ov+THDd8357W3YNl85d05XHm j+GAEYBfR6H+5EiKDwyMuXPDGuHI9YGVukzXCiIK1350O2mWw1cgYX8bQ61n7afpWrX181zdceYlz GZ+iP7Fv5oUl7szwtvi2I7jGBZK6J9B3ZdfT7cXXpvZW9UWA65S7YUDlpWBGp6G04/ehmw2MZ7fdS ZsdPhQ5lMz06dhMFIcHV7sqK/oXniOcL0S9hmDdujuHJKs8JAHh4djDglhTJyrQLLn8GGwJnP5O1o ONC/99W6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lirMW-00GvTv-1E; Tue, 18 May 2021 04:29:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lirMR-00GvTN-Jo for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 04:29:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IYivGhbkgN/0kOX9moGua2NF+G4pIWkoseKbkugbZk8=; b=yN3i5HrAvoEt3Kpm7OhPTGb6oy 6jlUsvMuTvvCqvbytfhpC0STUu8hOGjo/T67yIennGLVDBgX8dEtBi3wGD6yb5wQQlTKDL9tH0I3O OvLITYZlV0SKi1KhbxkROe3SDCE1eTO9I7TbGFzo7/KJux5nEjt1O1jytaAtkblnD7bOsVA/FPaO9 iucI5JZg7m2CeTPqNgX2PQNrDSfk5EkZEDNiyhjPxlzyk5jK4aDSF8nZ9WfnOHGGvWOhS9LFqtWPn HoEWOCpnmBCpaJUEXmFSLX9yo29M5TkMXPppOqQ9SJy8RAw92c0jKNICaNROgQ1YBMl8yYC7qnAt3 jeqz9o+w==; Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lirMO-00EImU-NP for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 04:29:38 +0000 Received: by mail-wr1-x433.google.com with SMTP id r12so8598015wrp.1 for ; Mon, 17 May 2021 21:29:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IYivGhbkgN/0kOX9moGua2NF+G4pIWkoseKbkugbZk8=; b=b/QzFYlSCIrp2x7Ol1KR9fZeYmrh9fuQnORQMISfz94c4LGcCztOQE+joRIa/yDCvm S6KZQhefd9EsRZUSyi9v9GDwzs4U/UMjeFz1Q0xM9W3W8q6UAbre3ZSENZKRgKY0qf/L OHE6Isb5ZXUK8zDPXLpLv/nQSMqznz4rsAmnfR+ilt9ju4kumWfbm2KIa1+ug3Jm04S1 cSmQTjvsI35Hauy72QZNRZJ8ZDh+KihfuTUtWWGhY3j4NUkOkh2mGY8J+zj99l6Fm/mg EfOQ93cGSGKpLzytWUn5d7vN8Y7xZTxBoV7lO6XHMbA4+vEEeOHinXYmk2nhWOiSkmb1 /fkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IYivGhbkgN/0kOX9moGua2NF+G4pIWkoseKbkugbZk8=; b=lVxpybtrJoGkDD9fPVz+OCsx3Z1gsiSmvuxbcaj/ubdyuHqsT+YwO6kG0+O0n3y85V TkGP4Kodhabgtgo9oUp7NNnFxN3Kg0guOMqnuJDcFIuUh2b7dg+F+0QifCMBE9cDXZm4 /xWJueh3PUOdnHY2kA/kWVopqBsah4zvgypOO1E2zmL4Kpj9aEzIALJpMk75AscVjBRf uh2vAmsAIKBrAlC+3vCpexaWXTvtDFU3F1cP3yfS+GlOp+Y9fSWFiJjfY4rRiMiMZqPg BF4RWwfh8+7WZPtAOflGvs9QDC7b1NnBtsOXU0G2p1v+enRFA5XXVpIejae9QApZDp5k Olrw== X-Gm-Message-State: AOAM532DZ0gLZW6e3gSwGjE7jONsZzFMVQXi9of800yRWlsGjvq4xu6F vT35EJ9yAKuaDriyk1Kh7jNmAYPT/ZraSD1sYz1mBQ== X-Google-Smtp-Source: ABdhPJz73C/JeMEY7R3wJhYkQwIiUPW6qbsA6Exu7snYht6lCDkBlkpzGwS739hPzgZX0IvEs+sGHHVFeJ+yjoeM/7g= X-Received: by 2002:a05:6000:1147:: with SMTP id d7mr4151974wrx.302.1621312173995; Mon, 17 May 2021 21:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-6-davidgow@google.com> In-Reply-To: From: David Gow Date: Tue, 18 May 2021 12:29:22 +0800 Message-ID: Subject: Re: [PATCH v2 06/10] mmc: sdhci-of-aspeed: Remove some unnecessary casts from KUnit tests To: Ulf Hansson Cc: Brendan Higgins , Daniel Latypov , Shuah Khan , Andrew Jeffery , Adrian Hunter , Joel Stanley , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , linux-mmc , linux-aspeed , OpenBMC Maillist , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_212936_794558_0A8EC14B X-CRM114-Status: GOOD ( 26.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 17, 2021 at 5:23 PM Ulf Hansson wrote: > > On Thu, 13 May 2021 at 21:36, David Gow wrote: > > > > With KUnit's EXPECT macros no longer typechecking arguments as strictly, > > get rid of a number of now unnecessary casts. > > > > Signed-off-by: David Gow > > I guess you will funnel this via another tree than the mmc? > > Acked-by: Ulf Hansson > > Kind regards > Uffe > Yeah: the plan is to have this whole series go through the kselftest/kunit tree so we don't have to worry about potentially temporarily introducing a bunch of compiler warnings. Cheers, -- David > > --- > > This should be a no-op functionality wise, and while it depends on the > > first couple of patches in this series, it's otherwise independent from > > the others. I think this makes the test more readable, but if you > > particularly dislike it, I'm happy to drop it. > > > > drivers/mmc/host/sdhci-of-aspeed-test.c | 34 ++++++++++++------------- > > 1 file changed, 17 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci-of-aspeed-test.c b/drivers/mmc/host/sdhci-of-aspeed-test.c > > index bb67d159b7d8..1ed4f86291f2 100644 > > --- a/drivers/mmc/host/sdhci-of-aspeed-test.c > > +++ b/drivers/mmc/host/sdhci-of-aspeed-test.c > > @@ -26,23 +26,23 @@ static void aspeed_sdhci_phase_ddr52(struct kunit *test) > > KUNIT_EXPECT_EQ(test, 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 25)); > > > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > > aspeed_sdhci_phase_to_tap(NULL, rate, 181)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 182)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 183)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > > aspeed_sdhci_phase_to_tap(NULL, rate, 184)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > aspeed_sdhci_phase_to_tap(NULL, rate, 203)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 204)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 205)); > > } > > > > @@ -67,21 +67,21 @@ static void aspeed_sdhci_phase_hs200(struct kunit *test) > > KUNIT_EXPECT_EQ(test, 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 96)); > > > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 186)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > > aspeed_sdhci_phase_to_tap(NULL, rate, 187)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > > aspeed_sdhci_phase_to_tap(NULL, rate, 269)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 270)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 271)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > > aspeed_sdhci_phase_to_tap(NULL, rate, 276)); > > } > > > > -- > > 2.31.1.751.gd2f1c929bd-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel