From: Jon Nettleton <jon@solid-run.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Linuxarm <linuxarm@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
wanghuiqiang <wanghuiqiang@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>,
Steven Price <steven.price@arm.com>,
Sami Mujawar <Sami.Mujawar@arm.com>,
Eric Auger <eric.auger@redhat.com>,
yangyicong <yangyicong@huawei.com>
Subject: Re: [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev
Date: Sat, 9 Oct 2021 09:07:54 +0200 [thread overview]
Message-ID: <CABdtJHv+SZ15RcBaFt0w4iTsMMbAjGB2Wm4GST3cNw+2Q=OeVw@mail.gmail.com> (raw)
In-Reply-To: <44e00e32-be89-1174-beb5-9a2fca85a683@arm.com>
On Fri, Oct 8, 2021 at 3:10 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> On 2021-08-05 09:07, Shameer Kolothum wrote:
> > Get ACPI IORT RMR regions associated with a dev reserved
> > so that there is a unity mapping for them in SMMU.
>
> This feels like most of it belongs in the IORT code rather than
> iommu-dma (which should save the temporary list copy as well).
See previous comment. The original intent was for device-tree to also
be able to use these mechanisms to create RMR's and support them
in the SMMU.
-Jon
>
> Robin.
>
> > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> > ---
> > drivers/iommu/dma-iommu.c | 56 +++++++++++++++++++++++++++++++++++----
> > 1 file changed, 51 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> > index 1b6e27475279..c1ae0c3d4b33 100644
> > --- a/drivers/iommu/dma-iommu.c
> > +++ b/drivers/iommu/dma-iommu.c
> > @@ -207,22 +207,68 @@ void iommu_dma_put_rmrs(struct fwnode_handle *iommu_fwnode,
> > }
> > EXPORT_SYMBOL(iommu_dma_put_rmrs);
> >
> > +static bool iommu_dma_dev_has_rmr(struct iommu_fwspec *fwspec,
> > + struct iommu_resv_region *e)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < fwspec->num_ids; i++) {
> > + if (e->fw_data.rmr.sid == fwspec->ids[i])
> > + return true;
> > + }
> > +
> > + return false;
> > +}
> > +
> > +static void iommu_dma_get_rmr_resv_regions(struct device *dev,
> > + struct list_head *list)
> > +{
> > + struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev);
> > + struct list_head rmr_list;
> > + struct iommu_resv_region *rmr, *tmp;
> > +
> > + INIT_LIST_HEAD(&rmr_list);
> > + if (iommu_dma_get_rmrs(fwspec->iommu_fwnode, &rmr_list))
> > + return;
> > +
> > + if (dev_is_pci(dev)) {
> > + struct pci_dev *pdev = to_pci_dev(dev);
> > + struct pci_host_bridge *host = pci_find_host_bridge(pdev->bus);
> > +
> > + if (!host->preserve_config)
> > + return;
> > + }
> > +
> > + list_for_each_entry_safe(rmr, tmp, &rmr_list, list) {
> > + if (!iommu_dma_dev_has_rmr(fwspec, rmr))
> > + continue;
> > +
> > + /* Remove from iommu RMR list and add to dev resv_regions */
> > + list_del_init(&rmr->list);
> > + list_add_tail(&rmr->list, list);
> > + }
> > +
> > + iommu_dma_put_rmrs(fwspec->iommu_fwnode, &rmr_list);
> > +}
> > +
> > /**
> > * iommu_dma_get_resv_regions - Reserved region driver helper
> > * @dev: Device from iommu_get_resv_regions()
> > * @list: Reserved region list from iommu_get_resv_regions()
> > *
> > * IOMMU drivers can use this to implement their .get_resv_regions callback
> > - * for general non-IOMMU-specific reservations. Currently, this covers GICv3
> > - * ITS region reservation on ACPI based ARM platforms that may require HW MSI
> > - * reservation.
> > + * for general non-IOMMU-specific reservations. Currently this covers,
> > + * -GICv3 ITS region reservation on ACPI based ARM platforms that may
> > + * require HW MSI reservation.
> > + * -Any ACPI IORT RMR memory range reservations (IORT spec rev E.b)
> > */
> > void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list)
> > {
> >
> > - if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode))
> > + if (!is_of_node(dev_iommu_fwspec_get(dev)->iommu_fwnode)) {
> > iort_iommu_msi_get_resv_regions(dev, list);
> > -
> > + iommu_dma_get_rmr_resv_regions(dev, list);
> > + }
> > }
> > EXPORT_SYMBOL(iommu_dma_get_resv_regions);
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-09 7:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 8:07 [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2021-08-05 8:07 ` [PATCH v7 1/9] iommu: Introduce a union to struct iommu_resv_region Shameer Kolothum
2021-08-20 10:22 ` Steven Price
2021-10-08 12:14 ` Robin Murphy
2021-10-09 6:57 ` Jon Nettleton
2021-10-11 5:47 ` Shameerali Kolothum Thodi
2021-10-11 13:47 ` Robin Murphy
2021-08-05 8:07 ` [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing Shameer Kolothum
2021-08-05 16:03 ` Lorenzo Pieralisi
2021-08-05 16:31 ` Jon Nettleton
2021-08-05 18:37 ` Laurentiu Tudor
2021-09-06 17:44 ` Robin Murphy
2021-09-06 19:51 ` Jon Nettleton
2021-09-16 7:26 ` Shameerali Kolothum Thodi
2021-09-16 7:52 ` Jon Nettleton
2021-09-16 8:26 ` Shameerali Kolothum Thodi
2021-09-16 11:16 ` Jon Nettleton
2021-09-17 11:26 ` Shameerali Kolothum Thodi
2021-10-05 10:53 ` Laurentiu Tudor
2021-10-08 12:48 ` Robin Murphy
2021-10-09 7:06 ` Jon Nettleton
2021-10-11 14:04 ` Robin Murphy
2021-10-12 8:00 ` Jon Nettleton
2021-12-08 12:18 ` Lorenzo Pieralisi
2021-12-08 13:26 ` Jon Nettleton
2021-12-08 14:37 ` Robin Murphy
2021-12-08 15:11 ` Jon Nettleton
2021-10-11 5:59 ` Shameerali Kolothum Thodi
2021-08-05 8:07 ` [PATCH v7 3/9] iommu/dma: Introduce generic helper to retrieve RMR info Shameer Kolothum
2021-10-08 13:03 ` Robin Murphy
2021-10-11 5:51 ` Shameerali Kolothum Thodi
2021-08-05 8:07 ` [PATCH v7 4/9] ACPI/IORT: Add a helper to retrieve RMR memory regions Shameer Kolothum
2021-08-05 15:43 ` Lorenzo Pieralisi
2021-08-05 8:07 ` [PATCH v7 5/9] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum
2021-08-05 8:07 ` [PATCH v7 6/9] iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force bypass Shameer Kolothum
2021-08-05 8:07 ` [PATCH v7 7/9] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum
2021-08-05 8:07 ` [PATCH v7 8/9] iommu/arm-smmu: Get associated RMR info and install bypass SMR Shameer Kolothum
2021-08-05 8:07 ` [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev Shameer Kolothum
2021-10-08 13:09 ` Robin Murphy
2021-10-09 7:07 ` Jon Nettleton [this message]
2021-10-11 15:00 ` Robin Murphy
2021-10-11 15:42 ` Shameerali Kolothum Thodi
2021-08-05 13:22 ` [PATCH v7 0/9] ACPI/IORT: Support for IORT RMR node Ard Biesheuvel
2021-08-05 13:35 ` Shameerali Kolothum Thodi
2021-08-05 14:09 ` Ard Biesheuvel
2021-08-31 5:06 ` Jon Nettleton
2021-09-30 9:47 ` Eric Auger
2021-09-30 10:50 ` Shameerali Kolothum Thodi
2022-01-25 13:00 ` Shameerali Kolothum Thodi
2022-01-25 19:30 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABdtJHv+SZ15RcBaFt0w4iTsMMbAjGB2Wm4GST3cNw+2Q=OeVw@mail.gmail.com' \
--to=jon@solid-run.com \
--cc=Sami.Mujawar@arm.com \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=wanghuiqiang@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).