From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146F2CA9EAE for ; Tue, 29 Oct 2019 15:58:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC15020856 for ; Tue, 29 Oct 2019 15:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TrNBleY1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="auxvEGz+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC15020856 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M6CAZUKFUfm9TjbrKAOHOgx1b3MUTdKcfd3+892m1+g=; b=TrNBleY1nAbvym CeV0KqOM/sq1yetkcRrwjYK8ebeUVaACMKYgwy9HorjSYr+7LVIjWqK6XbxEPOgOJ6Pw9F+DSM7HG x2QvCzHrca6QkGY/P4K9N636jo5UFTny2qgxbexkiwK9GsL5wPih/YT2OMKOFCKtYmLA1deweMFLD MVdpIux1N2Q6Ilxjjh9MofO7dxOS+rZKJ7I5YMrgAPye5vO14nNYOBh9itLkR6HJ2GF1K39qxWoR4 Spybyr6N1pDxBNE8THderUM0O42nrf3zSUW8r9bbozGsluQodw3Tbgm/J7AcvMVBkp98d36UJZhwF E2vDEn6cqnE3sK1iYGVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPTtN-0001CN-4c; Tue, 29 Oct 2019 15:58:45 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPTtI-00019o-HM for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 15:58:42 +0000 Received: by mail-wm1-x342.google.com with SMTP id c22so2991853wmd.1 for ; Tue, 29 Oct 2019 08:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ogyg03BfT8gaHZbuV4/3535qjZlsTqwkzaB+k+qmJSk=; b=auxvEGz+98ZDBi/3qT4estTcr/B0w8IzvpYRBlJghVDt+kEZTN1DrBp6hsX/szCm0S Ntg3b9Z1+ejknx7Ccrkleqkzjl8Ky11vHSpEAGmlWVbc6JJnMtLuoVbGHlLb8LrKT3cn uKPaHB3q+wCzJC2R81txkKTpwzgO4YZ3vvsV8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ogyg03BfT8gaHZbuV4/3535qjZlsTqwkzaB+k+qmJSk=; b=F4vH5cl3Ya3BNB42zH/8HE4G59vYtocUc/02w7HlAW7rfox6gGFXOkeoEeDXtg3moe QtWWTLd3Ebpr5RE0kVzmLLXr7P6yMXyQ1Is+YsaeD9pVfePXUmJyvBvAlvFCAK394I7m 2pIc8cCiGopOGMP46wqSdBwpiLNOTu1zGP1NtiUwtICZpEnwMngIrRJkTWf9QyyzH8jH kug9zUWyNRDi0uoRvUr5BpB9B931D/UYVZxDp4QhUIiZ4//Wowj/Sz+RGBQrSXPPp+Gu cFUuB0++NaWripaC19fnE6Cj7PkjSk0F6vHgNVKY/quedEIotnpoxfC3NNeaj9hGB0OC i2ew== X-Gm-Message-State: APjAAAUSLFAkcZLo5KKrXxofEowphESUj1j3SXDBrhTPmnlO4Ing7aaK 0/HhYvlfHc8CFUyKwoimyZr52Jp/SkIjKQQ4A672UQ== X-Google-Smtp-Source: APXvYqxXBunHeyxtZsAWTCPejceTiGMbnnAGC4cBuQxzLelWDxFoP9zriSI9AupBxaoECqcivUoGxX1DNc3YZFr8rtQ= X-Received: by 2002:a1c:6282:: with SMTP id w124mr4723287wmb.172.1572364718992; Tue, 29 Oct 2019 08:58:38 -0700 (PDT) MIME-Version: 1.0 References: <20191028163256.8004-1-robh@kernel.org> <20191028163256.8004-8-robh@kernel.org> In-Reply-To: <20191028163256.8004-8-robh@kernel.org> From: Srinath Mannam Date: Tue, 29 Oct 2019 21:28:27 +0530 Message-ID: Subject: Re: [PATCH v3 07/25] PCI: iproc: Use pci_parse_request_of_pci_ranges() To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_085840_593716_7641032F X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Karthikeyan Mitran , linux-pci@vger.kernel.org, Linus Walleij , Matthias Brugger , Thomas Petazzoni , Toan Le , Will Deacon , Lorenzo Pieralisi , Michal Simek , Christoph Hellwig , linux-rockchip@lists.infradead.org, BCM Kernel Feedback , Shawn Lin , Ray Jui , Hou Zhiqiang , Ryder Lee , linux-mediatek@lists.infradead.org, Andrew Murray , Bjorn Helgaas , Linux ARM , Scott Branden , Jingoo Han , rfi@lists.rocketboards.org, linux-renesas-soc@vger.kernel.org, Tom Joseph , Simon Horman , Gustavo Pimentel , Ley Foon Tan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, I reviewed and verified this change.. It is working fine. Regards, Srinath. On Mon, Oct 28, 2019 at 10:03 PM Rob Herring wrote: > > Convert the iProc host bridge to use the common > pci_parse_request_of_pci_ranges(). > > There's no need to assign the resources to a temporary list, so just use > bridge->windows directly. > > Cc: Lorenzo Pieralisi > Cc: Bjorn Helgaas > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Reviewed-by: Andrew Murray > Signed-off-by: Rob Herring > --- > drivers/pci/controller/pcie-iproc-platform.c | 8 ++------ > drivers/pci/controller/pcie-iproc.c | 5 ----- > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c > index 9ee6200a66f4..375d815f7301 100644 > --- a/drivers/pci/controller/pcie-iproc-platform.c > +++ b/drivers/pci/controller/pcie-iproc-platform.c > @@ -43,8 +43,6 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) > struct iproc_pcie *pcie; > struct device_node *np = dev->of_node; > struct resource reg; > - resource_size_t iobase = 0; > - LIST_HEAD(resources); > struct pci_host_bridge *bridge; > int ret; > > @@ -97,8 +95,7 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) > if (IS_ERR(pcie->phy)) > return PTR_ERR(pcie->phy); > > - ret = devm_of_pci_get_host_bridge_resources(dev, 0, 0xff, &resources, > - &iobase); > + ret = pci_parse_request_of_pci_ranges(dev, &bridge->windows, NULL); > if (ret) { > dev_err(dev, "unable to get PCI host bridge resources\n"); > return ret; > @@ -113,10 +110,9 @@ static int iproc_pcie_pltfm_probe(struct platform_device *pdev) > pcie->map_irq = of_irq_parse_and_map_pci; > } > > - ret = iproc_pcie_setup(pcie, &resources); > + ret = iproc_pcie_setup(pcie, &bridge->windows); > if (ret) { > dev_err(dev, "PCIe controller setup failed\n"); > - pci_free_resource_list(&resources); > return ret; > } > > diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c > index 2d457bfdaf66..223335ee791a 100644 > --- a/drivers/pci/controller/pcie-iproc.c > +++ b/drivers/pci/controller/pcie-iproc.c > @@ -1498,10 +1498,6 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res) > return ret; > } > > - ret = devm_request_pci_bus_resources(dev, res); > - if (ret) > - return ret; > - > ret = phy_init(pcie->phy); > if (ret) { > dev_err(dev, "unable to initialize PCIe PHY\n"); > @@ -1543,7 +1539,6 @@ int iproc_pcie_setup(struct iproc_pcie *pcie, struct list_head *res) > if (iproc_pcie_msi_enable(pcie)) > dev_info(dev, "not using iProc MSI\n"); > > - list_splice_init(res, &host->windows); > host->busnr = 0; > host->dev.parent = dev; > host->ops = &iproc_pcie_ops; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel