From: Adrien Grassein <adrien.grassein@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: DTML <devicetree@vger.kernel.org>,
will@kernel.org, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
catalin.marinas@arm.com, Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip
Date: Wed, 17 Feb 2021 15:43:26 +0100 [thread overview]
Message-ID: <CABkfQAGyushYbaYkmfGdNjw3Ssaw7DgLJ5iomJPtRdHS0Rbobg@mail.gmail.com> (raw)
In-Reply-To: <20210217115814.zfwhd5fwb2ibygt3@kozik-lap>
Hello,
Thanks for your review and your time.
Le mer. 17 févr. 2021 à 12:58, Krzysztof Kozlowski <krzk@kernel.org> a écrit :
>
> On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote:
> > Add usdhc3 description which corresponds to the wifi/bt chip
> >
> > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > ---
> > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > index c0c384d76147..bf20a40bcda0 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> > @@ -9,6 +9,18 @@
> > / {
> > model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
> > compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
> > +
> > + reg_wlan_vmmc: regulator-wlan-vmmc {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_wlan_vmmc>;
> > + regulator-name = "reg_wlan_vmmc";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + startup-delay-us = <70000>;
>
> That's quite a startup time... and it happens is the same as in bindings
> example. Do you really need it or it was just copied?
>
> I actually don't mind it, just poking at various things. :)
>
It was a copy/paste. I've just retested without this, it works.
> > + };
> > };
> >
> > &A53_0 {
> > @@ -206,6 +218,19 @@ &usdhc2 {
> > status = "okay";
> > };
> >
> > +/* wlan */
> > +&usdhc3 {
> > + bus-width = <4>;
> > + sdhci-caps-mask = <0x2 0x0>;
> > + non-removable;
> > + pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > + pinctrl-0 = <&pinctrl_usdhc3>;
> > + pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> > + pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> > + vmmc-supply = <®_wlan_vmmc>;
>
> What about vqmmc?
>
It was missing, thanks,
> Best regards,
> Krzysztof
Best regards,
Adrien
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-17 14:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 23:19 [PATCH 0/8] Add peripheral support for imx8mm-nitrogen-r2 board Adrien Grassein
2021-02-15 23:19 ` [PATCH 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip Adrien Grassein
2021-02-17 11:58 ` Krzysztof Kozlowski
2021-02-17 14:43 ` Adrien Grassein [this message]
2021-02-15 23:19 ` [PATCH 2/8] arm64: dts: imx8mm-nitrogen-r2: add USB support Adrien Grassein
2021-02-17 12:03 ` Krzysztof Kozlowski
2021-02-15 23:19 ` [PATCH 3/8] arm64: dts: imx8mm-nitrogen-r2: add espi2 support Adrien Grassein
2021-02-17 14:20 ` Krzysztof Kozlowski
2021-02-15 23:19 ` [PATCH 4/8] arm64: dts: imx8mm-nitrogen-r2: add uarts Adrien Grassein
2021-02-17 14:22 ` Krzysztof Kozlowski
2021-02-17 16:09 ` Adrien Grassein
2021-02-15 23:19 ` [PATCH 5/8] arm64: dts: imx8mm-nitrogen-r2: add pwms Adrien Grassein
2021-02-17 14:25 ` Krzysztof Kozlowski
2021-02-15 23:19 ` [PATCH 6/8] arm64: dts: imx8mm-nitrogen-r2: add flexspi Adrien Grassein
2021-02-17 14:27 ` Krzysztof Kozlowski
2021-02-15 23:19 ` [PATCH 7/8] arm64: dts: imx8mm-nitrogen-r2: add sai Adrien Grassein
2021-02-15 23:19 ` [PATCH 8/8] arm64: defconfig: Enable wm8960 audio driver Adrien Grassein
2021-02-17 14:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABkfQAGyushYbaYkmfGdNjw3Ssaw7DgLJ5iomJPtRdHS0Rbobg@mail.gmail.com \
--to=adrien.grassein@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).