From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64B26C04A95 for ; Wed, 28 Sep 2022 12:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=w7a7+gUe5qTtBnU2FLgiEwj+9LKm7FgkNB/sGxR6aUc=; b=AZJIc9G3suwl2jUHGLvaaM76fW +kllD+4vOLOPuny0f8wNABjQqhzDyDBaHawfOBxkTzIGQXCLh3cuuF7HYMdUf/3/IDQUcZodRwjb9 ii9AaQ+zy6zkeFNHETf9H+C4PDpcDQG62sZaC2vxVhU63Uv1QKueFgLeOcOj48iSYJvWZ4mct9MJo 9h/FdHC/W/7/98aW0IQ3lRGzTJ+b0NrygnCFB5iVu04Waghd6ypWfDfUyw7Wdj++zHYXrWc1NqpAX SPBhqPtfKWatktLle5Ne978eipo3xFQPmTtuaYbXx++EaVqlN4nKXyl4dPUMJxVco3teUkbEnVP/k 4rdiFp0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odW6W-00GDXv-QO; Wed, 28 Sep 2022 12:23:56 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odW6Q-00GDVn-Rw for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 12:23:55 +0000 Received: by mail-lf1-x131.google.com with SMTP id d42so20192943lfv.0 for ; Wed, 28 Sep 2022 05:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=Swb7XVMS5l4jVs+taUaFHDZniMnQe0LrNo5JVaq+smE=; b=c7CWUAsfmp+EUrBbsuVwHuXZYgfW2HVC0Li9FEyeBNVz54UBKlH/LwX+eoHjrw/RhN HgS0dnWmAJwxifOaPqgR6tmTb84kzSWbrL9exeYtUY0fduYToLJfXsgj6MPghccx5j+M 455J5Z9jH0S3XuLMki862MI98Ona3zIEpM/bACfbyA19QAIoYxKwCSLRj+rD8+kAIr3o 7HxESQA5LojmCE8FnZPaLunR8pN4t1Txi2JgQDvgZFhWprO8gHUPQ4datyPbLQ9eBa35 gbCYiQHE5tolljp0ZvNeexs29IETA3U2U2YvnLz27nJDLCzvEV87zs2Bq8knrfW2sb7q tZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=Swb7XVMS5l4jVs+taUaFHDZniMnQe0LrNo5JVaq+smE=; b=NQnqK7JIuKsyi2O/AXNCbQLxJpQNGoEvXm1jBxZmeu/YpOVE/UyP8ljw5J7Pg1/0XL Mesw23mFIidOJcBTfafZlPHmFqHqp6Gt62hnLcOA+4RDHVxmY98KkH6LvyMry2DN1/Me sAuz8lizqzmq6ZPE8CZDaz7gIB0FzjY2EwYNMa6J3IA2eTHEZk8oA6/H1bVvlLaCrx+W /2f+FOzPn3mla3bBTaFUD8c0dfiMqf1xust48Yp61kI60as+kOKDjQuaSn4ZO8hUGUvz CHv2S4xeDz+LYqCqOaLCUstns68VIRKPBHgsQwt878VU2eGxigv+8YbGiYDBebemQwY6 /1GA== X-Gm-Message-State: ACrzQf1d3hMQbcS2wxmtn58zG8ZS+ygvqNt0aILz2xizNoxyyjZ8LKmR NBi37u14H5q/BLbW2YFOCS6qKRdS5is41TGL5pMQrQ== X-Google-Smtp-Source: AMsMyM6y/zW9NWpjwXIpFeG7jR5sdtiQjNZFUTI8LJaS28E+8UxFW/BjROXWV6E4XvWqIlDYLzeduXvGYy1dfVvHhHk= X-Received: by 2002:a05:6512:5d7:b0:498:f521:e143 with SMTP id o23-20020a05651205d700b00498f521e143mr12968086lfo.617.1664367826958; Wed, 28 Sep 2022 05:23:46 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 28 Sep 2022 05:23:43 -0700 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-14-4844816c9808@baylibre.com> In-Reply-To: MIME-Version: 1.0 Date: Wed, 28 Sep 2022 05:23:43 -0700 Message-ID: Subject: Re: [PATCH v1 14/17] phy: mediatek: add support for phy-mtk-hdmi-mt8195 To: Chunfeng Yun , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_052351_127201_9B22793F X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Sep 2022 04:40, Chunfeng Yun wrote: >On Tue, 2022-09-27 at 06:23 -0700, Guillaume Ranquet wrote: >> On Tue, 20 Sep 2022 09:46, Chunfeng Yun >> wrote: >> > On Mon, 2022-09-19 at 18:56 +0200, Guillaume Ranquet wrote: >> > > Add basic support for the mediatek hdmi phy on MT8195 SoC >> > > >> > > Signed-off-by: Guillaume Ranquet >> > > >> > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> > > b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> > > index bb7593ea4c86..0157acdce56c 100644 >> > > --- a/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> > > +++ b/drivers/gpu/drm/mediatek/mtk_mt8195_hdmi.c >> > > @@ -1344,6 +1344,8 @@ static void mtk_hdmi_bridge_disable(struct >> > > drm_bridge *bridge, >> > > mtk_hdmi_disable_hdcp_encrypt(hdmi); >> > > usleep_range(50000, 50050); >> > > >> > > + phy_power_off(hdmi->phy); >> > > + >> > > hdmi->enabled = false; >> > > } >> > > >> > > diff --git a/drivers/phy/mediatek/Makefile >> > > b/drivers/phy/mediatek/Makefile >> > > index fb1f8edaffa7..c9a50395533e 100644 >> > > --- a/drivers/phy/mediatek/Makefile >> > > +++ b/drivers/phy/mediatek/Makefile >> > > @@ -12,6 +12,7 @@ obj-$(CONFIG_PHY_MTK_XSPHY) += phy- >> > > mtk- >> > > xsphy.o >> > > phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o >> > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi- >> > > mt2701.o >> > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi- >> > > mt8173.o >> > > +phy-mtk-hdmi-drv-y += phy-mtk-hdmi- >> > > mt8195.o >> > > obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o >> > > >> > > phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o >> > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c >> > > b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c >> > > new file mode 100644 >> > > index 000000000000..149015b64c02 >> > > --- /dev/null >> > > +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c >> > > @@ -0,0 +1,673 @@ >> > > +// SPDX-License-Identifier: GPL-2.0 >> > > +/* >> > > + * Copyright (c) 2021 MediaTek Inc. >> > > + * Copyright (c) 2021 BayLibre, SAS >> > > + */ >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > +#include >> > > + >> > > +#include "phy-mtk-hdmi.h" >> > > +#include "phy-mtk-hdmi-mt8195.h" >> > > + >> > > +static void mtk_hdmi_ana_fifo_en(struct mtk_hdmi_phy *hdmi_phy) >> > > +{ >> > > + /* make data fifo writable for hdmi2.0 */ >> > > + mtk_hdmi_phy_mask(hdmi_phy, HDMI_ANA_CTL, >> > > REG_ANA_HDMI20_FIFO_EN, >> > > + REG_ANA_HDMI20_FIFO_EN); >> > > +} >> > > + >> > > +static void >> > > +mtk_mt8195_phy_tmds_high_bit_clk_ratio(struct mtk_hdmi_phy >> > > *hdmi_phy, >> > > + bool enable) >> > > +{ >> > > + mtk_hdmi_ana_fifo_en(hdmi_phy); >> > > + >> > > + /* HDMI 2.0 specification, 3.4Gbps <= TMDS Bit Rate <= 6G, >> > > + * clock bit ratio 1:40, under 3.4Gbps, clock bit ratio 1:10 >> > > + */ >> > > + if (enable) >> > > + mtk_hdmi_phy_mask(hdmi_phy, HDMI20_CLK_CFG, >> > > + 0x2 << REG_TXC_DIV_SHIFT, >> > >> > Use FIELD_PREP() macro, then no need define REG_TXC_DIV_SHIFT >> > anymore. >> > >> >> Didn't know about FIELD_* macros, will use them for V2. >> >> Thx for the suggestion. >Please use helpers defined in phy-mtk-io.h, the register access helpers >of mtk_hdmi_phy_* are already removed in phy next branch. > >Thanks a lot > > Hi, Thank you for the headsup, I've seen the change landed in next-20220927 on which I'm currently rebasing. Thx, Guillaume. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel