From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3623C433FE for ; Mon, 3 Oct 2022 15:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date: MIME-Version:In-Reply-To:References:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Bn6JZx0o+PTzlySE6W93BG/NgQcsLYcUXVBsNqYjx84=; b=06B0WdZBtAzkrB4ZGek2dDHWBY g7ZaO/TlCP4uoNXWt73YZGqkMP0EITMvM8ZxIzJ3jTItGouY99HGu8oaxFbZYWFmP6kroiJJMIzeb KiQb7B5MUUTSD6qySicVlE6ZWoxrNa39NrEPoCyyllokv6jzBqPUn7ARBR0VjOqNhaRvwJgqYQRUl Tx/MxyNxOie9fVnb1ThXj0dn786SjQ3lrFiOeRiAYJb+M+DwY81wl6/6+ckTaT0kbdkQrOqsLLlRb Wu1w4W3DDBpUJrzOCFJTwXhhVk1i0aV+DMrJGFE3KadoDR6tOysHwgvN+b5GABCstzrwlPLg4JLkl eps3pMag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNXZ-006W3e-IP; Mon, 03 Oct 2022 15:39:33 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofNXV-006VzQ-Bb for linux-arm-kernel@lists.infradead.org; Mon, 03 Oct 2022 15:39:31 +0000 Received: by mail-pj1-x102f.google.com with SMTP id x32-20020a17090a38a300b00209dced49cfso7717089pjb.0 for ; Mon, 03 Oct 2022 08:39:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:from:to:cc:subject:date; bh=sBjMELHhs7ootP+M1ePzkemYasHrxvoQKWyxZ5SKdJc=; b=6TeHRYpKr4iA6ltAvmCjUEoPS1XHVEd06IoCPr9cBmfj4KcCCpxO4crfMKOV3j+ttD nSeOZOMohexUm4wDctC02d16DMakiBRtjI4eW7FpPc2+VsURaV8CZmi/Rv50Ju0O6bDZ mdJ6TzLmnXN/GWGyzbrtYytsMwPzUJ4T13JD1nY6dCnb/sWc4wLvd3XZoRV5ZBtrJSXZ NYuEIairpytFb3UeLbZhZryD3bGVjUZEKacG8YLZDJT1Z/e2blxmqYGhx6Od824QDPR1 oAdtoO8RRJNF37qDOUwsRz2nYEHUq2YFqJ+davPWQhI4GkSOm08p1XzZO+oufH7CzHlN JmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:in-reply-to:references :user-agent:from:x-gm-message-state:from:to:cc:subject:date; bh=sBjMELHhs7ootP+M1ePzkemYasHrxvoQKWyxZ5SKdJc=; b=wVaNuPQ3ZVa7jUmJu+M2oCJaZObtq/EJbEERZve/him0cqWe79fshHiPPiHSDzV6Hs VunEaI2pr6G4YgUXOy1CpR43Wx+QQlz2GH5UYc8Kbv4R8Sjpbp3WwTqxVLaXeDdURU03 uRuffekTOMiKLAq089RmrpNU/vfNgZ8Aapfi8utvELWoSr3YlpaDMD7jUAZe8Eqd8J+Y r6Pj5wcC12UgelGwdBdPdAXIStxl+6XxDS7tDyZNoyIvplqQe+A3ilU0PiSSSg9MB7I0 Y2WVS+XIAufvy2Xeg2xRuDgGwMq2reuVcxc93qb14lE4jCasB0oDGAwtpbNmyFh5Xa8H BW8A== X-Gm-Message-State: ACrzQf284koDVF0O1x4WjnY0BX2CXJhegF6Akj1ver/qdT8v+97VOQ79 9JHl8cUX4tMxHustN5gsxhQy09hb2Ga6lq8ge9fGQQ== X-Google-Smtp-Source: AMsMyM67n5/JfkI+ezU4sEpOAQkHL4Lr8SNXTP6tBMjqPf4oPEqHcs7Y4we6Zo0o6qrkQaDBeTf58h4qBuFfOWQ+eNE= X-Received: by 2002:a17:90b:2643:b0:205:bd0d:bdff with SMTP id pa3-20020a17090b264300b00205bd0dbdffmr12433645pjb.99.1664811565787; Mon, 03 Oct 2022 08:39:25 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 3 Oct 2022 17:39:25 +0200 From: Guillaume Ranquet User-Agent: meli 0.7.2 References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-9-4844816c9808@baylibre.com> <5920ba96-886c-1195-656a-a98d7b1f6623@collabora.com> In-Reply-To: <5920ba96-886c-1195-656a-a98d7b1f6623@collabora.com> MIME-Version: 1.0 Date: Mon, 3 Oct 2022 17:39:25 +0200 Message-ID: Subject: Re: [PATCH v1 09/17] drm/mediatek: hdmi: add connector flag To: AngeloGioacchino Del Regno , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu , Michael Turquette , Kishon Vijay Abraham I Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221003_083929_445903_4CCF8C34 X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Sep 2022 12:38, AngeloGioacchino Del Regno wrote: >Il 19/09/22 18:56, Guillaume Ranquet ha scritto: >> Add a flag to indicate support for an external connector >> >> Signed-off-by: Guillaume Ranquet >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> index 86653ebaacfd..30407603d693 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c >> @@ -199,20 +199,22 @@ int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, struct platform_device *pdev, >> goto put_device; >> } >> >> - remote = of_graph_get_remote_node(np, 1, 0); >> - if (!remote) { >> - ret = -EINVAL; >> - goto put_device; >> - } >> - >> - if (!of_device_is_compatible(remote, "hdmi-connector")) { >> - hdmi->next_bridge = of_drm_find_bridge(remote); >> - if (!hdmi->next_bridge) { >> - dev_err(dev, "Waiting for external bridge\n"); >> - of_node_put(remote); >> - ret = -EPROBE_DEFER; >> + if (hdmi->conf->has_connector) { > >If MT8195's DPI uses the internal HDMI->DP converter, I say that the external >DP has HDMI input and DP output. >Logically, you can't have a HDMI port that's connected to nothing. > >Please, rethink this change. > >Regards, >Angelo Hi Angelo, Sorry for the late answer. I have reworked this for V2, to use an hdmi connector device node to "bind" both the hdmi and hdmi-ddc driver together as with "legacy" code. So this patch is dropped in V2 (hopefully ready soon). Just to make things clear, the hardware path on mt8195 is: DPI1 -> HDMI Tx -> HDMI Phy DP Intf1 -> DP Tx -> USB Type C Mux -> DP over USB-C So there's no HDMI->DP converter involved. Thx, Guillaume. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel