From: Breno Matheus Lima <brenomatheus@gmail.com>
To: Jun Li <jun.li@nxp.com>
Cc: Breno Matheus Lima <breno.lima@nxp.com>,
"peter.chen@kernel.org" <peter.chen@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
Date: Fri, 11 Jun 2021 10:57:59 -0400 [thread overview]
Message-ID: <CAC4tdFUBGUiX4ydq4VeJcEXqmx6f2fvu4cq1ETw5mtueADz6yw@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB59358BDBE0A6FA8A8966C66789349@VI1PR04MB5935.eurprd04.prod.outlook.com>
Hi Jun,
Em sex., 11 de jun. de 2021 às 02:24, Jun Li <jun.li@nxp.com> escreveu:
>
>
> > -----Original Message-----
> > From: Breno Matheus Lima <breno.lima@nxp.com>
> > Sent: Friday, June 11, 2021 9:48 AM
> > To: peter.chen@kernel.org
> > Cc: gregkh@linuxfoundation.org; shawnguo@kernel.org;
> > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> > dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > brenomatheus@gmail.com; Jun Li <jun.li@nxp.com>; Breno Matheus Lima
> > <breno.lima@nxp.com>
> > Subject: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
> >
> > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not
> > following CDP timing requirements defined by USB BC 1.2 specification and
> > section 3.2.4 Detection Timing CDP.
> >
> > During Primary Detection the i.MX device should turn on VDP_SRC and IDM_SINK
> > for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON, the PD is
> > allowed to check the status of the D- line. Current implementation is waiting
> > between 1ms and 2ms, and certain BC 1.2 complaint USB HUBs cannot be detected.
> > Increase delay to 40ms allowing enough time for primary detection.
> >
> > During secondary detection the PD is required to disable VDP_SRC and IDM_SNK,
> > and enable VDM_SRC and IDP_SINK for at least 40ms (TVDMSRC_ON).
> >
> > Current implementation is not disabling VDP_SRC and IDM_SNK, introduce
> > disable sequence in imx7d_charger_secondary_detection() function.
> >
> > VDM_SRC and IDP_SINK should be enabled for at least 40ms (TVDMSRC_ON).
> > Increase delay allowing enough time for detection.
> >
>
> Fixes: 746f316b753a ("usb: chipidea: introduce imx7d USB charger detection")
>
Thanks for pointing this out, I have just sent another version.
Best regards,
Breno Lima
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-06-11 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 1:47 [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection Breno Lima
2021-06-11 6:24 ` Jun Li
2021-06-11 14:57 ` Breno Matheus Lima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC4tdFUBGUiX4ydq4VeJcEXqmx6f2fvu4cq1ETw5mtueADz6yw@mail.gmail.com \
--to=brenomatheus@gmail.com \
--cc=breno.lima@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).