From: tarun.kanti@ti.com (DebBarma, Tarun Kanti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver
Date: Fri, 16 Sep 2011 15:00:18 +0530 [thread overview]
Message-ID: <CAC83ZvKXEb7MTujP4JqhrPeysYxQcLF+BV-J9tpYoRwWGVZ8_Q@mail.gmail.com> (raw)
In-Reply-To: <CAC83ZvKGoucZ=xQSa7GEk7Gg8jcFBQE==1a6m4=+nzDRrsw+jw@mail.gmail.com>
[...]
>>> 1. Modify the inline access functions to take the PEND and others
>>> ? ?if needed registers as a parameter
>>>
>>> 2. Modify mach-omap2/timer.c to initialize the PEND and others
>>> ? ?in the SoC specific timer_init function
Just to make my understanding complete, need some clarifications:
As we would end up modifying almost all inline functions, what naming
convention should we follow for the parameters? For instance, PEND
is related to TWPS register. So are you suggesting using parameter
names related to respective registers in each inline functions?
If that is the case we would end up declaring lot of local variables along
with PEND. Instead, we could very well have just two variables to
represent functional and interrupt offsets.
Also, in plat-omap/dmtimer.c, timer_regs{} stores the register values and
not the register offsets. Therefore, we would not be able to pass as
parameters, timer->context.<x> ... etc.
Please let me know if I am off-track in my understanding.
Thanks.
--
Tarun
[...]
next prev parent reply other threads:[~2011-09-16 9:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 21:08 [PATCH v15 00/12] OMAP: dmtimer: adaptation to platform_driver Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 01/12] OMAP2+: dmtimer: add device names to flck nodes Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 02/12] OMAP4: hwmod data: add dmtimer version information Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 03/12] OMAP1: dmtimer: conversion to platform devices Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 04/12] OMAP2+: dmtimer: convert " Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 05/12] OMAP: dmtimer: platform driver Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver Tarun Kanti DebBarma
2011-09-14 21:45 ` Tony Lindgren
2011-09-14 22:24 ` Tony Lindgren
2011-09-15 5:42 ` DebBarma, Tarun Kanti
2011-09-15 8:46 ` Mohammed, Afzal
2011-09-15 16:58 ` Tony Lindgren
2011-09-15 17:05 ` Tony Lindgren
2011-09-16 3:54 ` DebBarma, Tarun Kanti
2011-09-16 9:30 ` DebBarma, Tarun Kanti [this message]
2011-09-17 1:35 ` [PATCH] ARM: OMAP: Add support for dmtimer v2 ip (Re: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver) Tony Lindgren
2011-09-18 12:27 ` DebBarma, Tarun Kanti
2011-09-19 17:43 ` Tony Lindgren
2011-09-19 4:06 ` Pedanekar, Hemant
2011-09-19 17:40 ` Tony Lindgren
2011-09-19 23:41 ` Pedanekar, Hemant
2011-09-19 5:22 ` Mohammed, Afzal
2011-09-19 17:43 ` Tony Lindgren
2011-09-08 21:08 ` [PATCH v15 07/12] OMAP: dmtimer: pm_runtime support Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 08/12] OMAP: dmtimer: add timeout to low-level routines Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 09/12] OMAP: dmtimer: mark clocksource and clockevent timers reserved Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 10/12] OMAP: dmtimer: low-power mode support Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 11/12] OMAP: dmtimer: extend spinlock to exported APIs Tarun Kanti DebBarma
2011-09-13 23:15 ` Tony Lindgren
2011-09-14 4:58 ` DebBarma, Tarun Kanti
2011-09-08 21:08 ` [PATCH v15 12/12] OMAP: dmtimer: add error handling to export APIs Tarun Kanti DebBarma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC83ZvKXEb7MTujP4JqhrPeysYxQcLF+BV-J9tpYoRwWGVZ8_Q@mail.gmail.com \
--to=tarun.kanti@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).