From: Fei Shao <fshao@chromium.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: lee.jones@linaro.org, Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, gene_chen@richtek.com,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com
Subject: Re: [PATCH v8 04/10] mfd: mt6360: Combine mt6360 pmic/ldo resources into mt6360 regulator resources
Date: Wed, 9 Jun 2021 17:48:21 +0800 [thread overview]
Message-ID: <CAC=S1njg1PUAkz+TvbtPPxm4uDb3xDSA5HmOOgjwrLz01vFzHw@mail.gmail.com> (raw)
In-Reply-To: <20210517173314.140912-5-gene.chen.richtek@gmail.com>
On Tue, May 18, 2021 at 1:34 AM Gene Chen <gene.chen.richtek@gmail.com> wrote:
>
> From: Gene Chen <gene_chen@richtek.com>
>
> Combine mt6360 pmic/ldo resources into mt6360 regulator resources
> to simplify the similar resources object.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/mt6360-core.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 512480f7bd40..3553c7045829 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -266,7 +266,7 @@ static const struct resource mt6360_led_resources[] = {
> DEFINE_RES_IRQ_NAMED(MT6360_FLED1_STRB_TO_EVT, "fled1_strb_to_evt"),
> };
>
> -static const struct resource mt6360_pmic_resources[] = {
> +static const struct resource mt6360_regulator_resources[] = {
> DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_PGB_EVT, "buck1_pgb_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OC_EVT, "buck1_oc_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OV_EVT, "buck1_ov_evt"),
> @@ -279,9 +279,6 @@ static const struct resource mt6360_pmic_resources[] = {
> DEFINE_RES_IRQ_NAMED(MT6360_LDO7_OC_EVT, "ldo7_oc_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_LDO6_PGB_EVT, "ldo6_pgb_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_LDO7_PGB_EVT, "ldo7_pgb_evt"),
Nit: sort MT6360_LDO*_OC_EVT and MT6360_LDO*_PGB_EVT after combining
the resources.
>
> -};
> -
> -static const struct resource mt6360_ldo_resources[] = {
> DEFINE_RES_IRQ_NAMED(MT6360_LDO1_OC_EVT, "ldo1_oc_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_LDO2_OC_EVT, "ldo2_oc_evt"),
> DEFINE_RES_IRQ_NAMED(MT6360_LDO3_OC_EVT, "ldo3_oc_evt"),
> @@ -299,10 +296,7 @@ static const struct mfd_cell mt6360_devs[] = {
> NULL, 0, 0, "mediatek,mt6360-chg"),
> MFD_CELL_OF("mt6360-led", mt6360_led_resources,
> NULL, 0, 0, "mediatek,mt6360-led"),
> - MFD_CELL_OF("mt6360-pmic", mt6360_pmic_resources,
> - NULL, 0, 0, "mediatek,mt6360-pmic"),
> - MFD_CELL_OF("mt6360-ldo", mt6360_ldo_resources,
> - NULL, 0, 0, "mediatek,mt6360-ldo"),
> + MFD_CELL_RES("mt6360-regulator", mt6360_regulator_resources),
> MFD_CELL_OF("mt6360-tcpc", NULL,
> NULL, 0, 0, "mediatek,mt6360-tcpc"),
> };
> --
> 2.25.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-09 10:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:33 [PATCH v8 0/10] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2021-05-17 17:33 ` [PATCH v8 01/10] mfd: mt6360: Rearrange include file Gene Chen
2021-05-17 17:33 ` [PATCH v8 02/10] mfd: mt6360: Remove redundant brackets around raw numbers Gene Chen
2021-05-17 17:33 ` [PATCH v8 03/10] mfd: mt6360: Indicate sub-dev compatible name by using "-" Gene Chen
2021-05-17 17:33 ` [PATCH v8 04/10] mfd: mt6360: Combine mt6360 pmic/ldo resources into mt6360 regulator resources Gene Chen
2021-06-09 9:48 ` Fei Shao [this message]
2021-05-17 17:33 ` [PATCH v8 05/10] mfd: mt6360: Rename mt6360_pmu_data by mt6360_ddata Gene Chen
2021-05-17 17:33 ` [PATCH v8 06/10] mfd: mt6360: Rename mt6360_pmu by mt6360 Gene Chen
2021-05-17 17:33 ` [PATCH v8 07/10] mfd: mt6360: Remove handle_post_irq callback function Gene Chen
2021-05-17 17:33 ` [PATCH v8 08/10] mfd: mt6360: Fix flow which is used to check ic exist Gene Chen
2021-06-09 10:02 ` Fei Shao
2021-06-09 10:21 ` Fei Shao
2021-05-17 17:33 ` [PATCH v8 09/10] mfd: mt6360: Merge header file into driver and remove unuse register define Gene Chen
2021-05-17 17:33 ` [PATCH v8 10/10] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2021-05-19 14:56 ` [PATCH v8 0/10] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC=S1njg1PUAkz+TvbtPPxm4uDb3xDSA5HmOOgjwrLz01vFzHw@mail.gmail.com' \
--to=fshao@chromium.org \
--cc=Wilma.Wu@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).