From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB95CC10F14 for ; Thu, 10 Oct 2019 05:28:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77E04218DE for ; Thu, 10 Oct 2019 05:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zy7iqTyD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="mgx7nbir" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77E04218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ALWImHhf82u+9BuwYarEt/mcoZkjQXdwDuJInMvlsLY=; b=Zy7iqTyDwymeSD DcQkri0jSt1V/FCHgcWyIKSYo7yobpxCXuzLMcGRrPJ60296Zt0OXx6u0oxfcSfLisiGJ5sl9K9XW mqrGKRl6gWqkl7RIRweslPVOCt5Mlmn8sNY0DcmeVH+E2WZH32I9vU0s0ZtCv9xeM7rYv2uUYF5D2 HBL33LtYSgrdPyi3/4ZgTdzObDe0VbYsrQ1TFhb0ZvRAIiLJQMd7ToipnmPoHRTXr3GbT9gEPBna0 rxZTOBLiJGC7N5KOnkZA31KgYq3st0bSxQE/ROugDNiJSlofU8KNAwhydrSbZMb2ekwua+u/J+4AU bftSz4pkb+BcfjkW3qJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIR0I-0004Tg-1o; Thu, 10 Oct 2019 05:28:46 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIR0E-0004TE-J7 for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2019 05:28:44 +0000 Received: by mail-qk1-x741.google.com with SMTP id y144so4485430qkb.7 for ; Wed, 09 Oct 2019 22:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r6Hep4iY8u0yDM4dyep+02jvirG1WxfZPi0UCSgzEPA=; b=mgx7nbirD+B+qWsSDYrOWzbCFx0K9ERikuPVhs/EhHAJrKz+tDqgfmUgXGWGRSBrbo UryoiU6AXZ6g1zlqeWA+/eHChgkS7xn/ksIRDyTXhZHZZI91skLOoYs5Y6Z3ls60l2+j NN8svFecFJkunpLR7aajvO1GIMk04+rGWimLs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r6Hep4iY8u0yDM4dyep+02jvirG1WxfZPi0UCSgzEPA=; b=bSM0LW0jYGjfLvCZU0k3Zo0xV52QLZMyOHwuQahemRbAwR2CL5V3+LP0qsCRpjJUB3 iGrvHMfB50fyKFgDfOic6dTttnlaNfnCTITrMDXe8TvHoJqY8GBUYDc9TPNz1fgV/aCs PeHALhy4XJ7FQ15cewBiQIB4uNyO+mXkRpD8SkpZ+n+Kx42VRpRuoUb43oO+KvfWKaij P/Xss01IDRenIV8Yw2K8c8t3YZ5580G+DXw/n4oJ5ggHApg6oE+Ylo1b+GeVZf3dIU5/ 8kHEzl+4e9bbaHOuoFJjKJVJ54CEUwQBkEprJpaxmUya4jFKvFyTEdLPI5HG3ObbIt1h Nerw== X-Gm-Message-State: APjAAAUAsmqvf6NEX37QENIfR36FsWuJ+dA8Bz5ZbVsgz040rDygbFYt 0xVHXgrQOsY+rHZ9BVGM5iwr7FYHFVDvZnjQ7Iw= X-Google-Smtp-Source: APXvYqwH0HMFFELFCxD2oINqI+YV0TL764wqxPt4fBPtvmrISd7LnBC85T0wCOC+E1zA48qshusCVPt0cVV1W/T+8QY= X-Received: by 2002:a37:4dca:: with SMTP id a193mr7795691qkb.292.1570685318745; Wed, 09 Oct 2019 22:28:38 -0700 (PDT) MIME-Version: 1.0 References: <20191007231313.4700-1-jae.hyun.yoo@linux.intel.com> <20191007231313.4700-4-jae.hyun.yoo@linux.intel.com> <20191008203157.GA184092@google.com> In-Reply-To: From: Joel Stanley Date: Thu, 10 Oct 2019 05:28:26 +0000 Message-ID: Subject: Re: [PATCH 3/5] i2c: aspeed: fix master pending state handling To: Brendan Higgins X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191009_222842_786912_4713315D X-CRM114-Status: GOOD ( 17.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Jae Hyun Yoo , linux-aspeed , Wolfram Sang , Andrew Jeffery , Benjamin Herrenschmidt , OpenBMC Maillist , Rob Herring , linux-i2c@vger.kernel.org, Tao Ren , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 8 Oct 2019 at 21:54, Brendan Higgins wrote: > > On Tue, Oct 8, 2019 at 2:13 PM Jae Hyun Yoo > wrote: > > > > On 10/8/2019 1:31 PM, Brendan Higgins wrote: > > > On Mon, Oct 07, 2019 at 04:13:11PM -0700, Jae Hyun Yoo wrote: > > >> In case of master pending state, it should not trigger the master > > >> command because this H/W is sharing the same data buffer for slave > > >> and master operations, so this commit fixes the issue with making > > >> the master command triggering happen when the state goes to active > > >> state. > > > > > > nit: Makes sense, but can you explain what might happen without your > > > change? > > > > If we don't use this fix, a master command could corrupt data in the > > shared buffer if H/W is still on processing slave operation at the > > timing. > > Right, can you add that to the commit message? > > Is this trivially reproducible? We might want to submit this > separately as a bugfix. > > Actually yeah, can you send this separately as a bugfix? I think we > might want to include this in 5.4. > > Wolfram and Joel, what do you think? Yes, good suggestion. A corruption fix should be merged I think. Always send bug fixes upstream with Fixes tags so they land in the stable tree. This is preferable to sending them separately to the openbmc for inclusion in that tree, and potentially reaches a wider audience. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel