From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E7E8C433E0 for ; Thu, 9 Jul 2020 06:53:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F150E2065D for ; Thu, 9 Jul 2020 06:53:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="wUoAGkvU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="HMkT8gZt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F150E2065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WZN0KpwWWBjWgFyeTnaMT/novtLe3egpj7dshLLiW6g=; b=wUoAGkvUDlUKR/qFuq2HbOQ7G BqsFc+y7sFbxE2mfdenFVbmQB6hj7Xudb+H3goXI5a2O7lYuLzmuyoQRo9Hp9NQAxXSkbjI/khjiC P78TGwsea1ybrc19eXjZYf7Lbn4Thu2vF2aLf44/j06pvUIA7rDuQZ8TpdIJFNMwPEBwmUscAEbwR OkLVwSMqeGjjQLNMG0ctCon5Cx67SMYIuRaPQeBRccwUJ+48c2fqh6pgw6jxGrU0N7o6BAGMNSqy0 FsuXas3AS9q9NQwDyd5CxNo4Kz+ycPPkR16o+a1mfWaKKKvkzSt9JwG5LDOzQ5aQug0+0gAKNJiaV raLoyvvEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQPd-0007Pd-16; Thu, 09 Jul 2020 06:52:05 +0000 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQPa-0007OU-F0 for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2020 06:52:03 +0000 Received: by mail-ej1-x643.google.com with SMTP id p20so1085264ejd.13 for ; Wed, 08 Jul 2020 23:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qC6ikPyAkkZDEb9ir5eEV2kSBTjyBB0hcPesB8iDBzU=; b=HMkT8gZtcPJUF8GcOk4mhQA0XzCuo24QFbpsy/EQ++/a9dyIEzXHW5pWoHG+rdOYsm xoxASy9VtzcGgvTPgxN+Wxa8/m7Axkq2Hi3BJ94g6Vl5qwmM3gKpwebpczBWGvJBlIRK rzMZrOsMRep1fyOEpevHPW43USm2kdy7jah/E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qC6ikPyAkkZDEb9ir5eEV2kSBTjyBB0hcPesB8iDBzU=; b=ZVFeWJ7DX6S1ZFr9s03Mae5nEC8lD0qMu5eJqenzcUDam3OjFOAGzDcd8VHa04qj8z qESZ1vGEzvMmSZ0D1hr6l0fWOzkmwLPZ9fltf/oWiy/4c4k/6aH+3E0QNtZ33Cih9jOt lY6OSFhMlH1+MeZOS7H4OWj/kVGS7eTooBr1kq7R9AHPGkDlMqPQEDqIpk+yPI9z7lEz FzBtUQR57noO2iyrggOIf9Hg20mPaB5QBL7DQyWx/W4Uu2Cak/xFtM2nqAJcYsySZrFb kLwHMZrPE7MwAw2kF/52cuWqiLhvmsiMezEmc6ibSRm51IMm1AQ+Yo50FZgoq9d4mg2L vh0Q== X-Gm-Message-State: AOAM531iLEs1B2bTaGW2DQl9PK61ayWJIr04NCFiGZA9J2ldeeotCwYt b6RClRwNEtWMe5EvxzStEzaUhYqbvk68WEDKKbM= X-Google-Smtp-Source: ABdhPJyk8qb4D04v5BrhicG+Xy3FGlw4wqFYNSQErh6C94HtP/sa7EmHdq4CIsCgiOB3EWMM+rqGoeThfN/1ns6BMRk= X-Received: by 2002:a17:906:1455:: with SMTP id q21mr38382187ejc.139.1594277518385; Wed, 08 Jul 2020 23:51:58 -0700 (PDT) MIME-Version: 1.0 References: <20200701001002.74997-1-linux@roeck-us.net> <20200701091021.GA266726@ravnborg.org> In-Reply-To: <20200701091021.GA266726@ravnborg.org> From: Joel Stanley Date: Thu, 9 Jul 2020 06:51:46 +0000 Message-ID: Subject: Re: [PATCH] drm/aspeed: Call drm_fbdev_generic_setup after drm_dev_register To: Sam Ravnborg , David Airlie X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_025202_905703_ADBAC5EE X-CRM114-Status: GOOD ( 23.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , Andrew Jeffery , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, g@ravnborg.org, Linux ARM , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 1 Jul 2020 at 09:10, Sam Ravnborg wrote: > > Hi Guenter. > > On Tue, Jun 30, 2020 at 05:10:02PM -0700, Guenter Roeck wrote: > > The following backtrace is seen when running aspeed G5 kernels. > > > > WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_fb_helper.c:2233 drm_fbdev_generic_setup+0x138/0x198 > > aspeed_gfx 1e6e6000.display: Device has not been registered. > > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3 #1 > > Hardware name: Generic DT based system > > Backtrace: > > [<8010d6d0>] (dump_backtrace) from [<8010d9b8>] (show_stack+0x20/0x24) > > r7:00000009 r6:60000153 r5:00000000 r4:8119fa94 > > [<8010d998>] (show_stack) from [<80b8cb98>] (dump_stack+0xcc/0xec) > > [<80b8cacc>] (dump_stack) from [<80123ef0>] (__warn+0xd8/0xfc) > > r7:00000009 r6:80e62ed0 r5:00000000 r4:974c3ccc > > [<80123e18>] (__warn) from [<80123f98>] (warn_slowpath_fmt+0x84/0xc4) > > r9:00000009 r8:806a0140 r7:000008b9 r6:80e62ed0 r5:80e631f8 r4:974c2000 > > [<80123f18>] (warn_slowpath_fmt) from [<806a0140>] (drm_fbdev_generic_setup+0x138/0x198) > > r9:00000001 r8:9758fc10 r7:9758fc00 r6:00000000 r5:00000020 r4:9768a000 > > [<806a0008>] (drm_fbdev_generic_setup) from [<806d4558>] (aspeed_gfx_probe+0x204/0x32c) > > r7:9758fc00 r6:00000000 r5:00000000 r4:9768a000 > > [<806d4354>] (aspeed_gfx_probe) from [<806dfca0>] (platform_drv_probe+0x58/0xa8) > > > > Since commit 1aed9509b29a6 ("drm/fb-helper: Remove return value from > > drm_fbdev_generic_setup()"), drm_fbdev_generic_setup() must be called > > after drm_dev_register() to avoid the warning. Do that. > > > > Fixes: 1aed9509b29a6 ("drm/fb-helper: Remove return value from drm_fbdev_generic_setup()") > > Signed-off-by: Guenter Roeck > > I thought we had this fixed already - but could not find the patch. > Must have been another driver then. > > Acked-by: Sam Ravnborg > > I assume Joel Stanley will pick up this patch. I do not have the drm maintainer tools set up at the moment. Could one of the other maintainers put this in the drm-misc tree? Acked-by: Joel Stanley Cheers, Joel > > Sam > > > --- > > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > index 6b27242b9ee3..bca3fcff16ec 100644 > > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > > @@ -173,8 +173,6 @@ static int aspeed_gfx_load(struct drm_device *drm) > > > > drm_mode_config_reset(drm); > > > > - drm_fbdev_generic_setup(drm, 32); > > - > > return 0; > > } > > > > @@ -225,6 +223,7 @@ static int aspeed_gfx_probe(struct platform_device *pdev) > > if (ret) > > goto err_unload; > > > > + drm_fbdev_generic_setup(&priv->drm, 32); > > return 0; > > > > err_unload: > > -- > > 2.17.1 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel