From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CB6CC388F7 for ; Wed, 28 Oct 2020 04:29:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAA70207DE for ; Wed, 28 Oct 2020 04:29:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ab/cRDEr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="HM99HBk8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAA70207DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DMG3QL7UqyN+e0ku7ILs2IS/llAuzoaM0sHp39T0LbI=; b=ab/cRDErC2TmuPTtUt/kfnhma 868uMnSgvwYJ3OPnRWKhYmxQkcMub9hAALThXeAxE4jzxJ1H+8LDIampJiuLhRnf3LD4t/dG2a0h4 aDCiqarYt5XDtl4EbeWPTJwC7EtrVrpGApD5j50M9aMA2NvoGZa790GGsS3Aq/6/FqNtxBiU3Rr7b RmHC5+Lad5IQwLSKWmyb2/PM0HnAD+bd6/zavHL9d9nmKksUjpjZiUCFRL4cLr+y+t5iN7s2Lmi+J bjaxT+F6MXuet7jomHK9rahK9dBEUv5YWMYmmrwkcX2C+kotp2+UiW2BBKKpAyLJgh261QWwauFfg BLWgw1B0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXd42-0005AL-MI; Wed, 28 Oct 2020 04:27:58 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXd3z-00059e-B7 for linux-arm-kernel@lists.infradead.org; Wed, 28 Oct 2020 04:27:56 +0000 Received: by mail-qt1-x844.google.com with SMTP id h12so2748859qtu.1 for ; Tue, 27 Oct 2020 21:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ELimXLIjFFEyZU/ch1CMaoy2YuMN5MJVjff2er+s7NQ=; b=HM99HBk83YvD2YeS+eQsdX3b8HsDJPHH2RUbI86H++j7WB8wVMh0dqhupICJ4TmMd+ JHaTXnKkRz33Mz2ZhTVPwiICOg0FYj7XW93kWewABTZf9Fp5rOlUwYQ2/tV+lQGFTRtk v6z4LQ92auwCat4tQ5JI+JVoxqgPR9uiC5nbA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ELimXLIjFFEyZU/ch1CMaoy2YuMN5MJVjff2er+s7NQ=; b=SYNDu1SjB/5Ux6s1YVy4ucEF6Sm6+s+NBRznRi1LrnzxJvbVmXrd6aoFEsqLGc/+cH NmU5X+L8LrSpaNb5KPpjh/UL+n9dtgN4yoV5EL3jpoN11LlVRcR6Fii6Slox8pMRGQiD kI1YDtr41b+yaVDv1do/djfk/JP6Arevo4GEhTsibXcNEfGM2/PQEkVzDy+lubf5DnTL qdw08rTGtWsA28bKGtv1uPlZtP0GpVJMTaF7udFV0orsA8tVqC3nWYCXK9OPU82tYkyM 7qXJLs/vcCWNOn6da4RoW5wjejUvaJDqkqtRgx0THsyEvswbDKT9TNefp6gjfBH+vr0q IXxg== X-Gm-Message-State: AOAM533g8fye51LAtddHuds4yD6bZgmGl6yHbZxYrxjuCNcCCXSKEtLA T9DLMYzijbFPE7hFUbZhdSiW6hw6obyBdFtZAHny0GIp X-Google-Smtp-Source: ABdhPJw4sL0/a9JoSrIwywzd8l+q04n/V4qcoRQ1usL9+UKdAACMkTARtNb9rBqxdCnSCJBOQ/U2QBCJqcZJxGf9rjM= X-Received: by 2002:ac8:794f:: with SMTP id r15mr409042qtt.385.1603859268783; Tue, 27 Oct 2020 21:27:48 -0700 (PDT) MIME-Version: 1.0 References: <20201008015106.3198-1-billy_tsai@aspeedtech.com> <20201008015106.3198-3-billy_tsai@aspeedtech.com> In-Reply-To: From: Joel Stanley Date: Wed, 28 Oct 2020 04:27:36 +0000 Message-ID: Subject: Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting To: Billy Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201028_002755_541607_DFF67F9C X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , Linux Kernel Mailing List , Rob Herring , Jeremy Kerr , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 12 Oct 2020 at 05:25, Billy Tsai wrote: > > Hi Joel, > > On 2020/10/8, 11:49 AM, Joel Stanley wrote: > > On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > > > for sgpiom1 > > > > The code looks good Billy. > > > > Please split the change in two: device tree changes (arch/arm/dts) in > > one, and pinctrl in the second, as they go through different > > maintainers. > > > > If I split the change in two, the patch of dts will have a compiler error. > Because that the sgpiom1 node needs the pinctrl symbol "&pinctrl_sgpm2_default". The drivers/pinctrl/ changes should be split from the arch/arm/boot/dts/ changes. You should keep the arch/arm/boot/dts/ changes in the same patch. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel