From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809A4C49ED7 for ; Fri, 20 Sep 2019 05:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 542A72080F for ; Fri, 20 Sep 2019 05:51:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pGtse6aR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="NwUzUyXe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 542A72080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+c6puHzKFIdF9IJs8HnRq59DTGD/oZw1OrEfuuFz6p8=; b=pGtse6aRojg5K6 2xlXDRbc27EcIr+Y16RZzlUVLGMvLM0I2kMPXLHBEIAtjDTyw1DqfQVCCGAnwFrWYq5PyXOrjcXZ9 ZPdnTmBfIbwe04BSXZ5U3eljS7Pvvoo8wc5lIvRvduzLlt5U4GQe7qc5NgIGGRTs4ojDIPnV4MC6J rzHiSNL53N+cjsuISiJtFk32yGIfZKykd7DmoQWB+6r5oa8lCXXVyj2bobubO0cQ+Mr8FrQ6qtVlm K4UDuX2eLWrp188yK9QNrTzz1WM+cMhHqqBri6whcHUgHMyyAAwzvhI1opsNjnAcP/cwXJS+nCdFQ TdvL3cKzz/TIxiD9B6Yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBBpT-0007SB-G6; Fri, 20 Sep 2019 05:51:39 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBBpP-0007RV-W5 for linux-arm-kernel@lists.infradead.org; Fri, 20 Sep 2019 05:51:37 +0000 Received: by mail-qt1-x843.google.com with SMTP id o12so7378363qtf.3 for ; Thu, 19 Sep 2019 22:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NlvPOwDHP1C+DxH46ciGbIQ82Gp/fdmy+p/JFJtAVTI=; b=NwUzUyXe+el4peKjNQG4O79OvKdtXAG8r0J4SNnG7hpdxb5bj+ErhCHnYWmyZwpfrR yYzgALwnMwMJu8WsDBxH4j3WjHqbrCW/fchFpQkTd/gTlkJku2wHf4JyAWd8/MnooPSZ qdIovw70JerTxtUcOENkNn1/HzmKUPXpnvjVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NlvPOwDHP1C+DxH46ciGbIQ82Gp/fdmy+p/JFJtAVTI=; b=tLWP06wIuGBYgMHirXaStGnJcqe7PNQ7TOELaZm+NfQKkyHMx8TNPxp7rhSr78+rrQ 3HKQndk+PUvLoqfSreAo6yaJsEEglvgM1q/HHJORpP2BhhkDmA8kOipLjlNCpX8fEZ5r CejC4+TC9G6B9a0vmpGjvPztIAEpxS8Cn2dgMuMX2ewknjgvDhROUxq6q3xTK/nwPhvE 15upOoFEPmcXi+YpG5zn4LFrafN7zCOUShWGAF1hABuY/wYwWgoNklZbxsjTrSeCPiIW t2dvoGxUSYA/UgfyDxDrlsqjzC18Mgt7njKrv4T5sXFV7IdDrVZi6vA/FNlmwnfqVGhL kvAw== X-Gm-Message-State: APjAAAWUPk58YNrVE37D2Ax1IL46yLDgtaLevdy91/Fe65GV3qQXe1ZM KNpqWU8hCSd1FK4bfz+g+WC55MEDQamf6sWFRco= X-Google-Smtp-Source: APXvYqw8YKLoRzDRPZmO4NDOIYrRQ0VYcNB8pOGBy4Dn4po2+LJmGgZJC1+QZHzwPn1XmvwamosioDNR5Hr2A+ZYVOY= X-Received: by 2002:ac8:2e94:: with SMTP id h20mr1491513qta.234.1568958691283; Thu, 19 Sep 2019 22:51:31 -0700 (PDT) MIME-Version: 1.0 References: <20190919142654.1578823-1-arnd@arndb.de> In-Reply-To: <20190919142654.1578823-1-arnd@arndb.de> From: Joel Stanley Date: Fri, 20 Sep 2019 05:51:18 +0000 Message-ID: Subject: Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190919_225136_164891_D09C986F X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , linux-aspeed , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 19 Sep 2019 at 14:27, Arnd Bergmann wrote: > > Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K > (later ARM1136, ARM1176 and ARM11mpcore). > > ast2500 falls into the second categoy, being based on arm1176jzf-s. > This is enabled by default when using ARCH_MULTI_V6, so we should > not 'select CPU_V6'. > > Removing this will lead to more efficient use of atomic instructions. Wow, nice find. > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-aspeed/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig > index a293137f5814..163931a03136 100644 > --- a/arch/arm/mach-aspeed/Kconfig > +++ b/arch/arm/mach-aspeed/Kconfig > @@ -26,7 +26,6 @@ config MACH_ASPEED_G4 > config MACH_ASPEED_G5 > bool "Aspeed SoC 5th Generation" > depends on ARCH_MULTI_V6 > - select CPU_V6 > select PINCTRL_ASPEED_G5 if !CC_IS_CLANG I can't find any trees with !CC_IS_CLANG here. Is there a problem building our pinmux driver with Clang? I tested with this patch: --- a/arch/arm/mach-aspeed/Kconfig +++ b/arch/arm/mach-aspeed/Kconfig @@ -25,8 +25,8 @@ config MACH_ASPEED_G4 config MACH_ASPEED_G5 bool "Aspeed SoC 5th Generation" + # This implies ARMv6K which covers the ARM1176 depends on ARCH_MULTI_V6 - select CPU_V6 select PINCTRL_ASPEED_G5 select FTTMR010_TIMER help If you want to apply that as a fix for 5.4 I would be happy with that. Fixes: 8c2ed9bcfbeb ("arm: Add Aspeed machine") Reviewed-by: Joel Stanley Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel