From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4833FC4338F for ; Thu, 5 Aug 2021 01:39:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 003D961050 for ; Thu, 5 Aug 2021 01:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 003D961050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lTPovRK+XrMmG3adMVJ5b5qQVZtJtr42ZQXOaVyvSQI=; b=ti1soenY8mhTg8 hbDLS8S+IqNpvVZtAFv8E0HvLTnKJ0wbOwRXFkNy5zYoO83ivqq8zkZkCIxsFaVIJ735UAxleMhDA ZiXG/IFd8aLdwJ2ZGsmVWzjvFN652WWxylD8rYQB05n3tcP+fJ5zwagLvwYa1edjSeLTKz0WgrIG6 r5e50rv+HyrOego3zqfNjBPpB74nnlz4Z5jd/HuR+TdltkbnN303FL5XTF4gXJq2v+dd8I9iqn8H+ ADS9mwSEDAoyjXdjZCmhFH0BC7xYQJVPOL+wZz7EO3Ilb/JT6ihYwVO8ApmNFAneUZJTSsnMAxtF6 y194GSlCB4blQFaOoCWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSKQ-007pKG-GO; Thu, 05 Aug 2021 01:37:46 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSKM-007pJ6-70 for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 01:37:44 +0000 Received: by mail-qt1-x82a.google.com with SMTP id k13so2792116qth.10 for ; Wed, 04 Aug 2021 18:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CrUoo33QzEJCzngHbzWb8s99OZ12IEF2BT6Mt/7njNs=; b=AZMTagmVx5eejByIyQys2K/49jkyGBhQzkLw/QFB6IgxGy60S7upUAzkbgW6FEtYKy Cyq/Qlkpswvq++QE9aqwpXfmhBWkHDE+BpH5YudP4jfe2LGZYxC0LCLWoKuNCmF6nndn +vf2lReDlCNnTQXnKBSbpRbbP974F1vDQwCaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CrUoo33QzEJCzngHbzWb8s99OZ12IEF2BT6Mt/7njNs=; b=sW20xtCyFXRJmutImDYk5G2grshKbNmy9DAIlMPRilpASN+az5dDhBfuG9G+bR4u39 cAiVK65nvH6wKZYJPTdY/eS0AGmhigWwDUIS64AptV17BAuyDzqZloU1tiV7fSHsoUi1 wtvdJF1QqUmqOne1FFuf0dka3rd6Akp76kldxGZvdYLwvTE/w9P9EOmMt/nYUQgIF8jV 7nugSmUiRLdebxJmBHF7dbDUhzyOYVHVBmpFf67HDhXl9waK4eO9Jr2UMFo3GVvp2Hah r6JzVZXvyMXe6PF2rDmN7LlgxfCUmL2bsyNNBQEyHzPyBRESZ52Et9PAjHKGcH3/jrWj rH9w== X-Gm-Message-State: AOAM531zn5FaNrMLDHIaYgohtO+ei6OmgwUhxM1AKiuWvPhc1sCLit5B hSF3u11SJyBLCXv4P02hiI+lugg5DYqr8X4aCXs= X-Google-Smtp-Source: ABdhPJzkNflBi0/hcQs0RygNLaYq4Ikw4O/RVE49w7ODSfujoVNMCs0z8N9Deen1yHKjIc+T8utXCWILRUPuESZlWKo= X-Received: by 2002:ac8:7454:: with SMTP id h20mr1967482qtr.263.1628127461174; Wed, 04 Aug 2021 18:37:41 -0700 (PDT) MIME-Version: 1.0 References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> In-Reply-To: <20210805011951.GA28444@taoren-ubuntu-R90MNF91> From: Joel Stanley Date: Thu, 5 Aug 2021 01:37:29 +0000 Message-ID: Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC To: Tao Ren Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_183742_450270_C147E3FE X-CRM114-Status: GOOD ( 37.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > On Thu, Aug 05, 2021 at 12:28:02AM +0000, Joel Stanley wrote: > > On Wed, 28 Jul 2021 at 23:38, wrote: > > > > > > From: Tao Ren > > > > > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. > > > > I like to read what kind of platform the BMC is going into if you can > > add that detail, but it's not essential. > > Sure. I will add more details in v2. > > > > +&spi1 { > > > + status = "okay"; > > > + > > > + /* > > > + * Customize spi1 flash memory size to 32MB (maximum flash size on > > > + * the bus) to save vmalloc space. > > > + */ > > > + reg = < 0x1e630000 0xc4 > > > + 0x30000000 0x2000000 >; > > > > Which driver supports this? > > > > It would be great to see Facebook work to get the SPI NOR driver for > > the ast2600 merged to mainline. > > > > I doubt the IBM team will get to this, as we are using eMMC instead. > > Ah, I just checked aspeed-g6.dtsi (ast2600-spi) in mainline and I thought > the driver patches were also upstreamed. Let me remove the entry for now, > and will add it back when the driver is ready. If it helps you, I don't mind it staying in your dts. I would like to see some effort on the driver though. > > > > > > + > > > + flash@0 { > > > + status = "okay"; > > > + m25p,fast-read; > > > + label = "spi1.0"; > > > + spi-max-frequency = <5000000>; > > > + > > > + partitions { > > > + compatible = "fixed-partitions"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + > > > + flash1@0 { > > > + reg = <0x0 0x2000000>; > > > + label = "system-flash"; > > > + }; > > > + }; > > > + }; > > > +}; > > > > > +&ehci1 { > > > + status = "okay"; > > > +}; > > > > Have you verified that USB works with mainline? I've had reports of it > > working on 5.8 but it seems to have regressed as of v5.10. > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > host controller initialization sequence"): ehci_handshake() returns > error because HCHalted bit EHCI24[12] stays at 1. > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > groups to see if anyone has more context. We discovered the same, except in my testing it wasn't actually "working" on my EVB. I have a A3 EVB on my desk and when plugging in a USB key nothing happened. > > Meanwhile, should I delete the entry until the fix is ready in driver? Again, leave it in I think. > > > > +&mdio1 { > > > + status = "okay"; > > > + > > > + ethphy3: ethernet-phy@13 { > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > + reg = <0x0d>; > > > + }; > > > +}; > > > + > > > +&mac3 { > > > + phy-handle = <ðphy3>; > > > > status = okay? > > > > You should specify the pinmux too I think, even if the default happens > > to work, so that other devices cannot claim the pins. > > status is set in ast2600 common dtsi, but let me set it here to avoid > confusion. Will update pinmux in v2. Thanks. Are you looking at mainline? I think it's disabled by default there: https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 > > > > > Cheers, > > > > Joel > > Cheers, > > Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel