From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7992CC48BE1 for ; Thu, 20 Jun 2019 08:29:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52F912085A for ; Thu, 20 Jun 2019 08:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LWFePH3d"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="CtuzE3Xr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52F912085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ed4oI3NcvsboN0PlsNMCdF5BypybWS9wNnjyoXfWGK0=; b=LWFePH3dGxyt8j ArXnogYrPIUZXeZ8/rUoIfeysUQ/6BZ3umo1PcRi9jS0h1UEiA6961Jtl/G0k5dk7BDTCMFQfZn2x oshGfWfNgPh9ULRB7ql6cXMnpbO382Oyfu+JzHlfdWFB69bIOw/L4cMuCtOZjrolEw1rpYy+meY4m THuoxqQd/AGOJmbniiEkURFuuhSt12p7nIOvnuR6q27DEUxAE6EPVGIaDUsJUxsE1ScZz3uYna8jx NwCtt7SSBJDpnahpe5sIxMIQpNgmxJyhkxxNwCvacSsCBW3eLFPrS++QFcXNegBIh/odcSvcVl+4D io7pE1Sm8WlzrveBW5OQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdsS8-00066G-Mr; Thu, 20 Jun 2019 08:29:52 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdsS6-00065w-4e for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 08:29:51 +0000 Received: by mail-qt1-x843.google.com with SMTP id p15so2395268qtl.3 for ; Thu, 20 Jun 2019 01:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6+LDECNzk7Ax81lY+NTXinI2CggAW7FJancdnXbish8=; b=CtuzE3XrAV1rVmsdqj11M6pmKHISAnlRUomi1TlE3HzkVaVNorKLX2wW/stFBg1Bv6 DyIHp3jITT2jE0rKVoCLPQ360+74LzXT6mmKu2+NrX5JQsoKH9lgwciuIWycQoNxySYe E/CSxBpptpTlZ//LZbwz0Wkz4IVdBnFrG+bkQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6+LDECNzk7Ax81lY+NTXinI2CggAW7FJancdnXbish8=; b=U1uaw8rPwD9E50HjPt9Ga0Fy6U+FzG0J62t0tnlC21D4BKvDQxzPzBp1rA7lfTk++z Z7UEPhORjIV4Lh30WENEVF8l/DY5JNjPkskfKL0MnZ4lULE3y6Dgb1GxTLikTnlOE1BL pdG7mNImOqsZnT64QN/L3xXzDsiGB8r8zwgdvxpXVZkYTbSZjPUEIFKJUR5DuDEQmzPj w2TUNJN+olPoosjGmokFJWzgOeGNsTJZUDjhQNhtoQzAJ069RcI+jOzC21JpHIgDi0q1 XhhuRC/6JxKLsYVouM4cL+zXqB9RxbBK9oBkn6BQD282HFUQ3QyQAZcktwwYTcw4NXiU BhsQ== X-Gm-Message-State: APjAAAWmEZ6iJr6Y9ud+8Mag+3a5l+eK6XNmhB1n/JvDA92jUgVGkniW 9l/AKedbuYvFofgdD/Chg68JhpQ7fg/ZfN4CYW0= X-Google-Smtp-Source: APXvYqz9ktCSXKcc8gJFwqeG+AN29q9x2gYJJMH1Lf+t9yZGIz77JKqmMdeqFF/zzNE+Y8nQBNbxTH4cVcRoubKl5l0= X-Received: by 2002:a0c:afd5:: with SMTP id t21mr38274708qvc.105.1561019389077; Thu, 20 Jun 2019 01:29:49 -0700 (PDT) MIME-Version: 1.0 References: <20190619125636.1109665-1-arnd@arndb.de> In-Reply-To: <20190619125636.1109665-1-arnd@arndb.de> From: Joel Stanley Date: Thu, 20 Jun 2019 08:29:36 +0000 Message-ID: Subject: Re: [PATCH] soc: aspeed: fix probe error handling To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_012950_183669_A969F33E X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery , Patrick Venture , Linux Kernel Mailing List , Vijay Khemka , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 19 Jun 2019 at 12:56, Arnd Bergmann wrote: > > gcc warns that a mising "flash" phandle node leads to undefined > behavior later: > > drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': > drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The device cannot work without this node, so just error out here. > > Signed-off-by: Arnd Bergmann Thanks Arnd. This looks like it applies on top of Vijay's recent patch? The intent of that change was to make the driver usable for systems that do not want to depend on the flash phandle. I think the fix we want looks like this: --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c @@ -224,10 +224,11 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) dev_err(dev, "Couldn't address to resource for flash\n"); return rc; } + + lpc_ctrl->pnor_size = resource_size(&resm); + lpc_ctrl->pnor_base = resm.start; } - lpc_ctrl->pnor_size = resource_size(&resm); - lpc_ctrl->pnor_base = resm.start; Vijay, do you agree? Cheers, Joel > --- > drivers/soc/aspeed/aspeed-lpc-ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > index 239520bb207e..81109d22af6a 100644 > --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c > +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > @@ -212,6 +212,7 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) > node = of_parse_phandle(dev->of_node, "flash", 0); > if (!node) { > dev_dbg(dev, "Didn't find host pnor flash node\n"); > + return -ENXIO; > } else { > rc = of_address_to_resource(node, 1, &resm); > of_node_put(node); > -- > 2.20.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel