From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD932C43381 for ; Wed, 27 Mar 2019 01:01:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98E682075D for ; Wed, 27 Mar 2019 01:01:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IMGW6cse"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="ek5Myra+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98E682075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MhlxSC5KI8T4BXteC1xXvMO532dHNcFHv/s/llmhXV8=; b=IMGW6cseTuTBYV pFtcRkyPngCatVs2Sj14ef2jyST+nZGRu2ZIDdPnbaNdpqy+mXbv649tpOn93Fgc3ru54TgHfgmRN 9jP5lnfRs95SnEAAETqUS3P/hmZx9fb/t/uf2ld8YcqStsGOZPFa0wWswYwMaBiWl+GgfAs59Dnas AYB5Cs0VdXRgA1HdgtnSVCQKcYL69mrqmqmhjWSjXl591f/aPPuM/ZnX2B4LA8izfRyVtbv6AhJ5n mMC/QiXNuopnTAfIsX/VcT71rVEkJe2XbNm3Z9I2Q//E/lTGNnGSir6ewZkq8ygsvJWvYBbzBKbF6 h5u342a+vskTAgWFM3uQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8wwb-0003mv-PJ; Wed, 27 Mar 2019 01:01:29 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8wwT-0003ln-Fq for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 01:01:25 +0000 Received: by mail-qt1-x843.google.com with SMTP id d13so12289197qth.5 for ; Tue, 26 Mar 2019 18:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4CYNiiTq27LSC7CmrQxd8C5l8JugQDNFvrmLLbjg0BY=; b=ek5Myra+P+7avo3KGo29GiTQrn9iTHcMPnbyyPrWWwMzcP/I7RLpiCy7DzInQ6Rgs3 jG2EAYlwlttbJ22hW5x2S07zMHSlbV/KzvLMsi0Q6AOIzklyCZRZzkjfoWdR7T/TSFC+ MyEA/Addi1grtOngu/6qLyafzuWLOIvU9haiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4CYNiiTq27LSC7CmrQxd8C5l8JugQDNFvrmLLbjg0BY=; b=SayYh7Rv7NEVNiPhQImWBaDc+iweEIXJlEfWFS/SLoed+woZolB0lTbnomnEksK4DP YMOGiwD6xxdHYWRS6+yvVD6MgM8ilE6En1hTwElMy8Zbhbyo7jx6Fse7AfsOMRUba9M3 CjMdsvjn8isw6GtGfht9eTlv5oU6ZnzkWF5xASIu2C24zsjQUU4kYx59mBhuEvXNaAFb Cxl3+Pu3OpXCBORcqSwZN0y8XKjyzEbSlVLuNvr+8Gv5N9Etb5NmbM/lxG6ipKGLyziI hwxTleQ/ytIIBc6J/rgYIOJxASGGzBzGgHK1zidboqddxIknu7SxY/edyMxSbpPToYSj qZ8w== X-Gm-Message-State: APjAAAVwPK/QS/tMYDpurt11nux+3AJIi1ylrITNQVlAraWg880jP9gx Ujbh+51YCjl0i86IRHJf3j+gl1yBR7hva8txT3s= X-Google-Smtp-Source: APXvYqxXr51L2F0+NOWbsTEL9c/otLHChqmS0PMLpIek6dAcDjLKD3idnT4OpFspsu55i9UkiR8ZvsBYPaQIs5shccY= X-Received: by 2002:ac8:26e7:: with SMTP id 36mr28781689qtp.37.1553648469211; Tue, 26 Mar 2019 18:01:09 -0700 (PDT) MIME-Version: 1.0 References: <20190325133159.10653-1-joel@jms.id.au> <20190325133159.10653-3-joel@jms.id.au> <20190325145954.GM30105@piout.net> <20190325161010.GP30105@piout.net> In-Reply-To: <20190325161010.GP30105@piout.net> From: Joel Stanley Date: Wed, 27 Mar 2019 01:00:56 +0000 Message-ID: Subject: Re: [PATCH v2 2/2] rtc: Add ASPEED RTC driver To: Alexandre Belloni X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_180121_530154_7607D490 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , linux-aspeed@lists.ozlabs.org, devicetree , Andrew Jeffery , Rob Herring , Linux ARM , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 25 Mar 2019 at 16:10, Alexandre Belloni wrote:> > > While doing that change, I relaized that the whole locking is probably > unnecessary as all the rtc_ops are called with the rtc lock taken. If > you are not planning to add alarm support, the lock can be removed. I had a stab at alarm support, but the select() tests in rtctest.c were failing. I will submit a v3 without the locking so we can get that out of the way, and defer adding alarm support for now. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel