From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9AFC2B9F7 for ; Mon, 24 May 2021 17:05:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E8BF61406 for ; Mon, 24 May 2021 17:05:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E8BF61406 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bSccfkJX34JLzKaYdORohzoTfpUzAzHBHl8w31LgfIE=; b=c2MId1kYR/9YIA cbxL5/kcVX0MYiaVK/NkZtYIve4AndAjdFPfzGCuoGl8hLkgggaftBg3Q99vko7ZI4Z96BrvBLvii 4448QrG43Mo2x8OU+IwqVgA42jbb7zdFpjYLUUe4cF2PWVVOBboKDXvtNJRCq+bgk+DRnTbho+6HA 8yRjP4CDR2R3tMALTibmA/HDlgDHipaKtehUPws/Ud6tZ7IUdu9/Tk7PMzqIChncEjcnRGtTvA6QZ t0u93HfkXveyuEIFmX4ikO5U2CJIeNm+9th3YNCTdQDRN5wXElMB4nr1NoyHHeWruD7R1rgcQLZXF 8sLYO+Zzx3BmM8eVDiMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llDz3-001Cps-Sy; Mon, 24 May 2021 17:03:19 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll0cU-000eh8-3U for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 02:47:07 +0000 Received: by mail-qk1-x729.google.com with SMTP id o27so25736633qkj.9 for ; Sun, 23 May 2021 19:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LTCPne6GXFzHJ7+D1ZybTqJ/Z3dDxDNGFw0CMhOL8Rs=; b=hJbVnkiQENoyNTPSSPUoPrfPxPtOvXlxrjv+JNfihflwvPlydj1kKxcWZqjemyfqmO aUt360h8r61lvw+Zdxp1bhhjHknphbjwgk0MApLTWrLxblAQ3iaCSU6c03qgSfRgqqEu K4bZ43EGBSo3lDh9tEol1tHLIGs86R4KvO6Kw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LTCPne6GXFzHJ7+D1ZybTqJ/Z3dDxDNGFw0CMhOL8Rs=; b=RDdY+MTeoZD31kx/FBDW/gy8LqkOzmHXNUOH4Ci99oCIUn7lGxEp5Ab7PJPS8KGSnl IHfxb7JygA/2HtAw7dQ+Mfe8sjozJZZ1n9Brb2VEv9RrybnTC84KP22jqrZiguLwn/SP v1bx6OKJ1YsfrMp8NvxYAcMiBHlhSebRAJf6AVIZ4dx3gD0bDMHVopScCnnecwK46Q7A UvC1dH5vfRoRPulr0chT5B2/eyooDRdvoYqLDFvUi/BA8EU86yrgpXw+X3Y0I3GXMLeh D3VeaN7H7bOJNlzV8z3lu4j/NzdQTL8T+Q4xgccntIok2rBmvxTiChfjRH+MK+2W8YzE SqWA== X-Gm-Message-State: AOAM533/g0n6CXrhwZpkA2k5ZAcMDuC0LuPRoBAWLxUk2i5SOmmTP7oE ycKnrIDByPAcMMfJHnk3Z6KD1QHLccRAjmsEIjU= X-Google-Smtp-Source: ABdhPJwKrT1nqV52738s0dioZLpz1C9s9WeGGGKgsxr3NpTELBPM2mW8vXf/ydUfZHgfvf1gZWCTf6zGN0VxHJFJ+no= X-Received: by 2002:a05:620a:12a4:: with SMTP id x4mr25587812qki.487.1621824425020; Sun, 23 May 2021 19:47:05 -0700 (PDT) MIME-Version: 1.0 References: <20210520101346.16772-1-steven_lee@aspeedtech.com> <20210520101346.16772-2-steven_lee@aspeedtech.com> <20210524023526.GA2727@aspeedtech.com> In-Reply-To: <20210524023526.GA2727@aspeedtech.com> From: Joel Stanley Date: Mon, 24 May 2021 02:46:52 +0000 Message-ID: Subject: Re: [PATCH v4 1/3] ARM: dts: aspeed: ast2600evb: Add sdhci node and gpio regulator for A2 evb. To: Steven Lee Cc: Ryan Chen , Rob Herring , Andrew Jeffery , Adrian Hunter , Ulf Hansson , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "moderated list:ASPEED SD/MMC DRIVER" , "open list:ASPEED SD/MMC DRIVER" , Hongwei Zhang , Chin-Ting Kuo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210523_194706_167261_6E8D7DEA X-CRM114-Status: GOOD ( 28.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 May 2021 at 02:35, Steven Lee wrote: > > The 05/21/2021 09:25, Joel Stanley wrote: > > Hi Steven, > > > > On Thu, 20 May 2021 at 10:16, Steven Lee wrote: > > > > > > AST2600 A2(or newer) EVB has gpio regulators for toggling signal voltage > > > between 3.3v and 1.8v, the patch adds sdhci node and gpio regulator in the > > > new dts file and adds commment for describing the reference design. > > > > spelling: comment > > > > Thanks, will correct the typo. > > > I need you to justify the separate dts for the A2 EVB. > > > > What would happen if this device tree was loaded on to an A1 or A0? > > > > Since the clock default value(SCU210) of A1 and A0 are different to A2, > the following error would happen if A2 device tree was loaded on A1/A0. > > ``` > [ 133.179825] mmc1: Reset 0x4 never completed. > [ 133.184599] mmc1: sdhci: ============ SDHCI REGISTER DUMP =========== > [ 133.191786] mmc1: sdhci: Sys addr: 0x00000000 | Version: 0x00000002 > [ 133.198972] mmc1: sdhci: Blk size: 0x00007008 | Blk cnt: 0x00000001 > [ 133.206158] mmc1: sdhci: Argument: 0x00000c00 | Trn mode: 0x00000013 > [ 133.213343] mmc1: sdhci: Present: 0x01f70001 | Host ctl: 0x00000011 > [ 133.220528] mmc1: sdhci: Power: 0x0000000f | Blk gap: 0x00000000 > [ 133.227713] mmc1: sdhci: Wake-up: 0x00000000 | Clock: 0x00008007 > [ 133.234898] mmc1: sdhci: Timeout: 0x0000000b | Int stat: 0x00000000 > [ 133.242083] mmc1: sdhci: Int enab: 0x00ff0083 | Sig enab: 0x00ff0083 > [ 133.249268] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000000 > [ 133.256453] mmc1: sdhci: Caps: 0x07f80080 | Caps_1: 0x00000007 > [ 133.263638] mmc1: sdhci: Cmd: 0x0000341a | Max curr: 0x001f0f08 > [ 133.270824] mmc1: sdhci: Resp[0]: 0x00000000 | Resp[1]: 0x01dd7f7f > [ 133.278009] mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00400e00 > [ 133.285193] mmc1: sdhci: Host ctl2: 0x00000000 > [ 133.290148] mmc1: sdhci: ADMA Err: 0x00000000 | ADMA Ptr: 0xbe041200 > [ 133.297332] mmc1: sdhci: ============================================ > > ``` > > Besides, A1/A0 EVBs don't have regulator, vmmc and vqmmc should be > removed from sdhci node of A1/A0 dts. > > > Would this device tree be used for the A3 (and any future revision?) > > > > Yes, A3 can use the A2 dts. > > > An alternative proposal: we modify the ast2600-evb.dts to support the > > A2 (which I assume would also support the A3). > > > > If we need a separate board file for the A0 and A1 EVB, we add a new > > one that supports these earlier revisions. Or we decide to only > > support the latest revision in mainline. > > > > In this patch, I add a new dts to support A2 sdhci, and include the > original dts since the other settings can be loaded on A2. > Do you mean creating a new file(e.g. aspeed-ast2600-evb-a1.dts) for A1, > and modifying the original aspeed-ast2600-evb.dts for supporting A2? Yes, that would be my suggestion. The aspeed-ast2600-evb-a1.dts could include the aspeed-ast2600-evb.dts. > If we decide to only support the latest version in mainline, users > should mark vmmc and vqmmc as comment and modify clk-phase manually > for supporting A1. If you believe there will be users of the A1 for some time, then I think it makes sense to support both A1 and future boards in mainline. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel