From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED30C433E2 for ; Wed, 22 Jul 2020 05:59:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCF1820771 for ; Wed, 22 Jul 2020 05:59:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PsFQuxkr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="XlgcqI4M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCF1820771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e2gg430+nEi73WWm0VWS2Ww2eWHtcJvPoYJcVj9sm7I=; b=PsFQuxkreRwLZ8pl5ns9doBex 4WzcRaJ+LO6vArnQmxyYLz/q09rsOWhKKMkzopytkSlt3IZIxH7dgoLwa0re54ZyYaof1dDWy3ji0 6IprufdGBvgQdhxfbn2e6ugz0VqqtQS5E21d7dE4M5+sRfCMnrbYSo+jXnO9Db1NkfZzqe3oQiH59 ua0JCq+wvsNwQrlT3w3942OXGH+erJT3VXMPMdTuT+SIH/mxV5YuKzul4DRfHohskyGLLLqT+z8Yg UL9LfltPUl6qiAp05aUU+vpIVQOK0mhVA8NWqSbldXmXJ/ZYIXRoOS6CQlQvR7mbOVoIX7SzrqkRO B6/zGaCPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy7lQ-0006R5-8O; Wed, 22 Jul 2020 05:58:00 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy7lM-0006QR-DD for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2020 05:57:57 +0000 Received: by mail-ed1-x541.google.com with SMTP id by13so703384edb.11 for ; Tue, 21 Jul 2020 22:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7HyvRxIrXJ94hpJJ10KYHhFfMdEOmHA2GHT0K+5iUXk=; b=XlgcqI4MvjemKHQVFDQvUzykkZRmP3lD/jG4aYdiM6hGOhyvXScttPI7hWy9rKRfuk 7J0QusowPX9dYB44LlAJBmavv5IOKWu71jWfGsTCuhQfavb8v/oc7Gq4CemDQBtbwA2A uio4InFKyFHp+HAVNkP3Xk0qQQOfYwlexvZpY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7HyvRxIrXJ94hpJJ10KYHhFfMdEOmHA2GHT0K+5iUXk=; b=JWJfZEDK97JjTIPPNxC7Pmz0tXla/AZj55KMlfTVMVidwK9QqffDdWOO/PBx0iyQ6l G47G462RV1OO8E6ApQLKLsWL369RIuqUbviC53I59ajq9hqrzeI/64dEEeTeo7KdkVNw 2bhYPc2gUVPNStyNv65tvOY/+Y6yft76f+meDWKJD0iK5UbEAHl+2lIjeCMPNIjJyKKl 8lE+kpVhe16qoI43qHPqQQzQ3x9AFRcflzgpeVIHs96fvwJcAj+9dNvgGP4Pfv+WEsac AJFq5mwjpJ1R/nK7djFsNThsxmM1RKoDVqh3QaJ1/+LXvuKH9mftKW6vI+YedcKa8hNy vSoA== X-Gm-Message-State: AOAM531/Eer9Gt6yyd2LKSiZF4qFY6Eo/AUpZnB3H50GMYtLZR79QXro lwg2N2w8VrWpcsU9qTaW0w9x4MdQJrtwqInvN2c= X-Google-Smtp-Source: ABdhPJyqwx7/7Ern/u8AfDOeaGdctpyl3n7V510LJKLg3E6NY/BORruzv1YBZDEOqkF3HbgrRGVMMg07hHLqxCPsRBY= X-Received: by 2002:a50:ee8a:: with SMTP id f10mr28623696edr.383.1595397473857; Tue, 21 Jul 2020 22:57:53 -0700 (PDT) MIME-Version: 1.0 References: <20200720160147.22339-1-supreeth.venkatesh@amd.com> In-Reply-To: <20200720160147.22339-1-supreeth.venkatesh@amd.com> From: Joel Stanley Date: Wed, 22 Jul 2020 05:57:41 +0000 Message-ID: Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD EthanolX To: Supreeth Venkatesh X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_015756_585252_2CA896FB X-CRM114-Status: GOOD ( 14.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 20 Jul 2020 at 16:02, Supreeth Venkatesh wrote: > > Initial introduction of AMD EthanolX platform equipped with an > Aspeed ast2500 BMC manufactured by AMD. > > AMD EthanolX platform is an AMD customer reference board with an > Aspeed ast2500 BMC manufactured by AMD. > This adds AMD EthanolX device tree file including the flash layout > used by EthanolX BMC machines. > > This also adds an entry of AMD EthanolX device tree file in Makefile. > > Signed-off-by: Supreeth Venkatesh Reviewed-by: Joel Stanley Looks good. One question about the licence. > +++ b/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts > @@ -0,0 +1,209 @@ > +// SPDX-License-Identifier: Apache-2.0 > +// Copyright (c) 2020 AMD Inc. Can you have a read of the licence rules and add a preferred licence. The rules are here: https://www.kernel.org/doc/html/latest/process/license-rules.html This very hacky one liner will give you an idea of common licences used by device trees: $ git grep -h SPDX -- arch/arm/boot/dts/ | cut -c3- |sort -b | uniq -c | sort -hr 579 SPDX-License-Identifier: GPL-2.0 305 SPDX-License-Identifier: GPL-2.0-only 222 SPDX-License-Identifier: GPL-2.0-or-later 188 SPDX-License-Identifier: (GPL-2.0+ OR MIT) 91 SPDX-License-Identifier: GPL-2.0+ 72 SPDX-License-Identifier: (GPL-2.0 OR MIT) 57 SPDX-License-Identifier: GPL-2.0+ OR MIT 46 SPDX-License-Identifier: GPL-2.0-or-later OR MIT 38 SPDX-License-Identifier: GPL-2.0 OR X11 29 SPDX-License-Identifier: GPL-2.0 OR MIT 19 SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) 16 SPDX-License-Identifier: GPL-2.0-only */ 6 SPDX-License-Identifier: ISC 5 SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) 4 SPDX-License-Identifier: (GPL-2.0+ OR X11) 4 SPDX-License-Identifier: (GPL-2.0 or MIT) 4 SPDX-License-Identifier: GPL-2.0 */ 3 SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) 2 SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause) */ 2 SPDX-License-Identifier: GPL-2.0-or-later */ 2 SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause 2 SPDX-License-Identifier: (GPL-2.0+) 2 SPDX-License-Identifier: (GPL-2.0) 2 SPDX-License-Identifier: GPL-2.0 1 SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ 1 SPDX-License-Identifier: GPL-2.0+ 1 SPDX-License-Identifier: GPL-2.0+ 1 SPDX-License-Identifier: BSD-3-Clause > +// Author: Supreeth Venkatesh > +/dts-v1/; > + > +#include "aspeed-g5.dtsi" > +#include > + > +/ { > + model = "AMD EthanolX BMC"; > + compatible = "amd,ethanolx-bmc", "aspeed,ast2500"; > + > + memory@80000000 { > + reg = <0x80000000 0x20000000>; > + }; > + aliases { > + serial0 = &uart1; > + serial4 = &uart5; > + }; > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200 earlyprintk"; > + }; > + leds { > + compatible = "gpio-leds"; > + > + fault { > + gpios = <&gpio ASPEED_GPIO(A, 2) GPIO_ACTIVE_LOW>; > + }; > + > + identify { > + gpios = <&gpio ASPEED_GPIO(A, 3) GPIO_ACTIVE_LOW>; > + }; > + }; > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>, <&adc 4>; > + }; > +}; > + > +&fmc { > + status = "okay"; > + flash@0 { > + status = "okay"; > + m25p,fast-read; > + #include "openbmc-flash-layout.dtsi" > + }; > +}; > + > + > +&mac0 { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_rmii1_default>; > + clocks = <&syscon ASPEED_CLK_GATE_MAC1CLK>, > + <&syscon ASPEED_CLK_MAC1RCLK>; > + clock-names = "MACCLK", "RCLK"; > +}; > + > +&uart1 { > + //Host Console > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_txd1_default > + &pinctrl_rxd1_default>; > +}; > + > +&uart5 { > + //BMC Console > + status = "okay"; > +}; > + > +&adc { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_adc0_default > + &pinctrl_adc1_default > + &pinctrl_adc2_default > + &pinctrl_adc3_default > + &pinctrl_adc4_default>; > +}; > + > +// Thermal Sensors > +&i2c7 { > + status = "okay"; > + > + lm75a@48 { > + compatible = "national,lm75a"; > + reg = <0x48>; > + }; > + > + lm75a@49 { > + compatible = "national,lm75a"; > + reg = <0x49>; > + }; > + > + lm75a@4a { > + compatible = "national,lm75a"; > + reg = <0x4a>; > + }; > + > + lm75a@4b { > + compatible = "national,lm75a"; > + reg = <0x4b>; > + }; > + > + lm75a@4c { > + compatible = "national,lm75a"; > + reg = <0x4c>; > + }; > + > + lm75a@4d { > + compatible = "national,lm75a"; > + reg = <0x4d>; > + }; > + > + lm75a@4e { > + compatible = "national,lm75a"; > + reg = <0x4e>; > + }; > + > + lm75a@4f { > + compatible = "national,lm75a"; > + reg = <0x4f>; > + }; > +}; > + > +&kcs1 { > + status = "okay"; > + kcs_addr = <0x60>; > +}; > + > +&kcs2 { > + status = "okay"; > + kcs_addr = <0x62>; > +}; > + > +&kcs4 { > + status = "okay"; > + kcs_addr = <0x97DE>; > +}; > + > +&lpc_snoop { > + status = "okay"; > + snoop-ports = <0x80>; > +}; > + > +&lpc_ctrl { > + //Enable lpc clock > + status = "okay"; > +}; > + > +&pwm_tacho { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0_default > + &pinctrl_pwm1_default > + &pinctrl_pwm2_default > + &pinctrl_pwm3_default > + &pinctrl_pwm4_default > + &pinctrl_pwm5_default > + &pinctrl_pwm6_default > + &pinctrl_pwm7_default>; > + > + fan@0 { > + reg = <0x00>; > + aspeed,fan-tach-ch = /bits/ 8 <0x00>; > + }; > + > + fan@1 { > + reg = <0x01>; > + aspeed,fan-tach-ch = /bits/ 8 <0x01>; > + }; > + > + fan@2 { > + reg = <0x02>; > + aspeed,fan-tach-ch = /bits/ 8 <0x02>; > + }; > + > + fan@3 { > + reg = <0x03>; > + aspeed,fan-tach-ch = /bits/ 8 <0x03>; > + }; > + > + fan@4 { > + reg = <0x04>; > + aspeed,fan-tach-ch = /bits/ 8 <0x04>; > + }; > + > + fan@5 { > + reg = <0x05>; > + aspeed,fan-tach-ch = /bits/ 8 <0x05>; > + }; > + > + fan@6 { > + reg = <0x06>; > + aspeed,fan-tach-ch = /bits/ 8 <0x06>; > + }; > + > + fan@7 { > + reg = <0x07>; > + aspeed,fan-tach-ch = /bits/ 8 <0x07>; > + }; > +}; > + > + > + > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel