From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24345C433FE for ; Mon, 6 Sep 2021 11:49:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0C6D60F14 for ; Mon, 6 Sep 2021 11:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0C6D60F14 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1sK1qOLFPkKdiieMMJ13Fnc7wx1FUhYkEi2oYWI2ZIY=; b=cCXxdTtl8HSg88 gputshynusdVZTTl4XqPmX4/lSEcHtaVDF/5TmXJVHwGaWPX3iPZaIdGkkfNUN0djEk6HF6Br9vN/ STqjFV7lLVnO1hn278Cg3ibAiXuCS2w7jcBFk8SCQUMBJAbIlfAIYgK1kAIwFBi5I/YqCxms04s2P fMuS8cH9z5p74Vr+xGIqk6yzHYlgXnVsGBJQVsUEIZdFPTcKY/5lfRT5t9t25xJUPQk+OK8SalVNp kVqx1ZQcygACke4Xf0GdA6BewllMG/RshIXKLJAicUPnqvKeY1ykl/5svCWVww41PYPmnc8o5QmOv 7u74WAwJ9nXCETG550TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mND64-000elh-Qi; Mon, 06 Sep 2021 11:47:33 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mND60-000ekV-Lc for linux-arm-kernel@lists.infradead.org; Mon, 06 Sep 2021 11:47:30 +0000 Received: by mail-qv1-xf35.google.com with SMTP id g11so3829256qvd.2 for ; Mon, 06 Sep 2021 04:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ydkSeattX7pqtmLuoMARpH6s/V85guG4/Y69kcyoKjI=; b=DP9qLeF/ReuP+/BRT604rMJmBYUser8C7kY0DRQwQSMF57xyB43PcaW+L7jArum/3z YfbhrnPDs2trWpYG8QQ0trqcIEOWSI+JAlaQtyo7TozwxxB8MpRiyvxwfgRfcH3D00K6 FW8SxuXScr8jrkSt8P469DkDgLJAojMkby6lg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ydkSeattX7pqtmLuoMARpH6s/V85guG4/Y69kcyoKjI=; b=jkgiM2MvbJ89A8bmXRgWgGZjwGWQZefdNADHNBpeEtLRlDOUkvVgKoQXZ/nWidUlF+ m+S/lEy8S0nt1dXrvp4TzYHz078th1yMNYthVBsfLxmeQKT1gn83Wh3xlMqXmlHmgd56 rSQw3jA9FIAcqy2zQy3dSYPCYkqQvbwO/SLe/hDxXOdk4COErbNnba4pOImjA7dsVZzL qnQRHWwOyAfEzfVM9xj+oDFjvRCEFQaZpHbQmBM7vB++/M2UFS4yaSxQgPDrFaaZZIBf eEHuPajqAxjrWAGCKdg/zt3tDI+zuocclDJmcLyL+IQTQy29+mdeGKGL+A9LXyCasBh3 8yCQ== X-Gm-Message-State: AOAM532eXVswoNdT+X9jsHLeSSPVH0ZSb2D/bBf+JCUsf197CetaOe26 FS+th7GvTPIY3vUGi8QHEt1q4BQZI7/4eJdHKuE= X-Google-Smtp-Source: ABdhPJxPQH0wBMCr0pExnt7qJRixTkXQl+3Qg1d8UOcjWp23ojc7rVeaEtT0MVyZnZngr+ytTVe6IXgeNlYpnps2dW0= X-Received: by 2002:ad4:5cc2:: with SMTP id iu2mr11555814qvb.41.1630928846389; Mon, 06 Sep 2021 04:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210617220229.7352-1-zev@bewilderbeest.net> <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> In-Reply-To: From: Joel Stanley Date: Mon, 6 Sep 2021 11:47:14 +0000 Message-ID: Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled To: Mauro Carvalho Chehab Cc: Eddie James , Zev Weiss , "linux-aspeed@lists.ozlabs.org" , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , Ryan Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210906_044728_814907_416388ED X-CRM114-Status: GOOD ( 30.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mauro, On Mon, 6 Sept 2021 at 10:10, Ryan Chen wrote: > > Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't > > enabled > > > > On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote: > > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > > > garbage interrupts"), the ASpeed video engine sometimes asserts > > > interrupts that the driver hasn't enabled. In addition to the > > > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > > > patch, COMP_READY has also been observed. Instead of playing > > > whack-a-mole with each one individually, we can instead just blanket > > > ignore everything we haven't explicitly enabled. > > > > Suspect this will fix an intermittent problem on AST2500 with screensaver. > > Change looks good, thanks! > > > > Reviewed-by: Eddie James > > > Reviewed-by: Ryan Chen > > > > > > Signed-off-by: Zev Weiss I notice this wasn't merged in the pull request you sent for v5.15. Would you be able to ensure it makes it in the next pull request you send? It can have some fixes tags too: Fixes: 65d270acb2d6 ("media: aspeed: clear garbage interrupts") Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") Acked-by: Joel Stanley Cheers, Joel > > > --- > > > > > > Changes since v2 [1]: > > > - minor commit message improvements > > > > > > Changes since v1 [0]: > > > - dropped error message > > > - switched to a blanket-ignore approach as suggested by Ryan > > > > > > [0] > > > https://lore.kernel.org/linux-arm-kernel/20201215024542.18888-1-zev@be > > > wilderbeest.net/ > > > [1] > > > > > https://lore.kernel.org/openbmc/20210506234048.3214-1-zev@bewilderbees > > > t.net/ > > > > > > drivers/media/platform/aspeed-video.c | 16 ++++++---------- > > > 1 file changed, 6 insertions(+), 10 deletions(-) > > > > > > diff --git a/drivers/media/platform/aspeed-video.c > > > b/drivers/media/platform/aspeed-video.c > > > index 7bb6babdcade..77611c296a25 100644 > > > --- a/drivers/media/platform/aspeed-video.c > > > +++ b/drivers/media/platform/aspeed-video.c > > > @@ -563,6 +563,12 @@ static irqreturn_t aspeed_video_irq(int irq, void > > > *arg) > > > struct aspeed_video *video = arg; > > > u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); > > > > > > + /* > > > + * Hardware sometimes asserts interrupts that we haven't > > > actually > > > + * enabled; ignore them if so. > > > + */ > > > + sts &= aspeed_video_read(video, VE_INTERRUPT_CTRL); > > > + > > > /* > > > * Resolution changed or signal was lost; reset the engine and > > > * re-initialize > > > @@ -629,16 +635,6 @@ static irqreturn_t aspeed_video_irq(int irq, void > > > *arg) > > > aspeed_video_start_frame(video); > > > } > > > > > > - /* > > > - * CAPTURE_COMPLETE and FRAME_COMPLETE interrupts come even > > > when these > > > - * are disabled in the VE_INTERRUPT_CTRL register so clear them > > > to > > > - * prevent unnecessary interrupt calls. > > > - */ > > > - if (sts & VE_INTERRUPT_CAPTURE_COMPLETE) > > > - sts &= ~VE_INTERRUPT_CAPTURE_COMPLETE; > > > - if (sts & VE_INTERRUPT_FRAME_COMPLETE) > > > - sts &= ~VE_INTERRUPT_FRAME_COMPLETE; > > > - > > > return sts ? IRQ_NONE : IRQ_HANDLED; } > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel