From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22673C4338F for ; Thu, 5 Aug 2021 02:19:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB41560F43 for ; Thu, 5 Aug 2021 02:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB41560F43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yBF/CW7oovvDtTuOfhmxcw6mECZfH27Wxdarr64PtiA=; b=rtbTR6wQ4AKtBz 1tiUJe8usb2UpGjl9YNWc4PoLgj7HZB68SS88PWR1Q23UeiqvKA9zdKXoUMj3G7oaP3vtZBJ8ywAO ZppfW9Godv3VAMKKEBYMbYMAvzJzbsiqULwSCxJn9mdZbzSKm6icGloZtiVcdKJL3m3qVc21CfY8Y 7l6mByJGBdazgwYkNT5LDxA/vVTKVJidxyL1m1p/aCtc+64rJCXMWWpXhsZ+aFDw2xtPQhNSsEEAb pSsR6TT09k2y7dObkkEIx6jxMoANVudBNLlIQGL0O3K5UD4lXJUTNQJGtU7dHrwGbdWTjokfuO0yo w7mZkiOMn9vsz6irLBJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSws-007spq-Gy; Thu, 05 Aug 2021 02:17:30 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBSwo-007spR-UN for linux-arm-kernel@lists.infradead.org; Thu, 05 Aug 2021 02:17:28 +0000 Received: by mail-qk1-x735.google.com with SMTP id z24so4846389qkz.7 for ; Wed, 04 Aug 2021 19:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rkGOSVQF9TOhjzyiUoCJV05ZbHNx5GT+bf4KeZ6f2IA=; b=B/uPjSmx60H4ihwfZ8wtzF6CYCbTEPVmk4keYAeCgxiUr7EbcO/Xr18Udj7qjH5pDi +hLao+j9kUFgzdXaH/y6DvRYXsBXnRnMH9bAa2Mo3Heh8Xn1tVLhLpaZSygh2NrmMsQB KSa+jXTwJWa9pcw6CjXCG92kKr9d5tF9FPV/Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rkGOSVQF9TOhjzyiUoCJV05ZbHNx5GT+bf4KeZ6f2IA=; b=RK9/c/UkmGT/K9aW1ExRRIcp7Z6zqvw5ilESVMQ53Pu95hCNeJCA+MLPexuzWwLX7n 7gZ4TJc/WXgZSvYIyxNNCQnaCxLrRYo6QLXj0BEV1Ue5sMCUZ5sMdfIJaI+zb65n1BCd D8OOFzaf7n0vtkwUyufMJmrfxSia03kQyBtdxt6Nr7QsQmvWvtOnRI6l7ZjERB3qeOPG or8yj/9pG0k7ih4p1Phi32vqXEo1EMwFo5J43nJtaErC5XNQHSQZihPlwR7Wuh/V/31F XiZ4pIpI7hsP2xT8iYFdhM9vj6lBic2iEWpH91rHORPmcYyby3sGjkLv1Cq9HsKE9l2Q z7Ow== X-Gm-Message-State: AOAM532SjqyqvQntzU80WohUrZIy4qu55ApnP67hCt7CdvZjJPmuknCs 8UBkUHKflxQzAMmG98M9J+ejFd+OoUgDnuUf084= X-Google-Smtp-Source: ABdhPJysI08p+xS1rb4jB6N4wAriNvzo2kltaAaQt1+UjwLYcRVjKGA2lAJPptqP1gzrQhP151sLslPnoPHg6ECB8Y8= X-Received: by 2002:a05:620a:893:: with SMTP id b19mr2511179qka.487.1628129845723; Wed, 04 Aug 2021 19:17:25 -0700 (PDT) MIME-Version: 1.0 References: <20210728233755.17963-1-rentao.bupt@gmail.com> <20210728233755.17963-7-rentao.bupt@gmail.com> <20210805011951.GA28444@taoren-ubuntu-R90MNF91> <20210805020946.GA29371@taoren-ubuntu-R90MNF91> In-Reply-To: <20210805020946.GA29371@taoren-ubuntu-R90MNF91> From: Joel Stanley Date: Thu, 5 Aug 2021 02:17:13 +0000 Message-ID: Subject: Re: [PATCH 6/6] ARM: dts: aspeed: Add Facebook Fuji (AST2600) BMC To: Tao Ren Cc: Rob Herring , Andrew Jeffery , devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , OpenBMC Maillist , Tao Ren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_191727_028601_629AF18F X-CRM114-Status: GOOD ( 28.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 5 Aug 2021 at 02:09, Tao Ren wrote: > > On Thu, Aug 05, 2021 at 01:37:29AM +0000, Joel Stanley wrote: > > On Thu, 5 Aug 2021 at 01:20, Tao Ren wrote: > > > > > +&ehci1 { > > > > > + status = "okay"; > > > > > +}; > > > > > > > > Have you verified that USB works with mainline? I've had reports of it > > > > working on 5.8 but it seems to have regressed as of v5.10. > > > > > > It stopped working on ASPEED since commit 280a9045bb18 ("ehci: fix EHCI > > > host controller initialization sequence"): ehci_handshake() returns > > > error because HCHalted bit EHCI24[12] stays at 1. > > > > > > I have a dirty hack in my tree (ignoring the halt bit) and it "works" on > > > AST2500 and AST2600. Let me send an email to openbmc and aspeed email > > > groups to see if anyone has more context. > > > > We discovered the same, except in my testing it wasn't actually > > "working" on my EVB. I have a A3 EVB on my desk and when plugging in a > > USB key nothing happened. > > We have a non-removable USB device on Fuji (AST2600) BMC and it can be > enumerated successfully (after applying the hack). Let me vist the lab > and plug a USB key to CMM (AST2500) BMC sometime next week. Will collect > results and send out email then. Thanks! > > > status is set in ast2600 common dtsi, but let me set it here to avoid > > > confusion. Will update pinmux in v2. Thanks. > > > > Are you looking at mainline? I think it's disabled by default there: > > > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/aspeed-g6.dtsi#L246 > > Sorry for the confusion, Joel. I mean the device is enabled in > "ast2600-facebook-netbmc-common.dtsi" (patch #3 in the series). Do we > still need to set status to "okay" explicitly in platform dts (to avoid > confusion)? I see, thanks for explaining. It's a downside of the device tree bindings for the ethernet device. Given you will be the one working with the board, I think it's up to you how you lay it out. You could choose to add a comment to the platform dts, or put the hunk you currently have in the common.dtsi in the platform. > > &mac3 { > status = "okay"; > phy-mode = "rgmii"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_rgmii4_default>; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel