From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2645AECAAA1 for ; Tue, 6 Sep 2022 19:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bi4kNd26VlZxZ2W7giuPpcHCrpw6m+FvQTms8rurqoE=; b=jimtdi+yUDpGbG wvqqB+DmBx14aFwNghhBGqJKiQ8bIf3lRvXpbENbiBocip2ouDoUrDbRlnbG1KxvnfTVfEQRy+W3Y 1Hm5+b1o0MDtYe5JTBtQFp1muG1CuKH3p4XDRjsgxBwj68k58g7rWvBdkYMS3Bq3in+l2Rfv1jllI 4BrBYnzI/1APPOjEglYmkEND5qbIDSjfATlH7Om7J++8Pk4ePg9lYZdcE4IM4se3nCZOAtwFcCb1v 6T5q+OL20AtOb9zy4hFWBtj71T64eSEBZKJpIKV1gNmIq5ViBScCm6b40XiR/z+wmfdaYPX3/vPWl FqW/9A2Yjz8M5KyA3ENg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdmo-00GVu6-Tm; Tue, 06 Sep 2022 18:59:03 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVdmi-00GVrh-2O for linux-arm-kernel@lists.infradead.org; Tue, 06 Sep 2022 18:59:00 +0000 Received: by mail-ej1-x636.google.com with SMTP id nc14so25377180ejc.4 for ; Tue, 06 Sep 2022 11:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=YhCD2BUnvk+EART+qJYRghEdCBWvNx4ju2rtPfEiOI4=; b=y+siq/RM3RjL+a1SK0nGMlaEWNEBEQpvol3sAC7TSLKfqrvgrwE+jUGmQgB/MUNllk jnsMr1WTUb1cZLxUcNNORCDaeZfQt3O1dgZahrjHwLFy0N6vd6qrvqlsy4AEpQ/4VXsf zWotv3g4A24afILYTS/uVTv4MQrVjjn09OpgSxusqSom94LbqJNvu50DCuu0P9ro/JId GkTk05VU3tLi5ADw6VkS0s49SNsT77h2jqjtOZEWVI40YVhpkHSt19Z8JmMq67O9jUmd fUm9c2Qa9pCn4G5/mzAkrd7N5g1tRPHblr6ND74ND6KX6C6xDtOakIOOqteQoziPUM4L N3jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=YhCD2BUnvk+EART+qJYRghEdCBWvNx4ju2rtPfEiOI4=; b=fspwcLeh+QHONDKg8a867F0Qy46rsfeIGBcZx8R4lvZxUOM0UzN/S0p92rgAdLe9ZA PE7GGbl/S1Os05/ipCaqPHkI8ardOiUHGng/v3N4kSVcmfbiCuyktgM0UE6giTG8SVVO r5C/3n9O3vAJhAP2vWraHBipg4qR8/evKcP6i5nsk4OLfXV30uK9Qgt8LBYyDXLx5NB/ rj39ds8cAcBbpCZcjmO2Ks7C8yDHGlvjf+CmPtjNdwPZp8+UWI3vzMyT6XbK4CEgC40X KAo8NpJBU2mok4f8o6raecz181njZ7HGmR7DIdQvLJXJjaQrndavXT4VyYtUwhZcpaGK jxdw== X-Gm-Message-State: ACgBeo3W1pcOaYluVaCv0lZ71nZv/Za+4cBCHR5paBvMKDaTh/Atthjr yPlni/e1UwR+iMoqBOjCmTR0x4FAU92vz+mZ/ma7UQ== X-Google-Smtp-Source: AA6agR5AOS8szLUYRUywxgPElU/nyOQWQJSIyBhejwRqUbyMNY9SBFGhCIk8wI4FG9Qv8YfYQiDR8F4+fwjKMWs/ojo= X-Received: by 2002:a17:906:58c8:b0:6fe:91d5:18d2 with SMTP id e8-20020a17090658c800b006fe91d518d2mr41006298ejs.190.1662490731615; Tue, 06 Sep 2022 11:58:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Tue, 6 Sep 2022 20:58:40 +0200 Message-ID: Subject: Re: [PATCH v2] mfd: stmpe: switch to using gpiod API To: Dmitry Torokhov Cc: Lee Jones , Thierry Reding , Jonathan Hunter , Rob Herring , Krzysztof Kozlowski , Maxime Coquelin , Alexandre Torgue , Francesco Dolcini , devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220906_115859_364721_B0FD313F X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 6, 2022 at 8:35 PM Dmitry Torokhov wrote: > This patch switches the driver away from legacy gpio/of_gpio API to > gpiod API, and removes use of of_get_named_gpio_flags() which I want to > make private to gpiolib. > > We also need to patch relevant DTS files, as the original code relied on > the fact that of_get_named_gpio_flags() would fetch any data encoded in > GPIO flags, even if it does not reflect valid flags for a GPIO. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Linus Walleij > --- > > v1->v2: > - add DTS changes, as noticed by Francesco Dolcini. > > I guess we could do a dance of changing stmpe to check the flags coming > from DTS and try to distinguish IRQ flags from proper GPIO flags, then > have a separate patch changing DTSes, and finally a 2nd patch to stmpe > to use GPIOD API, but I am hoping we could apply this in one go... It's a mess, let's just apply it and forget about it. It's one of those trees falling in the forest and noone is there to hear it fall-type of things. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel