From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7977FA3743 for ; Tue, 5 Nov 2019 09:28:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA03222476 for ; Tue, 5 Nov 2019 09:28:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NogCy8su"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WVjlcjsA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA03222476 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KIcWS005OMVRydSmse3lgOj8tPu+zmZsVzjhm6oLluc=; b=NogCy8su2OM0Dl 5BzS5llB8/IWj5xgkvtVrMX7pV+7z5iyauWIYyfi2kSs/8YiXH47HJ9+RViwzRv9H2SoEOzAMGo/7 EVHiG6Q0cfhELST7j/dcC8MaPpgXvqAmceaHmYPRnNtpEjBaYqf3XskaDT9/AdCtf6mQDxFcfXtI1 9dGyY+eO9rmKcmeslVz2nl+B0A4oGpgDw7aKtq52BcndPf6aH8PW4uc+9zoAoJeNu3u30y5IPdIqv fGgUv3KLnq4XTWECmXkQ5iyhHvk+EhDEha3nM2SnZBLXzgONBOpPhwwrWBzC7jrGbyZp2aaZ6wmne VNNl/SlI1b6itZDacpPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRv8Y-00024h-36; Tue, 05 Nov 2019 09:28:30 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRv8V-000231-4X for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 09:28:28 +0000 Received: by mail-lj1-x243.google.com with SMTP id e9so7661089ljp.13 for ; Tue, 05 Nov 2019 01:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F2FPfgjdbIXWdDjS0yCRl6/2h1CV4PZp64uPK2X2BNQ=; b=WVjlcjsAOE+e3hERSGqNCL8ugQssMBzjxA2Ol1tzpslqafskb+d2jyNqT1JD9GsOMo qsCQWow1BCS3ieMoh8sCB2LZw8OMmnvBYirEwVOK0hECiIXvPCK/qloP+/hGPgf7mBIW nGNIpW27JhXojS4uyw/a9qYmYpu4wEau1xe775jP74yD7K+PQU+DawGWaPSO4jZolhMl 6n7hDnxoY9IKeSpOdI6474fWiZmGTcVWlgZhkPxjoPRFYxP80S927Ww00HXm1JWknfso QkI943Fcr72SDf9V+JOoKKVnRzqbaw5PWTIj8OaHuycQeD6GgTHdHdEHSGxza4WG1wkx hJwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F2FPfgjdbIXWdDjS0yCRl6/2h1CV4PZp64uPK2X2BNQ=; b=D84mUUoJCdreq3AR668+6BATHKc+Zwi8C0B2WqV2OEad0Hd2lxL+dI7phX4BDvJD3r S+aUvIhjp3TIYF9aXa6sXiPMtRSX8FY/JTTAFOvRlZYTNOHym9mlr7F/fIz6HMJhTmSA zbiO/B5EErbDyS8mA2ldvmHQgQ0pBKN6hXQm80QI09iXaWfA3LQCqzU1EXtMHceznEJy neeJJnS6EPwv5hm4htS/UREbK1z1cgSceBLD9TpPs88cTCkQ8i29C9eka2KiERvFDHoi T4c6W8mA8swEkKjz/qz0KYSObCEj+zzve5E1EBKvDPzxIkm/6aGEJ5EmM+qFYBRdxsSZ EIug== X-Gm-Message-State: APjAAAVCAJszayeGGO1sqdoE4VuCDvCmV6x6ff3LBfwEQHku6bVD1UjZ 1N5pvl4UUJfYg0WbB1RjoJd43ApPbrXZS4wku6U8Ug== X-Google-Smtp-Source: APXvYqzkf3P4NiC+7rZsNgbXYUIcsBRDikSMDKFNsnz+OK18v4KaaK/EheFwXUjlKoFP+nppakoDlDtKmiwMGx5B9Mw= X-Received: by 2002:a2e:9a55:: with SMTP id k21mr8803557ljj.251.1572946105330; Tue, 05 Nov 2019 01:28:25 -0800 (PST) MIME-Version: 1.0 References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-26-arnd@arndb.de> In-Reply-To: <20191018154201.1276638-26-arnd@arndb.de> From: Linus Walleij Date: Tue, 5 Nov 2019 10:28:12 +0100 Message-ID: Subject: Re: [PATCH 26/46] ARM: pxa: zylonite: use gpio lookup instead mfp header To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_012827_189458_95BCBCE9 X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Haojian Zhuang , Daniel Mack , Linux Input , Robert Jarzmik , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 5:42 PM Arnd Bergmann wrote: > The mach/mfp.h header is only used by this one driver > for hardcoded gpio numbers. Change that to use a lookup > table instead. > > Cc: Dmitry Torokhov > Cc: linux-input@vger.kernel.org > Signed-off-by: Arnd Bergmann (...) > + GPIO_LOOKUP("gpio-pxa", mfp_to_gpio(MFP_PIN_GPIO15), > + "touch", GPIO_ACTIVE_LOW), What I tried to do with code like this, when I was ambitious, was to wind out mfp_to_gpio() as well and either just encode the offset on gpio-pxa as a define locally. But this works too, the kernel looks better after than before and I am not perfectionist, so: Acked-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel