From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E1EC433E2 for ; Sat, 11 Jul 2020 21:19:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F3B020725 for ; Sat, 11 Jul 2020 21:19:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q4YsrK8F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UqNakKmZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F3B020725 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wn4JauZNN+5hj7Y2pNoy3aWBc/FC3JQGby5pawrrTAo=; b=q4YsrK8F3zRlVmhvxrmBtUXui 9VMbXvu5uCbiKIheC1UsFWgZE5UjOYYeYDTsdERu9meHqtpimXWxZKqcY1kZ1kObSqM7Lpjx5zPxX 9N9x8TTtBNE5S4NAUhjgEychn/EJDrqSTZKt3CaNHvTQhTIEvhs2ZD/N8x5MTzDS6K8oOpPcvsvpW 6C25Db5sPSot54SclpqiI641me3XqEMkRb+wKt8aqW7cDwjxpMm9N9nEFHRYuvkh1K3dTv78G+q8G spLs7sQHSp7cMsA84Ul+oineEfZ2wnoyq1HNf4K8o9FqFl6pxP62lmHEoPF+LQV+FiRooZcTsui9h 18ObbxoDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1juMsi-0002xF-10; Sat, 11 Jul 2020 21:18:00 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1juMsg-0002wc-1D for linux-arm-kernel@lists.infradead.org; Sat, 11 Jul 2020 21:17:58 +0000 Received: by mail-lj1-x243.google.com with SMTP id r19so10353495ljn.12 for ; Sat, 11 Jul 2020 14:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wqb18s+NYtJBD4ijNg7d8R2/EPoJeQ86xG7wEDLp5I0=; b=UqNakKmZZ125zE7aCrUB/FRrke2hYX8bYIK72Azll6JhZ9g46WilSX2lPkVONVzkUn 38oy1jIZbRqpBJqkOD51aYCJmb4Q4ElI2SAzJzDx2C0I0q7XCi1+zbT/MjHXnpnjHz+B lGug/VLskaWGmyA3bbZaudgCg2sieCTvxiamZDlgPXJDizun+WoNnsonxdYKxE4AT229 FcWc98rUvcWF3JXBq/Gwr55pydfM5BitCAzvjIymtpl+dfRDYQtrsmnHsEKEM1/bein5 iuAgSGLetrR08XSBvlJGEFzCLZo4AwNPGS2Wh3mZEJP/crq5RsZ3dA1A75XozhvnO5ES yJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wqb18s+NYtJBD4ijNg7d8R2/EPoJeQ86xG7wEDLp5I0=; b=ExjWy6jGXjznxrWxwnm6nPoD/9KV1S/fgGlzLSwd1p4tKm5k4L6EgebjYhp7TjqUEE qA8ynnnXFXmR1dFJQ4ejaSSqZDHUt1D8/jDws3XVGMphNSqkAtFsTrtIF5jj4YBfOVoE svPJys/mdYH61E051O0MAwGCoYhMpTtyi05HurL8JtpPeLM9pkBuprAAXmGnyjlnpS73 5opMoF4GlAElTYs2F6/6QnwMFghtgJtBamjiEMydvyAeKYwRRYP2ycJVXqtG046R46z9 13x1RfTwmm0Zd2auDmZOck0pluIMaNxe63S9mXC+04qRRQaudTeFNS7Wa7JowlPfe2q7 PYuw== X-Gm-Message-State: AOAM531w3PNOyUJgrfNKcDrbwKtWs5HpFWIjKwapmKssPGhTvaPEjdca Fx13dwTewoJxDLXdd3g+n6iexKE1kGncXpAF8q3Z8w== X-Google-Smtp-Source: ABdhPJxTb9eukJ235AFc+OGGaO7D1n9aCXDniaL1t98L7aPdbqsBZfzXdMGSsKdhxtpjBTSzm37thnqZs2YYXtskJPc= X-Received: by 2002:a2e:8597:: with SMTP id b23mr27400495lji.338.1594502275360; Sat, 11 Jul 2020 14:17:55 -0700 (PDT) MIME-Version: 1.0 References: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> From: Linus Walleij Date: Sat, 11 Jul 2020 23:17:44 +0200 Message-ID: Subject: Re: [PATCH 1/3] gpio: mxc: Support module build To: Anson Huang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200711_171758_139534_E391F02F X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Will Deacon , "open list:GPIO SUBSYSTEM" , Shawn Guo , Sascha Hauer , Olof Johansson , Russell King , Bjorn Andersson , oleksandr.suvorov@toradex.com, Bartosz Golaszewski , Vinod Koul , Andreas Kemnade , NXP Linux Team , Sascha Hauer , Catalin Marinas , Adam Ford , Leo Li , Fabio Estevam , Linux ARM , hverkuil-cisco@xs4all.nl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 8, 2020 at 1:28 AM Anson Huang wrote: > subsys_initcall(gpio_mxc_init); > + > +MODULE_AUTHOR("Shawn Guo "); > +MODULE_DESCRIPTION("i.MX GPIO Driver"); > +MODULE_LICENSE("GPL"); You are making this modualrizable but keeping the subsys_initcall(), which doesn't make very much sense. It is obviously not necessary to do this probe at subsys_initcall() time, right? Take this opportunity to convert the driver to use module_platform_driver() as well. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel