From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4674CC433DF for ; Wed, 3 Jun 2020 12:35:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 196AC20678 for ; Wed, 3 Jun 2020 12:35:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CP479iXY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xfnWQd9o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 196AC20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+1J3RUMHWve9PGLc0tuS3PKKls0mdk1B6ZFO9qKxnpo=; b=CP479iXY0jFs2v qQdwOJOa2BUwgX8LlpEzR30IDRavk6DRaFoYn7a/dIvRXqLQLFhZBndCrVeMiA2TXyXdiU7j1KX5q d4tDcQnK5rLTLk+ucqsxwiB3ZaFDzgL3fTW5RrGiugBTyAbIwu/mJwKT3J7xPGJQRSmQNgYBJ5egb Szjp6PIeJ5lSGpH3UpZV3CplZIF1nZvJMGqBzE01qdxSdvod/uxnC+oDjKaK47W/1c7sH1K/msp3J f54HSkf8hcVYqjZ8I2esuuJmUwWOTCw6HbNFyHarZGrqTtG1mmL4cHpMDBNU+YUxiQF4LzqbIC+Cq rvvsOZ9oPAs13uU5b/2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgSbk-0006ZS-9G; Wed, 03 Jun 2020 12:35:00 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgSbh-0006Z2-30 for linux-arm-kernel@lists.infradead.org; Wed, 03 Jun 2020 12:34:58 +0000 Received: by mail-lj1-x242.google.com with SMTP id n23so2484856ljh.7 for ; Wed, 03 Jun 2020 05:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PI7pydsdlkyMsOD6xUcLp/qzxqU4rnGyfjXgCb9CfWA=; b=xfnWQd9oEyAsFzOPGt1mBJdArDRnh2rm2HZKJiiufZ4G3XU4PfqVW12McDu5EdvBVb qyfCex95T6C8Tcy86/IPyXEU3S80ASk+HARGYDiI6ViBZrc8pU4AWMn1Jqp8fW1s8W1g rRcyu95uIpQjRNQ0t7A8VWRPB0Gjrr7ZjNixzNhSgX334YRru7RYUn5hqcPerbW9I/vk IUaQ8XN78CUAtwSMO7xGQaeSOXYyu8EoTuCMR15KHfh8nAVjRMCqTcvKmwNbafE99vnv TaEjAvcLgbbAIs3kQ8rZcHoQPOI3s29vSI6VHexaAO6k29daJjUDM2GVsCcOKfV0FEES j8/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PI7pydsdlkyMsOD6xUcLp/qzxqU4rnGyfjXgCb9CfWA=; b=ZeNPkRtpFGH3gafp9lO8eonSLsm1MhOMTiJIUj26PdS5bxR7jEFydDNlnFmo4jow+5 uOp+e/cAfIaxaBXrh6MdCxLdcZWJC8vXKz3a+sh675Txya7+WIHJJ1hFUvd1RyVKFSsH ws31bdvHqAh64kW07qF3Uzi/OM9T+3xOywAz7l7z1nEooQ15y9Omu1G5w0mKC96DHmyL kbkQxQOXXoWkLQtsmwf2HHxWtBd7PW+WCJpK4Weryj+o3AqgEjXFYeLdYEQzxm3Zihoy 8jQYsQCRu8XMtDlTOqh3pkKQQLK7U1Mto4qmk5SqsAYWssI13td+tEHPx/DVFKDBF70d 0KzA== X-Gm-Message-State: AOAM530qoc7FkuUPWQBvNpFKRYlAwJgdFszNm/3iRankCf9ijspZOSRL 8Rw0lhlJxJ/91LUVJEVRXV0DtN0j7F8ZoTDxsXHFJQ== X-Google-Smtp-Source: ABdhPJwzUPzaqApWBasR0U8pnoYQewI2Zvey0OigUC/P5cfEYrETfElS5dHa5BQgryE1VDaIwAKQXp5y9hxab/Kb4RY= X-Received: by 2002:a2e:350a:: with SMTP id z10mr1926898ljz.104.1591187695709; Wed, 03 Jun 2020 05:34:55 -0700 (PDT) MIME-Version: 1.0 References: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr> From: Linus Walleij Date: Wed, 3 Jun 2020 14:34:44 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()' To: Christophe JAILLET X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_053457_128456_77FF6C63 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Fabio Estevam , Sascha Hauer , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Stefan Agner , Gary Bisson , "open list:GPIO SUBSYSTEM" , NXP Linux Team , Sascha Hauer , Shawn Guo , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 30, 2020 at 10:49 PM Christophe JAILLET wrote: > 'pinctrl_unregister()' should not be called to undo > 'devm_pinctrl_register_and_init()', it is already handled by the framework. > > This simplifies the error handling paths of the probe function. > The 'imx_free_resources()' can be removed as well. > > Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions") > Signed-off-by: Christophe JAILLET Patch applied! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel