From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 7/7] dt-bindings: pinctrl: deprecate header with register constants
Date: Sat, 4 Jun 2022 00:20:47 +0200 [thread overview]
Message-ID: <CACRpkdYS1yV5v7MfqF1hcTe7ETjqOjCYzyLB6KeHHzTzaJbLsA@mail.gmail.com> (raw)
In-Reply-To: <20220526143707.767490-8-krzysztof.kozlowski@linaro.org>
On Thu, May 26, 2022 at 4:37 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> For convenience (less code duplication, some meaning added to raw
> number), the pin controller pin configuration register values
> were defined in the bindings header. These are not some IDs or other
> abstraction layer but raw numbers used in the registers
>
> These constants do not fit the purpose of bindings. They do not provide
> any abstraction, any hardware and driver independent ID. With minor
> exceptions, the Linux drivers actually do not use the bindings header at
> all.
>
> All of the constants were moved already to headers local to DTS
> (residing in DTS directory), so remove any references to the bindings
> header and add a warning tha tit is deprecated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This looks like something that needs to be merged on top of the
other patches so if you wanna merge this through ARM SoC:
Reviewed-by: Linus Walleij <linus.wallej@linaro.org>
Else just tell me a merging strategy and I'll use it!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-03 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 14:37 [PATCH 0/7] pinctrl/arm: dt-bindings: deprecate header with register constants Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 1/7] ARM: dts: s3c2410: use local header for pinctrl register values Krzysztof Kozlowski
2022-05-27 4:22 ` Chanho Park
2022-05-29 8:07 ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 2/7] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2022-05-27 4:26 ` Chanho Park
2022-05-26 14:37 ` [PATCH 3/7] ARM: dts: s5pv210: " Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 4/7] ARM: dts: exynos: " Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 5/7] arm64: " Krzysztof Kozlowski
2022-05-27 3:34 ` Chanho Park
2022-05-26 14:37 ` [PATCH 6/7] arm64: dts: fsd: " Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 7/7] dt-bindings: pinctrl: deprecate header with register constants Krzysztof Kozlowski
2022-06-03 22:20 ` Linus Walleij [this message]
2022-06-05 15:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYS1yV5v7MfqF1hcTe7ETjqOjCYzyLB6KeHHzTzaJbLsA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).