From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D43CEECAAD1 for ; Wed, 31 Aug 2022 09:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cJ2dCtL1cRMYauFSVV5wHVAk4DhqtK0Lij44eV4VVf4=; b=Y779boLNavb/rg ypUQWm0v37ECZDXNgRhzfGEm1KzJbOUmnzDHqiTfGJhwCIY3j8PRx1d0xOtQLs2Hhl5lOwIpRVy5H RaezSQeeUsZpatrqqy/mnL9Yme09rI/io44lQJ/n0mywaPOSGtfkSijBBI9aeh9Asw5kEnRwGGBHn zmVjf0AhnH+bdAGzvJSEHn9aw5jqUk9OrDIkELO/2tnG5/jEKsKqY1sxaVd+h5GNmsMSDozg65tiL 0UMmBJqDFoI1be1eTK+pbI+Yl77LzaniRPJD4tTMOh+5dfEU1fYjxNJUbfrenV22CCpYDYDtI8YL8 TIvHI9NuyW6Hfl9Ntc0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTK3y-005I9H-UI; Wed, 31 Aug 2022 09:31:11 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTK3w-005I6j-SG for linux-arm-kernel@lists.infradead.org; Wed, 31 Aug 2022 09:31:10 +0000 Received: by mail-ej1-x636.google.com with SMTP id gb36so6281376ejc.10 for ; Wed, 31 Aug 2022 02:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=mTMJgxNUn3NdL2Te+hOt7Np5Z6vrIBnPT95qbu1ijYo=; b=z3JWHYIEKt1HnNwSz7g2jiDwM7uqhF3iqPTxL23i2Z/5BSDL75qHHMgDA9viIprqHf kTQy0DiTPJI6k36aeUKIs9Gz22Q7CCKMCLRHUTKEdtzA4p1A7ViQuHlQPerO6xE7ZARL pYQYPJOOuFtFmp0Lm2cn8WE9RMA0bqD/XgVpj0sa/g5itUZoaI4ln99bwcFDKCk2PKpH 4cNpt3T1uNlC4iwXS+fO87q8yKpMPu8yPGXTo3rEpyHyzc2eh2dof91JZkBJr9P6rkUR T3sd8wAmR/ugyXz/4lwOGUiMr5v+nWKBjK2Cw8XJIP7tMrunvUr3IWn90MtjwmNRey1A HANw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=mTMJgxNUn3NdL2Te+hOt7Np5Z6vrIBnPT95qbu1ijYo=; b=JxXQPpn7ctL8kZ1U9WsEvMVHWzuMWgjfVsCTaibjo3r8pQ4wLFlCnTnNAroxQoAu08 bt4tdQhJfOHt3ehbnNUbOOXTuc51QN14Lt3w7+pVtaOugdqObPB7cj036zFT5RgrYCSt dTKSKofd6eSnNzBLE84ClIFGnbRIwf5PMF8iaigERE9+rSL5HsGtBHwd+tm6OsaR0MM+ HrrMAbc3jwXlYO8bEYtn496Eg+gNbaq4pP5PC3mCMb8EYZ/kKaqleTVoqpmWZrvxayxX W5iDOvkRy+IiMGMLhi7gs35QRb9983zIVb7bhlJqxVtouZy4H5mPey/2k+b4jofU+O2F LYQA== X-Gm-Message-State: ACgBeo1uxmc3APiYaW1i1oeIsNB9qFQhpMbi+kbO+9/xVh2KdB7uBSmx sDRQ12QDRwIw838Bc4TOUkwn28W1OGv8caBniEqcGQ== X-Google-Smtp-Source: AA6agR60poVSGtXV5i87R9W5U/zvb+IbanL3O5vxUgelECuvxfH2YElvH/FP63zo5xJofgcng1oFmxEAl5kN685SJYI= X-Received: by 2002:a17:906:9b86:b0:73d:72cf:72af with SMTP id dd6-20020a1709069b8600b0073d72cf72afmr19921832ejc.440.1661938265272; Wed, 31 Aug 2022 02:31:05 -0700 (PDT) MIME-Version: 1.0 References: <20220827213009.44316-1-alexander.sverdlin@nokia.com> In-Reply-To: <20220827213009.44316-1-alexander.sverdlin@nokia.com> From: Linus Walleij Date: Wed, 31 Aug 2022 11:30:53 +0200 Message-ID: Subject: Re: [PATCH] ARM: kasan: Only map modules if CONFIG_KASAN_VMALLOC=n To: Alexander A Sverdlin Cc: kasan-dev@googlegroups.com, Lecopzer Chen , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220831_023108_931149_3B721B16 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 27, 2022 at 11:32 PM Alexander A Sverdlin wrote: > - create_mapping((void *)MODULES_VADDR, (void *)(PKMAP_BASE + PMD_SIZE)); > + if (!IS_ENABLED(CONFIG_KASAN_VMALLOC) && IS_ENABLED(CONFIG_MODULES)) > + create_mapping((void *)MODULES_VADDR, (void *)(MODULES_END)); So the way I understand it is that modules are first and foremost loaded into the area MODULES_VADDR .. MODULES_END, and then after that is out, they get loaded into VMALLOC. See arch/arm/kernel/module.c, module_alloc(). If you do this, how are the addresses between MODULES_VADDR..MODULES_END shadowed when using CONFIG_KASAN_VMALLOC? > + create_mapping((void *)PKMAP_BASE, (void *)(PKMAP_BASE + PMD_SIZE)); (Splitting this in two steps if probably good in any case.) Pls keep me on CC for Kasan ARM patches, thanks! (Maybe I should add some MAINTAINERS blurb.) Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel