From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2903FC2D0E4 for ; Wed, 18 Nov 2020 00:17:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99B032463D for ; Wed, 18 Nov 2020 00:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EAUN9Yn5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eW9ytAHG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99B032463D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZCZ7cimqi5t9FLnRsz5vSE0nWbl9INgSj3JmQfAMZug=; b=EAUN9Yn5UMyk0BfpqrU5NvX9W MFVSCOoTAiGMOcCm9ZriMX2wWQb5tCi1OMFavuK29rrg+nYIyDFKYxs29XDFVhc+/OaIXD6ASySHH 5zk6ss3rROJz6uh0FLsua/aymXR8INKYk5fX7esJQYfZNSwzXhjiCkdH8753UOYbINORrsZPxl/BS NxcpoqITAWAse0QB1DbGEZR1p+Q86P1o+hp6MtorSjurjYcJgWIu8IG3pPu9dpleviwjdVXZperSv tpld+MSgZXJcs1bePDC0F8P+kdkxqp45LBMu18hybW52wPLG75LXVo/FHctvkJbSCaapkeJIpDNBA jCGFwoJ1g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfB8V-0004PI-4S; Wed, 18 Nov 2020 00:15:47 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfB8R-0004OX-VT for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 00:15:45 +0000 Received: by mail-lj1-x241.google.com with SMTP id o24so359456ljj.6 for ; Tue, 17 Nov 2020 16:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eWrhbtxMaDvAA/hqZtx4oXS0+2NR8hi9OYu+UfYxShM=; b=eW9ytAHGHiQg0UjXTBR2k5vHOB0NAXJ6YaKbN8S6L09yrDcZNbH8+z4GWfYUzfhW3t dzMuoT3NE4oZTkYczeQRW/gufIrbJN9ca7ZWH66NdhDmdwSjgTYMibESojmaoZcq35wr XoAMrI3eC4yy9MqqxMDiaV+3CaIUqfFiQoy6Fkv/o2sCnuzTiXxiA2Jccqvh0lvkzmAK mAU3B6JFW9rh8NE8GDLQ4Udmys+N76Ac8+xucJwBSxI7phXYbeoBsjddLquKWuLgWWiN cwXKFVUjAxBLCdQ2aYWpz/872jnOmvRxvJSki6BzeUoJKxNxzMRRTFwbPlWHoN5XW+85 pzbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eWrhbtxMaDvAA/hqZtx4oXS0+2NR8hi9OYu+UfYxShM=; b=j+K1WNTpoRBhJuhNSsBWJysyFB1l+wnFvdbfnl2/URC4g9KtbRCYCyKnkD3DAcuGid t3rEUoaP0i8z/mv3lnrnY+/tFt52TzN/UUXqfTcAsjgV+U6ldBHv+O9A7NAjAtFed/NX cCm27d4V25QSfTJcJ3x911/PaqWEYQCM94ynTYzhWdNSbwFAfk79NXxVpNqJ5mACixjd 9bY7QNTTwvlyUcOf5MBes+EQpjRvygxqfkAv2XPsRqiweOzkt/vyquEOoPFMRMC7D8es Lyt0ZY3ld3CHi8RzGFvnuTEMxYaisbH1Uhxjxn8LmmBzoA7eywtdQgtTtmTxFRKmQgWT j4aA== X-Gm-Message-State: AOAM5333pp8GBr8CjcG9aSlvnfsZvpmVJLB0dE5903hGNID1pSRjUA4C GS6x+Z1k6BGWUamjjSSsVH7cg446OZ1xAEPUjMVvAQ== X-Google-Smtp-Source: ABdhPJyeahuY3HMFK2a8FC+b5Gfa6NyYvm+3NwaEh5oPTktmnIxFCR9vwlEUeZSFblV0ihPS9NFFlAixhcvod44jUX8= X-Received: by 2002:a2e:998e:: with SMTP id w14mr3143826lji.100.1605658542224; Tue, 17 Nov 2020 16:15:42 -0800 (PST) MIME-Version: 1.0 References: <1605201148-4508-1-git-send-email-srinivas.neeli@xilinx.com> <1605201148-4508-6-git-send-email-srinivas.neeli@xilinx.com> In-Reply-To: <1605201148-4508-6-git-send-email-srinivas.neeli@xilinx.com> From: Linus Walleij Date: Wed, 18 Nov 2020 01:15:31 +0100 Message-ID: Subject: Re: [LINUX PATCH V3 5/9] gpio: gpio-xilinx: Add interrupt support To: Srinivas Neeli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_191544_396027_E9927C95 X-CRM114-Status: GOOD ( 13.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , sgoud@xilinx.com, Shubhrajyoti Datta , Michal Simek , "linux-kernel@vger.kernel.org" , Robert Hancock , Bartosz Golaszewski , git@xilinx.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Srinivas! On Thu, Nov 12, 2020 at 6:12 PM Srinivas Neeli wrote: > Adds interrupt support to the Xilinx GPIO driver so that rising and > falling edge line events can be supported. Since interrupt support is > an optional feature in the Xilinx IP, the driver continues to support > devices which have no interrupt provided. > > Signed-off-by: Robert Hancock > Signed-off-by: Shubhrajyoti Datta > Signed-off-by: Srinivas Neeli (...) > config GPIO_XILINX > tristate "Xilinx GPIO support" > + select GPIOLIB_IRQCHIP > + depends on OF_GPIO > help > Say yes here to support the Xilinx FPGA GPIO device Please add: select IRQ_DOMAIN_HIERARCHY Because your driver requires this. > + /* Update cells with gpio-cells value */ > + if (of_property_read_u32(np, "#gpio-cells", &cells)) > + dev_dbg(&pdev->dev, "Missing gpio-cells property\n"); (...) > + chip->gc.of_gpio_n_cells = cells; Why is this necessary? Mention in the commit. Other than that this looks very good and good use of the hierarchical IRQ feature in gpiolib! Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel