From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 085AFC5B57D for ; Tue, 2 Jul 2019 21:04:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2131218BB for ; Tue, 2 Jul 2019 21:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ck4UeQt3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WU9xE1Va" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2131218BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nA2C3DjZkbBgLjfoorQnQbInTxE/AipZwzhVK2z3Z7Q=; b=Ck4UeQt3VURH/D +aCyCerlaI4IJuJlgtIuMWOa6S+Ut0lllqeyGZwIjDda39MbjaFNG1TG0V1KHn0NC48zK0CQjZji/ qREbma3QKq+xx8kSmSTqe273IgLXVG9paOcMOQglOw9EmpjfruyyVdJkXqzaI/nh+75+CzH4EPmT/ XGjeNxA39Dw7RZHFhtAgEFkU+QU+Bxh+unDh7sxay3XeJRTYKBzXUUMdywx1zp9pno5uWxwa8aE99 YDv+r3lSR7lk4ofiOsw3xx87sp/om7t2x03bsuYY9gQdEGYJ5j0lJFF4Epzq/yp6zTVrj4qmODWKZ lYhXK4lalVD7VJRtPWAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiPwd-0000bE-W2; Tue, 02 Jul 2019 21:04:08 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiPwa-0000aZ-FX for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2019 21:04:05 +0000 Received: by mail-lf1-x141.google.com with SMTP id b29so144903lfq.1 for ; Tue, 02 Jul 2019 14:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BWuzzOxwUVGbMCvFD/kQRaZgbqg2U0ttqAGoU0tIxDc=; b=WU9xE1VaEDXdGOfDOaQ8eCNlTBcxHe1uPjWOXfL0akhUDkfR9pYxvy2vkEDfni+c8h WMVK/5ptG9BAQJtthbU9xhXp41aX/dRI7O6DGRbzSic+KQYV4r79fr3F33IPwBk4A9/w GB0kyYoceOYaI2Zwrbm6QbIM8AP0naUmdNCuQ2tAPmooOIqjVKYIIcMIkgONM7r947bm Rcb/3dBlykiu3KSgumMs5axcfx87QLCZKcPVy2M8OzJauDqJh5Z1Bo7FTS75GRY0iu0+ IdLBkAJI8wJkTgpnoj96Ri0vBe8IfwgD2+EBl9ikgM/r7w39QRdydkoW0ChmAqm5YMzc LsVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BWuzzOxwUVGbMCvFD/kQRaZgbqg2U0ttqAGoU0tIxDc=; b=Bfk/fdDQmsJb6ieox1dKAV0SzOMsP57b8zaldpCjfCAW2qqtEMlsWKpANFFvrdAm14 j6Ow3oZ5ncOOVTgsfncA7SDgbkh+AH8kpgf0HbiffjkZ40VWC1V8juTdRrDNBNRBaACJ AlKkxvDVp08CdmScaCQJOP1hyTMEG628hNL33MpHwD905xFNwj0YSUXP8+5pqSh8MGKh LVqw5SPpYv2tfzAcUN1t/FosXBZy2mTKFfP3o06ovEMeYHlJkxtTFGwghCBp5W75lJlD pi/FpaPAd68eg806xWZS8RbdlZ1VzMhD9R+Cw0xR73a1ghZjHdvdEmdC2YoVj6aVmxzw OXsQ== X-Gm-Message-State: APjAAAVWcQ278+0/ZPb4E1oCOHhoFhWsY1pfGr12k1jXYTuIxo71YDEM kBGGfTnU3G51oCaxx0gmDQh4YAlN9pHD4wlxIfYdnQ== X-Google-Smtp-Source: APXvYqxPy3MzRImB1p5uGBTXdcSHdB32SVAS4jpsrlLbMd+boV/5IuiNLeQxCDIw30/585vq93owljYh5YviaC4jL+c= X-Received: by 2002:a19:dc0d:: with SMTP id t13mr1324771lfg.152.1562101441838; Tue, 02 Jul 2019 14:04:01 -0700 (PDT) MIME-Version: 1.0 References: <20190617221134.9930-1-f.fainelli@gmail.com> <20190617221134.9930-2-f.fainelli@gmail.com> In-Reply-To: <20190617221134.9930-2-f.fainelli@gmail.com> From: Linus Walleij Date: Tue, 2 Jul 2019 23:03:50 +0200 Message-ID: Subject: Re: [PATCH v6 1/6] ARM: Add TTBR operator for kasan_init To: Florian Fainelli , Russell King X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190702_140404_531562_6D40D914 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alexandre Belloni , mhocko@suse.com, julien.thierry@arm.com, Catalin Marinas , "linux-kernel@vger.kernel.org" , David Howells , Masahiro Yamada , Andrey Ryabinin , Alexander Potapenko , kvmarm@lists.cs.columbia.edu, Jonathan Corbet , Abbott Liu , Daniel Lezcano , Russell King , kasan-dev@googlegroups.com, bcm-kernel-feedback-list , Dmitry Vyukov , Andrey Ryabinin , drjones@redhat.com, Vladimir Murzin , Kees Cook , Arnd Bergmann , Marc Zyngier , Andre Przywara , philip@cog.systems, jinb.park7@gmail.com, Thomas Gleixner , Linux ARM , Nicolas Pitre , Greg KH , Ard Biesheuvel , Linux Doc Mailing List , christoffer.dall@arm.com, Geert Uytterhoeven , Rob Landley , Philippe Ombredanne , Andrew Morton , thgarnie@google.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian! thanks for your patch! On Tue, Jun 18, 2019 at 12:11 AM Florian Fainelli wrote: > From: Abbott Liu > > The purpose of this patch is to provide set_ttbr0/get_ttbr0 to > kasan_init function. The definitions of cp15 registers should be in > arch/arm/include/asm/cp15.h rather than arch/arm/include/asm/kvm_hyp.h, > so move them. > > Cc: Andrey Ryabinin > Reported-by: Marc Zyngier > Signed-off-by: Abbott Liu > Signed-off-by: Florian Fainelli > +#include What is this for? I think it can be dropped. This stuff adding a whole bunch of accessors: > +static inline void set_par(u64 val) > +{ > + if (IS_ENABLED(CONFIG_ARM_LPAE)) > + write_sysreg(val, PAR_64); > + else > + write_sysreg(val, PAR_32); > +} Can we put that in a separate patch since it is not adding any users, so this is a pure refactoring patch for the current code? Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel