From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E422C31E46 for ; Wed, 12 Jun 2019 07:18:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A5820684 for ; Wed, 12 Jun 2019 07:18:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aKUyeDbL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T3WDjTm7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A5820684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w24Hpr5D9Gp7niZDe3umiQBwiVVeW/FWgxrxRyD1v4s=; b=aKUyeDbLZeNFH3 /qzRZ+D23HEiuIDOdM7C4a/lfTAi7gCGR74ZmfsEoPEZB/1jUFOySiAw8s062+yb8Ch3ZBQeh6yiz 9QpYyQHLBDrovZDAyFpsbwrN18OfEjHRaaQeqBwiF16hYc36OyLvZolmlqywDcLuAyGQPKcSPLtNS TeAACXcchOW+k0MEt09WQcFXXBHHDOwyUAZMtVdIuMkLKsu5cPl432VLgTgCkcU7k8xIPCgToWcjI dwb+vbIna7ZGsR6eYHnPu7beUjDrmp8yfV54DNycpUpMQyECzU+nA6X8Fov9E9wRS6pBfMffEE8OZ EYYVswaH8X9ZIZiAh79Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haxWr-0003dU-GR; Wed, 12 Jun 2019 07:18:41 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1haxWn-0003al-0P for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 07:18:38 +0000 Received: by mail-lf1-x143.google.com with SMTP id z15so8534991lfh.13 for ; Wed, 12 Jun 2019 00:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eLHfkrcZKTo38F+HaUI6ckV79OZ0o6Qwqt61e1BrVrE=; b=T3WDjTm70bMNjTMTCWqVSg7AlbbkPQ8m68HplITNSif9lb4dM1J4+qSqh7Bvp7O3Ww Yysk1R0j0bTNnoYt8zCSs1qZ2Mvg/HDYnUQjzbxPpjFkVJ64dq01UEDZ8S/Rt6thbZw1 5NajMHZbFg4j/a5wyeEch9lfQlmmQ4wly/T8T+D8yAuCtTqPsuadEWmNpYEWD+qI3Ujf Qsiq2AHo0pbd9cDZZocdVrxiX+rjbf5XzFWkKficu/3zleLrwS4ImuQ7oGn//+LMWp8f mTOFKEPWKMLqcqWoNsoh8P7l1Xaz0bzm+e7F2zYbglE2PY28+hh/H8bTV2RSeAHKygwB hNog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eLHfkrcZKTo38F+HaUI6ckV79OZ0o6Qwqt61e1BrVrE=; b=OwjQMVGRAlS0FvuS/cVKgYANIGRpHtUyh13+uPMWMmiW1S0oQnd0wkgNDx8LZwid3i cDEHI1IapT3Yz0pKPZey6ARML6413/OpaPYl3yHdUXspLuWCNHnDgjmZVomTQS+hr3KJ JydF/CHEW/dDMRAyNGkvgjCsc7HbuwZRk7rWf7UujBCuKWqt2gdyeynpdIWW7dMlvl4s HiV6Xhddf7zZvuTXkPg9IZ1b/wDTimhSxDeTe51+DFzhFWXJV5JAUDtatUyv32CF60j3 u0K5l2VbH1UlVQ0uf08wleUKwROHPolrn1ooADfxzyqJmy34X81VSbaGT5suVgMp+6Zj 0DXw== X-Gm-Message-State: APjAAAUsgreJFFrTNSJamXVUZ1lzLQe1M7sfmDN1b/2FERokE+I0l3fY j7ZbVfvG6ULzRgGdAHqpNEYlOBrYC4kQPmeU1IvUow== X-Google-Smtp-Source: APXvYqzDh4d8Jgxhz1KUU0UefThe5Mfao7GnQlNr1l1ciJMnwpzLb6ZT/NclpErH3pe+BXltkLCsA/57T4H+XLB/VdE= X-Received: by 2002:a19:7616:: with SMTP id c22mr36520290lff.115.1560323915112; Wed, 12 Jun 2019 00:18:35 -0700 (PDT) MIME-Version: 1.0 References: <20190610084213.1052-1-lee.jones@linaro.org> <20190610084213.1052-4-lee.jones@linaro.org> <20190610085542.GL4797@dell> <20190610092245.GN4797@dell> <20190611183945.GP4814@minitux> In-Reply-To: <20190611183945.GP4814@minitux> From: Linus Walleij Date: Wed, 12 Jun 2019 09:18:23 +0200 Message-ID: Subject: Re: [PATCH v3 4/8] pinctrl: qcom: sdm845: Provide ACPI support To: Bjorn Andersson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_001837_061543_78F9D61A X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-usb , Wolfram Sang , Greg Kroah-Hartman , "open list:GPIO SUBSYSTEM" , Ard Biesheuvel , Linux Kernel Mailing List , David Brown , alokc@codeaurora.org, linux-i2c , linux-arm-msm , Andy Gross , Jeffrey Hugo , Lee Jones , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 8:39 PM Bjorn Andersson wrote: > Last time we discussed this the _only_ offender was the loop issuing a > get_direction() on all descs towards the end of > gpiochip_add_data_with_key() I think that is still the only offender. We were a bit back and forth: adding that code, removing it and then adding it back again. In a way it is good that we detect it so users do not crash their kernels by asking for these GPIOs at runtime from userspace instead. It makes a lot of sense for us to ask for the initial direction for all pins, as they get registered as GPIOs, which by definition makes them available as such and we should be able to inspect them. "GPIOs" reserved by ACPI arguably are not GPIOs anymore since ACPI have dedicated them to a special purpose (no more "general purpose"). Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel