From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42936C3A589 for ; Tue, 20 Aug 2019 10:27:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C57022CF4 for ; Tue, 20 Aug 2019 10:27:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="llT5sTgN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WRmbYOSu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C57022CF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pU1j3oo8UyXiLmN9u7sj8y0SaiMuNjGavhZIeh6LWTY=; b=llT5sTgNnqmoqA SVGLi+eLtGuM1Qw7sD9TJIPLzZSgnsD8+tEYGklmzan2F03jWNBqV5K/REZDr9+UM3HeJ5eEBJH3l HUIPHLNTXZnsojG+XV8u/Dzw12ApCZGHGgwEz7s7bDiPVCBrt/IkXju8q2/25W/Fwx8b4F0KgdTDa hQp09wCYMKB2pR6HnRqqeWDRxDHULSJzMY45e4vDlLHcGQ6Q6bO+FHhmWINyuOvBi2Ed1mHKxbcIP MPpbLAPGq80Mi1/HVa4y4F6n/YNetd+TSUkyuLG5EE+0tsOdX0FgtF32mY9nFnZzkmSoeevjcwbdU Q1toF9ejI8Au8dzjNV5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i01M5-00020k-OG; Tue, 20 Aug 2019 10:27:09 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i01M2-000201-KI for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 10:27:08 +0000 Received: by mail-lj1-x242.google.com with SMTP id f9so4591764ljc.13 for ; Tue, 20 Aug 2019 03:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e/WL7mt//GAgzwpdMZbthxuFg+kLsllf6TCIqq5cm4k=; b=WRmbYOSuUZTNI+VHX1CcRM/fsEMSBDx0RvKKzmF0CBEnfGFQy4jwdRNLy7jlnI71Jx vpVfv1RUwcWCx6BY0Ww4yUiLIZW59Ks6mcyBJ/34UhiYcaCJMg0H2VxEQ4C77ZKH7OwI e1SvT7JJBct7l227/+DWqKgkSjG2K/bPFJGXSqOqyc5Z/GHZs7xizq/yrtYTa6vdpiBw vA3CPiGHNyD/M6Mx1CZtmQUaQ76xIgOYo2G5FmdW5bYPaMkF86DVU+QXZY26Hjj5yoKb 077WUHbNXzbP2drPoIpP83IgyXznGU7ZNCatF/K1XShzcm8Cfj2hr5QISGBqHSCZt91P xkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e/WL7mt//GAgzwpdMZbthxuFg+kLsllf6TCIqq5cm4k=; b=dWxbI03d7yqM2MvFW06dbWaYG0f3nGZPCfzq6k4dqRPgh98iwKG3/TNJjtmN1XyHN9 yWb2z8/KQejJN1K8j1FOTqPUPLvJbaEpdf0/1QUS4q/KCxsC1YBdid0w0ktb185d2YDy xw16vhSrK8TFyWu42AQBQr5KWOsu07Q9lAPPxzTdDtk9MX5ynHcxL1EHe30HDWuGvb3i Jync6JJHWidKUhwvTGgdgPf+A6oXc0B3IQ0s2GjR0HxvnUsQdeGWM5m645UPttwV97QC EWfY1H5t9KU3gObnm393UHiOQehf1zxR8mdLhrTx3aiU0S76aBHnTgv0Olrt0l+D3y/o 8/Qw== X-Gm-Message-State: APjAAAVmod47gu+ysmys5PCVwDjIZ7AAF0rLbS9MkQMwVKKv+rx6HpwC Wkkklas1ZXVwgXkl6C2SjCrod+epThlTaU7y2hp6Fg== X-Google-Smtp-Source: APXvYqy9d7CgQvy0ZM0/DSmtHyrZ+R2wFU3tRkdCwr+9kjsIgtuwE4FW7X7VWI/cj5Incxd0Z4l1OHqEHETZ6NI0BN8= X-Received: by 2002:a2e:781a:: with SMTP id t26mr10426093ljc.28.1566296822942; Tue, 20 Aug 2019 03:27:02 -0700 (PDT) MIME-Version: 1.0 References: <1566221225-5170-1-git-send-email-xuwei5@hisilicon.com> In-Reply-To: From: Linus Walleij Date: Tue, 20 Aug 2019 12:26:51 +0200 Message-ID: Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Andy Shevchenko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_032706_698141_A3C9AC64 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Salil Mehta , jinying@hisilicon.com, Tangkunshan , "Liguozhu \(Kenneth\)" , John Garry , "Rafael J. Wysocki" , Linux Kernel Mailing List , Wei Xu , Linuxarm , "open list:GPIO SUBSYSTEM" , Shiju Jose , Shameerali Kolothum Thodi , huangdaode , Jonathan Cameron , Thierry Reding , Mika Westerberg , Zhangyi ac , linux-arm Mailing List , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 20, 2019 at 10:51 AM Andy Shevchenko wrote: > On Tue, Aug 20, 2019 at 10:12 AM Linus Walleij wrote: > > On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko > > wrote: > > Exactly what do you refer to when you want me to > > "re-do the approach for IRQ handling"? Do you mean > > this driver or are you referring to: > > > > commit e0d89728981393b7d694bd3419b7794b9882c92d > > Author: Thierry Reding > > Date: Tue Nov 7 19:15:54 2017 +0100 > > > > gpio: Implement tighter IRQ chip integration > > > > Currently GPIO drivers are required to add the GPIO chip and its > > corresponding IRQ chip separately, which can result in a lot of > > boilerplate. Use the newly introduced struct gpio_irq_chip, embedded in > > struct gpio_chip, that drivers can fill in if they want the GPIO core > > to automatically register the IRQ chip associated with a GPIO chip. > > > > Signed-off-by: Thierry Reding > > Acked-by: Grygorii Strashko > > Signed-off-by: Linus Walleij > > Yes. OK let's fix this mess, it shouldn't be too hard, I've sent a first few patches. > > The problem comes from the problem/mess I am trying to > > clean up in the first place. So if the new way of registering GPIO > > irqchips is not working for ACPI, then we have to fix that instead > > of reverting all attempts to use the new API IMO. > > Sorry for me being impatient and asking for a groundless requests. > I'll help you with cleaning this. Sorry if I sounded harsh :( I just have a bit of panic. I am sure we can fix this, I only recently realized what a headache the new API is going to be if I can't straighten it out and have to keep the old stuff around forever in parallel. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel