From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EFEC6379D for ; Wed, 18 Nov 2020 00:40:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F0C2151B for ; Wed, 18 Nov 2020 00:40:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yvWqS730"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rg9U2K7L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F0C2151B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k38OucegELSCjX2ZraGTV49hL5LNIKMuYaM7+4nfsFY=; b=yvWqS730QseZxN38a866x9EAM dnqxufGRqUD3LoT4zgnb461XODj/ggg9C3smzctLrxy32iMJxr133xpfCFhZFyWM/Fo/8Bs881NIq 57AsfVUaFpAjW2DwBQ5YVsuqh2U7RaiCXWf8sDeF5Ts4yopCk6J6J8K16UHf+u0PRYTewlo7lbwRc /DIG4eK4qjDcw/6wvHr8XTe+DxuaEK9SM+sa/evdpqZekWNRxbG8pMABFo37Oc+C/NIf7vtFuUmii XWLCwLsEvew0pVSz7oK9deSpgD2KKK/mYjrkiD776t5ISY0rts8TCXoTtcC0T65Fs5FvEWoz2oQeJ 5ulZgW8wQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfBW2-0005ZH-Qw; Wed, 18 Nov 2020 00:40:07 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfBW0-0005YH-62 for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 00:40:05 +0000 Received: by mail-lj1-x242.google.com with SMTP id 142so387391ljj.10 for ; Tue, 17 Nov 2020 16:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fpRq5oGbKPQIWf1i8EYl3vqTi7XQsrMlJoxcyJpJKNQ=; b=rg9U2K7Llz1s3ghw9hvLqwjk2o3u9dU95otVL20eLEDgygNZpRsb/sSLWiOeDncl18 Z9ZlnNAKkQYzXBOzoP8p4066v9X8E+lkBlE9K6zlVwaGxNXB2daW6FoM23RSROU0AP+e l5UbRlaxteh1YV4DvoaortMefIJ9vEEfoFqOVkKapvJeO0XXBJa7At0YHa/xREuZGZDx V9cUUvpjLYKaA7j2BQOO5pkaY8eFkiEbNcnQfFo6Qo5a9O1hI5SiBYGhppQTvqSQcgrq PLaOQy/oTp8eDLPhB7EadrlRhfJ6FhdAbcYqUZM2iyYwFlIBD07wyxmXAjPZc08Dn1Yr DaDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fpRq5oGbKPQIWf1i8EYl3vqTi7XQsrMlJoxcyJpJKNQ=; b=odnQCA7ax2kMwIMjPMeZutcgsUTJHR12XnTnXKFDLtUSHmI78OiEI4nq2Jw7iNzIvP jbUuUXsSLmXsOa+bZwIUW/fmgh/w/E4cxKAeuCU/65WNyOUzhjszXxsV20Re6c0DR2Xl FlrRMgMBdfTbbPEKJVf36Q9SvR3fMCLDkcbEzLu9EHW1TW1NkV0dTrjna0YUfNVCUksw kv7HEgjn4WWFRMk5VD7L/J7+Pdjm+iKg0NITS9bt8WYKa9WdMyXQPykmTLWVAPuNzgy1 T1ig0e7OOKymUXiTUGrDmHedLPbKqTfi9UhHP5kxovy4t0VSdx7cV+ti1Mzm6Khn32qo mn+A== X-Gm-Message-State: AOAM533BkCze+qhTSaifzWeOku6Vmyd0Xblvmk+R83HQijUpxxY0Zsef GHPPEm5frCwhbcyGXB0qnUhcH/nfv7QSa9dAy8lmZQ== X-Google-Smtp-Source: ABdhPJwDHv2OLnWaiVJw3Tn/fOTtEHtSJELlqaEXImCpNOkLLD4kW0MqQMaFSXoCNdxMD3ZRlv2kLE3SERO9ndosTTg= X-Received: by 2002:a2e:321a:: with SMTP id y26mr3183401ljy.293.1605660002899; Tue, 17 Nov 2020 16:40:02 -0800 (PST) MIME-Version: 1.0 References: <1605201148-4508-1-git-send-email-srinivas.neeli@xilinx.com> <1605201148-4508-9-git-send-email-srinivas.neeli@xilinx.com> In-Reply-To: <1605201148-4508-9-git-send-email-srinivas.neeli@xilinx.com> From: Linus Walleij Date: Wed, 18 Nov 2020 01:39:52 +0100 Message-ID: Subject: Re: [LINUX PATCH V3 8/9] gpio: gpio-xilinx: Check return value of of_property_read_u32 To: Srinivas Neeli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_194004_267698_4503A9DB X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , sgoud@xilinx.com, Shubhrajyoti Datta , Michal Simek , "linux-kernel@vger.kernel.org" , Robert Hancock , Bartosz Golaszewski , git@xilinx.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > In two different instances the return value of "of_property_read_u32" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "check_return" > Signed-off-by: Srinivas Neeli Patch applied. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel