From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDCEC2D0EF for ; Fri, 17 Apr 2020 20:27:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75B8420724 for ; Fri, 17 Apr 2020 20:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NVvknB+b"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GF/O9I9Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75B8420724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aSZGzWqBui2a3AUnp+eQPAeDAXPsZ4Uphy4Lti0N5eo=; b=NVvknB+b7e2cTX qQ8NVkiekCLxOWHjUp/eXjZ6tA7ytPd4CSXgSX8QKx69fQhmNhEXvVNpRk3idtkEYdHaV/xMZRnLz gU10Mv7ow8vSUORFyZ0ozGC0zw96efIhAtwOSxpTfhLxOuk9KT5eYjNAJeOuDdvT0f7fazwvQ0f1f wsus5byayVznnOW4orwbnpjE6UW29kXurZe3oxGPu+Ql/yI5MsORGgYsvjQYKVeby8GvdkmgUjcvm 3uiAtd75BCOwrLJ3F27Zy7N3wH+rh3fXxBBmR4ht66e0Hn2cr2zq4z4y2TjGH3gj6f3iHpzyWewW0 Gcya+ksdSJAy27mWVH6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPXa9-0003Tc-PP; Fri, 17 Apr 2020 20:27:25 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPXa5-0003SQ-Jo for linux-arm-kernel@lists.infradead.org; Fri, 17 Apr 2020 20:27:23 +0000 Received: by mail-lf1-x141.google.com with SMTP id u10so2844881lfo.8 for ; Fri, 17 Apr 2020 13:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sFVeP60ycMsUVn8rAG+W7sV8htYi61dn7Bz9V8tHbJY=; b=GF/O9I9YEBFtOzdDBV7vdlfDMNLjhMF3VMZcgQoGj3iSlXijVXvPwhS8hZoL2iZlIt nWKNoLXNftYapV6G943ffgnn7ikiBhUxuUPMWwlSrD6psFHTM1IscvNzMOKc6I4xbuF2 Ie5q4F7s2pJQE7HTgy7zl457yksbjjXUxyfbUijIxRr0MEJwY1q/yk37G+CGNcPNOsfB tPzCvWq9GitY00yuSE66BE8jW3qSIyfAhHcMiaBEFyXs34oOeebixWQ/HwN/KUCDimUd iW0448Il0Qt5dSdL7E5V2sj0KK8YnAqAmNeMAkA9+U6CvYyGNYf/Ze2MBi4Ji7KKOXP2 D+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sFVeP60ycMsUVn8rAG+W7sV8htYi61dn7Bz9V8tHbJY=; b=BBRAhPTyzE2TOgXVNUmLYpYKckrTzI+i1xPyDl6jCqD86kuc2IsIkBKdyEg+vKj3B/ dIZ5eaoXGOzMMZs8/R7jh4mKb6cblGD5l4tmPYvHche+F2UHozit0E3V/h3taBsSb7Cv KzDJEp67RNF9Jumx3LQo8m9poUZJriZtQSIub6ESVjm5Kr34T3LflY65zyWxWvwfGJTX R8fGl8TwpHxxO+9hVO9ux1cbDeuNk4q9t8atLxAvwzUseZ8TYbgUlprWBOAKTCbtPb1/ J9EjLpcZ7xogjpA+4fzYZ2Th701zqVsCend81rgUZ2jhvS395/qCQeeOeHI/GBU5O2XU VmGQ== X-Gm-Message-State: AGi0PubgxfdCco8DUooCH6x4dehAZz7JMqFJMDBRFftvDvznv47V+OP/ CEMmnI3s523B4YcpBaD+3ZCFOGQ9rSvFMSgJ4ya8FN+G X-Google-Smtp-Source: APiQypIwXsxqULDsgITbS/cOPiGXDq1WRUsu9PtBlGV978qY3TXn8oQz2KBm4oUwDN+6veOIq1QkFziCf4uLCuZoQ68= X-Received: by 2002:a05:6512:685:: with SMTP id t5mr3088797lfe.47.1587155239924; Fri, 17 Apr 2020 13:27:19 -0700 (PDT) MIME-Version: 1.0 References: <20200409013947.12667-1-robh@kernel.org> <20200409013947.12667-4-robh@kernel.org> In-Reply-To: <20200409013947.12667-4-robh@kernel.org> From: Linus Walleij Date: Fri, 17 Apr 2020 22:27:08 +0200 Message-ID: Subject: Re: [PATCH 3/3] drm: pl111: Move VExpress setup into versatile init To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200417_132721_658333_357B0431 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Anholt , "open list:DRM PANEL DRIVERS" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 9, 2020 at 3:39 AM Rob Herring wrote: > Since the VExpress setup in pl111_vexpress.c is now just a single > function call, let's move it into pl111_versatile.c and we can further > simplify pl111_versatile_init() by moving the other pieces for VExpress > into pl111_vexpress_clcd_init(). > > Cc: Eric Anholt > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Rob Herring Yeah that's much nicer, the other boards get a copy of the Vexpress code but it's so little so it doesn't matter and besides the Vexpress already had copies of the other boards init code. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel