From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F07DC43461 for ; Sat, 12 Sep 2020 16:17:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D38020838 for ; Sat, 12 Sep 2020 16:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mdWwHEBG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ik2OaDdz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D38020838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/66r29m2/0/AU3Jckgt8zXfoca/OOSn914TbwJs6tpo=; b=mdWwHEBGKAsMKsl10uGod+97H 3IEbQlQ56lQkuWWe8iAPK5Kl+/Ohda3WGKaQK7wWkit92eBgCgYFJG85KNVLZ9ELxf3MLFbEb9o2M OPbXUtttt7Dwhe7+SXslDPFp+VtwSONDlhWJfg+5b4P+xnDussRL5hK5JSFAWUab0vFS05ORBrzKz QYd+apWn1TSI9sQVRXw0ESGAhtnD23Nt9iRKAz7rivxGwXAJLG+gk3aYr2t4MkU2Nea50eXrbsjDR VkSvGaHy3YhcmkJwxmkyKpFudSGZkTC85heiKadK/0RcGUmHUECJLtyRhemHYWFe33DtklZ57rtHV h9prZMHtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kH8Bm-0007AO-98; Sat, 12 Sep 2020 16:15:46 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kH8Bi-00079y-Cd for linux-arm-kernel@lists.infradead.org; Sat, 12 Sep 2020 16:15:43 +0000 Received: by mail-lf1-x141.google.com with SMTP id b22so5408833lfs.13 for ; Sat, 12 Sep 2020 09:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1mfFSLJ2aT99PDQEJLg63CY2EfFTeT2UQOOCsNtG5XQ=; b=ik2OaDdzUHuVOMNMLsgvQOnL4fvUvEqien4NjpuI5VfIclMzHKWaow1odpvd5sDPJU +LXHDLiPBxR8ThB4sl5aU07BCGyBsQ0CUT5VU6uQyRjR0z/eVMBKV/EafigpOJM2w6fx tUF49I4gg9jJzUNcM/EjXzreHBPpIlb/n4r5NT5TvcdPcNldy6x3TCHdfhOof7EJKQ/u kLZH5q/yNZIk9TzYMtUHe6cNExS56wCEroXgH0iLeRteyVneoKhJ3FbCUEVL5W4iG82t Hyl6zxvpxVVMdWTF4rS9E+pNohfmkBfFjwohofeLq61gNe4dH/KzLBRCSgspSF7nutvm ByUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1mfFSLJ2aT99PDQEJLg63CY2EfFTeT2UQOOCsNtG5XQ=; b=a8D7wWpIbQXtjnfT3e4XWIlh5t9JPTwdEKehSYzoEUi++zSfnwnBEoGmP/+tZij2yd LA2oqDjeTxmRbIo21KuOzA4SE0nbezYR8ftHw4qHhQRrfgNYCf6OJJzbUXa47A5L2fgp FieD/3CTixLwM/2fSJMaenoihOcTl3Un0uU5e3L31qpepthJlgqRahGG4KDNd4+GLoRF pE0LspQu0/ms2AK+XRfknDHaojViOgfZezpTeRueZZHSFNt3Wr2tD8isDjkK+pRd82zo nK7gShpNM2Y0dVaXwWoQxGGNHNfEstB0FBIjVRyUK/Af7CEWIAUbBohaPOgHycIVAdg/ Rc7Q== X-Gm-Message-State: AOAM530dI3IL+vzYYsJxXXldsrc2q/xB2UmLS4rmA376YgWJMUBmWBn+ JcjMYOVArmeq5dkseOpQyg9Cw7CrVyZtD8351nUMLw== X-Google-Smtp-Source: ABdhPJwzk5Ff3ZAWzHOFqk2anJO10WsYhRwbjNzmrZfdwXqXvmayMoWnkftiDhcCyLXCuPFXWkcBZk4GHcnDyvYoRF0= X-Received: by 2002:a05:6512:370b:: with SMTP id z11mr1756518lfr.571.1599927340316; Sat, 12 Sep 2020 09:15:40 -0700 (PDT) MIME-Version: 1.0 References: <20200907211712.9697-1-chris.packham@alliedtelesis.co.nz> <20200907211712.9697-2-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20200907211712.9697-2-chris.packham@alliedtelesis.co.nz> From: Linus Walleij Date: Sat, 12 Sep 2020 18:15:29 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] pinctrl: mvebu: Fix i2c sda definition for 98DX3236 To: Chris Packham X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200912_121542_714156_4122B727 X-CRM114-Status: GOOD ( 11.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Kalyan Kinthada , Jason Cooper , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Gregory Clement , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Rob Herring , Rob Herring , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 7, 2020 at 11:17 PM Chris Packham wrote: > Per the datasheet the i2c functions use MPP_Sel=0x1. They are documented > as using MPP_Sel=0x4 as well but mixing 0x1 and 0x4 is clearly wrong. On > the board tested 0x4 resulted in a non-functioning i2c bus so stick with > 0x1 which works. > > Fixes: d7ae8f8dee7f ("pinctrl: mvebu: pinctrl driver for 98DX3236 SoC") > Signed-off-by: Chris Packham > Reviewed-by: Andrew Lunn This patch 1/3 applied for pin control fixes. Patches 2 & 3 should go via the SoC tree. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel