linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml
@ 2021-05-03 19:50 Corentin Labbe
  2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Corentin Labbe @ 2021-05-03 19:50 UTC (permalink / raw)
  To: alexandre.belloni, a.zummo, linus.walleij, robh+dt, ulli.kroll
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rtc, Corentin Labbe

Converts rtc/faraday,ftrtc01.txt to yaml.
This permits to detect some missing properties: reg, resets, interrupts

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 .../bindings/rtc/faraday,ftrtc010.txt         | 28 ---------
 .../bindings/rtc/faraday,ftrtc010.yaml        | 59 +++++++++++++++++++
 2 files changed, 59 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml

diff --git a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
deleted file mode 100644
index e3938f5e0b6c..000000000000
--- a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-* Faraday Technology FTRTC010 Real Time Clock
-
-This RTC appears in for example the Storlink Gemini family of
-SoCs.
-
-Required properties:
-- compatible : Should be one of:
-  "faraday,ftrtc010"
-  "cortina,gemini-rtc", "faraday,ftrtc010"
-
-Optional properties:
-- clocks: when present should contain clock references to the
-  PCLK and EXTCLK clocks. Faraday calls the later CLK1HZ and
-  says the clock should be 1 Hz, but implementers actually seem
-  to choose different clocks here, like Cortina who chose
-  32768 Hz (a typical low-power clock).
-- clock-names: should name the clocks "PCLK" and "EXTCLK"
-  respectively.
-
-Examples:
-
-rtc@45000000 {
-	compatible = "cortina,gemini-rtc";
-	reg = <0x45000000 0x100>;
-	interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
-	clocks = <&foo 0>, <&foo 1>;
-	clock-names = "PCLK", "EXTCLK";
-};
diff --git a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
new file mode 100644
index 000000000000..6b318650e79f
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/faraday,ftrtc010.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Faraday Technology FTRTC010 Real Time Clock
+
+maintainers:
+  - Linus Walleij <linus.walleij@linaro.org>
+
+description: |
+  This RTC appears in for example the Storlink Gemini family of SoCs.
+
+properties:
+  compatible:
+    oneOf:
+      - const: "faraday,ftrtc010"
+      - items:
+          - const: "cortina,gemini-rtc"
+          - const: "faraday,ftrtc010"
+
+  resets:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 2
+    description: when present should contain clock references to the
+                 PCLK and EXTCLK clocks. Faraday calls the later CLK1HZ and
+                 says the clock should be 1 Hz, but implementers actually seem
+                 to choose different clocks here, like Cortina who chose
+                 32768 Hz (a typical low-power clock).
+
+  clock-names:
+    items:
+      - const: "PCLK"
+      - const: "EXTCLK"
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    rtc@45000000 {
+      compatible = "cortina,gemini-rtc", "faraday,ftrtc010";
+      reg = <0x45000000 0x100>;
+      interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+      clocks = <&foo 0>, <&foo 1>;
+      clock-names = "PCLK", "EXTCLK";
+    };
-- 
2.26.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible
  2021-05-03 19:50 [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Corentin Labbe
@ 2021-05-03 19:50 ` Corentin Labbe
  2021-05-06 10:36   ` Linus Walleij
  2021-05-06 10:34 ` [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Linus Walleij
  2021-05-06 17:45 ` Rob Herring
  2 siblings, 1 reply; 5+ messages in thread
From: Corentin Labbe @ 2021-05-03 19:50 UTC (permalink / raw)
  To: alexandre.belloni, a.zummo, linus.walleij, robh+dt, ulli.kroll
  Cc: devicetree, linux-arm-kernel, linux-kernel, linux-rtc, Corentin Labbe

The rtc compatible was not following the dt-binding.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 arch/arm/boot/dts/gemini.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/gemini.dtsi b/arch/arm/boot/dts/gemini.dtsi
index 9b4e5cf0ff5c..46071b46418a 100644
--- a/arch/arm/boot/dts/gemini.dtsi
+++ b/arch/arm/boot/dts/gemini.dtsi
@@ -191,7 +191,7 @@ timer@43000000 {
 		};
 
 		rtc@45000000 {
-			compatible = "cortina,gemini-rtc";
+			compatible = "cortina,gemini-rtc", "faraday,ftrtc010";
 			reg = <0x45000000 0x100>;
 			interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
 			resets = <&syscon GEMINI_RESET_RTC>;
-- 
2.26.3


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml
  2021-05-03 19:50 [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Corentin Labbe
  2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
@ 2021-05-06 10:34 ` Linus Walleij
  2021-05-06 17:45 ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2021-05-06 10:34 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Alexandre Belloni, Alessandro Zummo, Rob Herring,
	Hans Ulli Kroll,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux ARM, linux-kernel, linux-rtc

On Mon, May 3, 2021 at 9:50 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> Converts rtc/faraday,ftrtc01.txt to yaml.
> This permits to detect some missing properties: reg, resets, interrupts
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Thanks for doing this, LGTM
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible
  2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
@ 2021-05-06 10:36   ` Linus Walleij
  0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2021-05-06 10:36 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Alexandre Belloni, Alessandro Zummo, Rob Herring,
	Hans Ulli Kroll,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Linux ARM, linux-kernel, linux-rtc

On Mon, May 3, 2021 at 9:50 PM Corentin Labbe <clabbe@baylibre.com> wrote:

> The rtc compatible was not following the dt-binding.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Patch applied!

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml
  2021-05-03 19:50 [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Corentin Labbe
  2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
  2021-05-06 10:34 ` [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Linus Walleij
@ 2021-05-06 17:45 ` Rob Herring
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2021-05-06 17:45 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: alexandre.belloni, a.zummo, linus.walleij, ulli.kroll,
	devicetree, linux-arm-kernel, linux-kernel, linux-rtc

On Mon, May 03, 2021 at 07:50:47PM +0000, Corentin Labbe wrote:
> Converts rtc/faraday,ftrtc01.txt to yaml.
> This permits to detect some missing properties: reg, resets, interrupts
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  .../bindings/rtc/faraday,ftrtc010.txt         | 28 ---------
>  .../bindings/rtc/faraday,ftrtc010.yaml        | 59 +++++++++++++++++++
>  2 files changed, 59 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.txt
>  create mode 100644 Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml


> diff --git a/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
> new file mode 100644
> index 000000000000..6b318650e79f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/faraday,ftrtc010.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/faraday,ftrtc010.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Faraday Technology FTRTC010 Real Time Clock
> +
> +maintainers:
> +  - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: |
> +  This RTC appears in for example the Storlink Gemini family of SoCs.
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - const: "faraday,ftrtc010"
> +      - items:
> +          - const: "cortina,gemini-rtc"
> +          - const: "faraday,ftrtc010"

Drop quotes.

> +
> +  resets:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 2
> +    description: when present should contain clock references to the
> +                 PCLK and EXTCLK clocks. Faraday calls the later CLK1HZ and
> +                 says the clock should be 1 Hz, but implementers actually seem
> +                 to choose different clocks here, like Cortina who chose
> +                 32768 Hz (a typical low-power clock).

Normal formatting is 2 space indent.

Split to use 'items' like PCI.

> +
> +  clock-names:
> +    items:
> +      - const: "PCLK"
> +      - const: "EXTCLK"
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    rtc@45000000 {
> +      compatible = "cortina,gemini-rtc", "faraday,ftrtc010";
> +      reg = <0x45000000 0x100>;
> +      interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> +      clocks = <&foo 0>, <&foo 1>;
> +      clock-names = "PCLK", "EXTCLK";
> +    };
> -- 
> 2.26.3
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-05-06 17:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 19:50 [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Corentin Labbe
2021-05-03 19:50 ` [PATCH 2/2] ARM: dts: gemini: use the right rtc compatible Corentin Labbe
2021-05-06 10:36   ` Linus Walleij
2021-05-06 10:34 ` [PATCH 1/2] dt-bindings: convert rtc/faraday,ftrtc01 to yaml Linus Walleij
2021-05-06 17:45 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).