From: Linus Walleij <linus.walleij@linaro.org>
To: Ryan.Wanner@microchip.com
Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, ludovic.desroches@microchip.com,
claudiu.beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] pinctrl:at91-pio4:add support for pullup/down
Date: Mon, 17 Oct 2022 11:52:24 +0200 [thread overview]
Message-ID: <CACRpkdZv0_E8o4ctYr+UEsQG8XqnFATq6jXmKTrbyWh4WJfz+A@mail.gmail.com> (raw)
In-Reply-To: <20221007151647.98222-1-Ryan.Wanner@microchip.com>
On Fri, Oct 7, 2022 at 5:16 PM <Ryan.Wanner@microchip.com> wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> This patch set adds support for pull up/down pinctl configuration.
> The implementation is based off of other pinctl drivers that have
> implemented line bias configurations.
>
> The second patch addes a case for PIN_CONFIG_PERSIST_STATE
> this shows up becuse the gpiod api passes this into the new config_set
> function that was just implemented. Looking at other drivers like TI
> driver, added the ENOTSUPP to the switch case for that state flag.
>
> How this was tested was by using a gpio program that I created to test
> configuration from userspace. This program was run in the
> background using & then using gpioinfo function checked if the change
> has been detected by the gpiod api. Then using devmem reading the
> regester making sure that the correct bit was set. The registers where
> checked before and during the program is being run, making sure the
> change happens.
>
> In the program Pin 127 would be passed into the test program. Before
> the program was ran devmem for pin 127 config register. After
> the progam is running in the background devmem for the same status
> register is called, the result is showing the change in pinconfig.
> The device used to test was the SAMA5D27_som1_ek.
>
> Ryan Wanner (2):
> pinctrl: at91-pio4: Add configuration to userspace
> pinctrl: at91-pio4: Add persist state case in config
Patches applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-17 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 15:16 [PATCH 0/2] pinctrl:at91-pio4:add support for pullup/down Ryan.Wanner
2022-10-07 15:16 ` [PATCH 1/2] pinctrl: at91-pio4: Add configuration to userspace Ryan.Wanner
2022-10-10 9:13 ` Nicolas Ferre
2022-10-07 15:16 ` [PATCH 2/2] pinctrl: at91-pio4: Add persist state case in config Ryan.Wanner
2022-10-10 9:08 ` Nicolas Ferre
2022-10-10 9:11 ` [PATCH 0/2] pinctrl:at91-pio4:add support for pullup/down Nicolas Ferre
2022-10-17 9:52 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZv0_E8o4ctYr+UEsQG8XqnFATq6jXmKTrbyWh4WJfz+A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).