From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42F4C56202 for ; Tue, 17 Nov 2020 23:54:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 709072072C for ; Tue, 17 Nov 2020 23:54:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="B42cnuCG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iVCmJqXe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 709072072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SOfJv7vCHfSDYXscTSZhvflHj/H7RqB3crr+QM3SauI=; b=B42cnuCGi+6Wim6d410gY1e10 4dbuI9KZ/RTyd9sx1eID9TRDrChQYHtlAVLs7/sWPu5IjVzHoYfMKSwP/DXJ+Orbdnnr1oqJ34upk M5Xx34nzE/9SPQyH/XvccUl/N/OvklVP2GXwDrc8dsUvSbdncSGupw1tFOPmyhp5Ctm62VIoklKUe ENf8cCCJQhj75v2jP/5GtDQTexAmxmwsjKM+pcW8pNsjn/zp5mru4xiUrg6QfGriAp8twij0yHxYu CuDJIkvK6exHZXs/9bjx6Dybf9MpBO/SkPU8fikj8z7jdqsXID5tiDDHOBUUjIqOoFcZ6mT5YQmvU jQhjty8mw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfAnC-0002Pt-8K; Tue, 17 Nov 2020 23:53:46 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfAn9-0002PD-Em for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 23:53:44 +0000 Received: by mail-lj1-x242.google.com with SMTP id y16so341828ljk.1 for ; Tue, 17 Nov 2020 15:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wR6pEgT8ea+4PXfS6Cl91lk2j5DaVF587c8uhOkMLUc=; b=iVCmJqXeEPc2JjvsRxcSv5A17qafx4HABWp++wblXI2YYNDDDZ/ZHUKXSQOijJZIJf Tc1KLUYTLjR8TRtZ/DlXricdKOPfUJkJS+hCxtqAOmasp1x5Ir8rYJ9h73T1m7v5jvMN 5073JdB5qqx3Z/+PTqoZMfKwX7zoLlq+Q6qkByBwKAITpklvcnJs9aY9W+/DRpU5co+E 3OtYgh4aYK6+sE4xkERXGkDLf8dAvx1gdPbY4LZmOYEbLSX65fS25lq+i0cS3u1vUrc4 03u3t/kW2gGyIFTH2NjVrgAgzd9Djm6D1qKEG9yat8+tzuk7ripYIzZk5A179YvXZzRB 9kgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wR6pEgT8ea+4PXfS6Cl91lk2j5DaVF587c8uhOkMLUc=; b=kCFSu1QoNmao6au0P/4c8VAWul3kziIgUxXh9XPOMqJpm6TBEaGfaH7x7Q3E17FOmi /NzjEcnY45cYmFa3x+2yafk9SwHnGIAeCr73Xj6ik08hy0Fl6Td2Eil/uNiXhmbG2086 BCSM0AN4oggSWfbcUGVMyFdqjnzst9gXIsR4RCS7GOCx1lixuBEFMCa+RqRY57nMRUUY BtkpTRUGGdeWmiYX65eEUUVrJrEVLMAv4r9RS77P2ICfwRSLdxOrqoO26qtT0f3GubzS v5M8LHGc4OwYgiBWnHZb6sDdV0sUQuZP2nFTz5+qn3XESGMrj3fVs1jE+P/jdRZW5+fg Hrkw== X-Gm-Message-State: AOAM531SLFNmj8jtpxAlYHIM/raJucGp+duPoOmOoXNeKA5xTapRNjJr sgru6FsomURwMJd7OlOYGS+s6stq/Z227k5hyHGWvQ== X-Google-Smtp-Source: ABdhPJxVerKoELJoLFw2Zm47eOboQQzJCqKWTSE2LY1wr8SyHdtlKfBXYRWbtRwr62j0DBRG73M+pSuHQHjVJ7HABJ4= X-Received: by 2002:a2e:7c03:: with SMTP id x3mr2556090ljc.338.1605657221141; Tue, 17 Nov 2020 15:53:41 -0800 (PST) MIME-Version: 1.0 References: <1605201148-4508-1-git-send-email-srinivas.neeli@xilinx.com> <1605201148-4508-4-git-send-email-srinivas.neeli@xilinx.com> In-Reply-To: <1605201148-4508-4-git-send-email-srinivas.neeli@xilinx.com> From: Linus Walleij Date: Wed, 18 Nov 2020 00:53:30 +0100 Message-ID: Subject: Re: [LINUX PATCH V3 3/9] gpio: gpio-xilinx: Add clock support To: Srinivas Neeli X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_185343_512826_9739429E X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , sgoud@xilinx.com, Shubhrajyoti Datta , Michal Simek , "linux-kernel@vger.kernel.org" , Robert Hancock , Bartosz Golaszewski , git@xilinx.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli wrote: > Adds clock support to the Xilinx GPIO driver. > > Signed-off-by: Srinivas Neeli (...) > + chip->clk = devm_clk_get_optional(&pdev->dev, NULL); > + if (IS_ERR(chip->clk)) { > + if (PTR_ERR(chip->clk) != -EPROBE_DEFER) > + dev_dbg(&pdev->dev, "Input clock not found\n"); > + return PTR_ERR(chip->clk); > + } You can now use return dev_err_probe(dev, ret, "failed to get clock\n"); to avoid all the comparing with -EPROBE_DEFER. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel