From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28077C433DF for ; Mon, 25 May 2020 12:24:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F21002084C for ; Mon, 25 May 2020 12:24:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DFH1Zuiu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mHchiWv9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F21002084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sWjbZuQ1iEzSH45UiPo854qNzPLBPPlnRSqPYFy0j/g=; b=DFH1ZuiusV+S7Z CiqCYhKSLc64tw11+3JjhHzeQPec1EQyECKrggPVUI23LWxL6PCC4ElbuUGx3dAT2FntMzJqQxrat MW0pTcPhhqK5HiB16BIzWsT6yHpCFe7JJ5cUZbmxSQG0hHpALUv/GJHubmu6WVj/LCFH5FRUbgZUV 4DYaQBmk60yMKr77Y9ypTR2ZL/PvmxxT9as7rEFaP7GEHt6SiDdrXtAKGTS0PB1fIo0pPo/0RwTEJ E7DuUzK1OaWrEgSLuAelCfcL/QSDDYmEvgd2/Fqql34llmXggfLyFsJEyDHy6VYOvA8h/8PTDeopV rwEqojAVhahW4R+DUC6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdC9A-0005pC-EV; Mon, 25 May 2020 12:24:00 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdC96-0005o5-DC for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 12:23:59 +0000 Received: by mail-lj1-x244.google.com with SMTP id w10so20603890ljo.0 for ; Mon, 25 May 2020 05:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1neDSVvo2exAwO7XG1Q7asHC8C/uLbtbXAanu+QhUvY=; b=mHchiWv9d+bl7TypEyswUYJoJBznRNEzkaqNXJ6yZYcwVhCmDlHeQE5uaH/HclG1/A Bx4Cg9tDzYVicfaKmVDBhYVOUgLefRTuPj7YFVjqzZ8YnTP/1LLLJTykYqXl+FHN2pZL g8xP1m6SXMaHEiGtmqiEB2IP7G+kpZcs9VS8hZv85N+n3X6CdpddRhU6y1nCKsAQzFCY 4rfmeLIz/oOwhxkepv8pd1oS85BdwpikntEpMCfo0gVE3d09pfC4AhwFL/nAFV+L4+Zb mwcQqn4CqSg3gj+nOH2kk2AibQMFcCPYOzlGhx/9SXJpErxweRkVif+GCa4LGQO8gvT9 9trw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1neDSVvo2exAwO7XG1Q7asHC8C/uLbtbXAanu+QhUvY=; b=JcJMtUcVmQWd/l1KKbEsSRq+JlUw0mVOFIIhLUQOqTYxpBZiMcICoKkYmDG4RnxUZo EWlbSh7CQ41/+dWKPekcTflS1/sCIz8jXey0vlwwl5mXrWF+J+fBYW1Fsju24ztPWTSh zN0qv6aprTycM1gPMb2fhjOjIHJCIStq3rr72oiNI+mvCGNXS0SPHC98zrH8oski+4Tg Pfyg+5vAgglc48EKJqecTuLFP12RHN3jcdR6qAPg3mX4D7Rj+UAXz1SB7YmdwPf1pa3C SJUmhhY+1xUmTIQyaath/o/p3emdZSbcnDByVtaMO0ubzBmgqtbl5+kOJ9qJ80RswOAS Dg0A== X-Gm-Message-State: AOAM531sbg9uRWUEouP2CLysqhK/vN7Oicd+sDirxS/38qihOWy6yFq8 lBQfF2b8qMR+KdxOSo4laQrLE/jZQCZ9nxzGNg+90A== X-Google-Smtp-Source: ABdhPJyf5wZA8Fh7xQjtaNnLLHBTpAkEbLAQIKhyb7JglaMhaJDSU7UOMtER0/cndL74Gsc/vcIt53XFGmKsX5AJ0t0= X-Received: by 2002:a2e:711c:: with SMTP id m28mr13451102ljc.104.1590409434478; Mon, 25 May 2020 05:23:54 -0700 (PDT) MIME-Version: 1.0 References: <1590378348-8115-1-git-send-email-dillon.minfei@gmail.com> <1590378348-8115-7-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1590378348-8115-7-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Mon, 25 May 2020 14:23:43 +0200 Message-ID: Subject: Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver To: dillon min X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_052357_838574_4BA08E22 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-spi , Mark Brown , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 25, 2020 at 5:46 AM wrote: > From: dillon min > > This driver combine tiny/ili9341.c mipi_dbi_interface driver > with mipi_dpi_interface driver, can support ili9341 with serial > mode or parallel rgb interface mode by register configuration. > > Changes since V3: > > accoding to Linus Walleij's suggestion. > 1 add more comments to driver. > 2 reduce magic number usage in the driver. > 3 move panel configuration from common place to system configuration. > 4 reuse MIPI_DCS_* as more as possible. > > Signed-off-by: dillon min This looks good to me! Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel