From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54685C433B4 for ; Wed, 5 May 2021 23:58:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3C41611C0 for ; Wed, 5 May 2021 23:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3C41611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U6Zdgj7jwrHp7t3MZm8CY63pZuHVb7M31KyOGWKGOM0=; b=q8CCM/6q/Jz11D2endl/d6RzD lRBxMSpz3y0bjV31R95jf4NRSAvteE6Wl3TfRTxnThGGAHJrQeymlfzqBlTZMQdpoEvIr557X3rPX llKS3mBHFtPZx6hQruAK71JPOKmjEg13K07GTgVklxtcY8MD8FCCAsEqPG7tZGNGeGca30VZX/K6l XGD2zaOQ5cOv+LSUITir42IyixJmdmbEsBvL9hXkxlYFufq8x+DI7sRmuzwf11SJ3Nug79OGG3N/u D3HAUPVv0Ntn6MiyteH8A5XFM2KxQQPfJ2n2zvo49p2hmSIYxarBT6nSdVjrkxVrfwrYUcGbtcthn YnnaB8yhg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leRNp-002eNv-6R; Wed, 05 May 2021 23:56:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRNl-002eNi-9V for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 23:56:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fw7QXJGTsrjr3zuPRgQiAU7U58qxLFo5Weq3W8UeAIk=; b=guHH3BZAKtaVX8MjjhHdmOyXJq Z6Y80CUlVFu98EY9iv5A37Mjc9v+tmC9kX1s32xQ8HZJ4n687YZnQyRd0JXPrxKCzjsexxo/3XDrr 5EYTfgbBROLdZz13JHh4aX3nJRjawDOtdEnnoOqgURN2/6koBzob9WUqyFhUOJq4VQS1TVh5lp7gZ C/aOMzFR9p45rw3IVgPxUgpgpyi/UzIvCItKtdRusGrWMxHShc9wGQh+zSFd59J31FbjVg8uCMpWN j15wMVuLFvz0H9SZkffuzuQyqt2YG11uzmJ7hdw5ilTa4v+kgv3QT8QXUmiMVa/ySLJBDG3d8t/gx EH2j8y4w==; Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leRNi-005Pj5-DE for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 23:56:43 +0000 Received: by mail-lj1-x22c.google.com with SMTP id b21so4694792ljf.11 for ; Wed, 05 May 2021 16:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fw7QXJGTsrjr3zuPRgQiAU7U58qxLFo5Weq3W8UeAIk=; b=NVEql6v3DLZu4uHy44aAXvAF4LKSO9D6LCN+nDL+InoVa0ZnV1vRTtG+SsFmuV0QqB 4BSDGNktTU+3A3h8U6l/Vp7DAhP1th8AWeV6M1rvJRRbdQ+iiDEPEDQThqlWMNyE0Ag1 jaLWjeLQqwnymNeggNv/fXGKlMZ5bFZ6THEfZAhkoRoF97dBi184VEHi72L/6AM/oxJO XOmOUpauKpB1/Vjl4V54rBcWkLEQtJVDc4VwFV420p8p5yNSHUdKLeoCm9PzFcRFloPv GOVl7YBs1aXCD3cBdbLYqFNWI3wcI1DHaREI5QOFRSlG95oCsY9gDoOcGn1nZqjnRfUd UY2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fw7QXJGTsrjr3zuPRgQiAU7U58qxLFo5Weq3W8UeAIk=; b=dudNpDM0jvaUiMhJCqs46QLW4Y3JMjCD7mRiS02sveT058jQA8uJVQE1kB/nLhsPt4 UjJ5QE+E/X0NFbayH3tfd3LN1okMIocxfhgmQ8IBA0w3GEW18EbUObxNyfiZ/dNRtqZM 0pvjQ7opDT9UrjB8ciXIY8TmBegHYbdrGCAQ/YtzTIK9oXhheQ1d3ccVhuMxhu6579YG akxSUkzCnuhNR/RTbW1ro4xrdXfw5ZgsHbGDWS0SB7HgK1Se1M3YPMLRtvYpGmkB4WSF wLmue1JkLo+YhfL3syU16kT2vColNXJXwhjJAGnvdIBtcWFF5dAUBS2egSbWgzKi7f49 8Qhg== X-Gm-Message-State: AOAM532nMPDADNiAtFSQleSC3ROdCqeHcrzs41bommn2L+uZBaqDNdf4 zwITQOegnRCvz+GtznwbdN9KU2K2GS8beT9RSVne0Q== X-Google-Smtp-Source: ABdhPJy++qgGBoHXV7D8jU9no39eQo/Mg+p/IwsWGvgwYxsds9fL8Il97amaN3rdoofggSAL07oM53Jq81g9mJv+OBo= X-Received: by 2002:a2e:814d:: with SMTP id t13mr922707ljg.467.1620258999642; Wed, 05 May 2021 16:56:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 6 May 2021 01:56:28 +0200 Message-ID: Subject: Re: gemini: sl3516: Mainlining of NS 2502 To: Corentin Labbe Cc: Hans Ulli Kroll , Linux ARM , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_165642_502206_06784E07 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Corentin, I will check the patches you posted too, sorry for being a bit busy with some merge window and stuff. On Wed, May 5, 2021 at 9:26 PM Corentin Labbe wrote: > It seems that USB is still a bit buggy, device are detected only if plugged before boot. Yeah :/ I don't know that driver very well, only that others use it too so there might be some people who can help. I haven't mainlined that patch because there is something that seems wrong about it but I'm not a USB guy. > I hit a problem on the NS2502, sata drives does not work well: (...) > It seems a problem soon after driver probe (qc timeout and HPA error). > Any idea ? > > The SATA works well on my other board (SSI1328) > having one or two disk does not change the behavour. Could be the SATA muxing, this thing in your device tree: sata: sata@46000000 { cortina,gemini-ata-muxmode = <0>; cortina,gemini-enable-sata-bridge; status = "okay"; }; cortina,gemini-ata-muxmode should be 3 for two harddisks I think. If that is correct then check if DMA is broken like on SQ201, see drivers/ata/pata_ftide010.c and here: /* This device has broken DMA, only PIO works */ if (of_machine_is_compatible("itian,sq201")) { pi->mwdma_mask = 0; pi->udma_mask = 0; } This had to be explicitly disabled for SQ201 to work and I guess it must be broken electronics design (too long leads, interference...) so try to put the compatible for your board in there and see if the drive starts working. You should be able to check the source code of the vendor tree to see if they also turned off DMA, if they did then that is a certain sign it has the same bug so you should make a patch for it. Maybe it should rather be some "disable-dma" flag in the DT node, the above is a bit ugly but works. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel