archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <>
To: Zhiyong Tao <>
Cc: Rob Herring <>,
	Mark Rutland <>,
	 Matthias Brugger <>,
	Sean Wang <>,,,
	 huang eddie <>,
	Biao Huang <>,
	 Hongzhou Yang <>,
	Sean Wang <>,
	linux-kernel <>,
	 Linux ARM <>,
	 "moderated list:ARM/Mediatek SoC support"
	"open list:GPIO SUBSYSTEM" <>
Subject: Re: [PATCH v7] pinctrl: mediatek: add rsel setting on MT8195
Date: Wed, 19 May 2021 02:09:45 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Apr 26, 2021 at 4:45 AM Zhiyong Tao <> wrote:

> This patch provides rsel setting on MT8195.
> Signed-off-by: Zhiyong Tao <>

I am suspicious about this patch, sorry for taking so long to answer.

First explain what "rsel" means, because with no explanation I
suspect it means "rail select" which is what we already have the
existing generic property PIN_CONFIG_POWER_SOURCE
and power-source = <> in DT for.

Also add the custom properties to:
(separate patch)

Linus Walleij

linux-arm-kernel mailing list

  reply	other threads:[~2021-05-19  0:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  2:45 [PATCH v7 0/1] Mediatek pinctrl patch on mt8195 Zhiyong Tao
2021-04-26  2:45 ` [PATCH v7] pinctrl: mediatek: add rsel setting on MT8195 Zhiyong Tao
2021-05-19  0:09   ` Linus Walleij [this message]
2021-07-22  8:22     ` zhiyong tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).