From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0928C433ED for ; Wed, 19 May 2021 00:12:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44DBC6100A for ; Wed, 19 May 2021 00:12:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44DBC6100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QCdjlYVhRNfsVg2hXGEu1J1uaZSAaiQat7x/5jhXlVA=; b=V7NC4I4YtJLl3Rlzv4yyw4rVM dnW0rX8NXoJdhhFVrTbHG6CPRZ2KyHf+ArJ5dDOfNJIRzQgcDXMiVs4Ux3+kC7sEiyTOPBcOoxw/G Kr2DRyv2HlaiR4j7Jtf9vOahXSLhFehRk5Q16FzsBvegB8BRyT+pYEBytBcTrEvAwE1+Fr6QGTPYF sz1T7oCeViVHo4Lj1/QQylWjTwO9cr+3yYllNK5Vl6pu5LSaGOCReEQCzDjjX5xHg00zrTkpKYCgf 2Kb8KDj63IPxlvPzl2F4PRJQ/V8hXvoQhAqGVDd8io84s1IYTUq9LsK48Jg8v9rvPpfn15pSVd7l7 zABs7zWlQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj9mr-002Ebq-Ur; Wed, 19 May 2021 00:10:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9mj-002EaV-Q5 for linux-arm-kernel@desiato.infradead.org; Wed, 19 May 2021 00:10:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OuTM33XGtLwqa8MYciwrkAYfeQ5kekKTaJ8lI00J+rs=; b=bxG0WR97t1sARHSB6rrCkQm4ZB nu9g3oM+8A+tcMI6maL++pE5Kpu5TsWctYGGbQNLD/U1dlPzkF1fFYVKwS6dQd13xjPWVV7aBpVWq 9T7xmJhXoRbgmAkxHzfIJs7ml093oB8OLFO0QjcHdInynJsvbg9aEmmny3xm+zbWM+jGMECO6Rzo5 NWll+EuRnQFeypup72dD1hUX0qWmGU1lhk5jVap03XkVUiM6N0oCbwt5KdTPbO4ZLxL76VZPozPv2 R0pDU549WW5W7kJxMuDgw4exkXrwWVyZRQ+CeK3hVTvUhrt2QmHReLl9WZ3lFeU3XkFNxT4hG84Dz YM2pHzfQ==; Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9mh-00F2OR-1N for linux-arm-kernel@lists.infradead.org; Wed, 19 May 2021 00:10:00 +0000 Received: by mail-lf1-x132.google.com with SMTP id i22so16239379lfl.10 for ; Tue, 18 May 2021 17:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OuTM33XGtLwqa8MYciwrkAYfeQ5kekKTaJ8lI00J+rs=; b=h8O4DrZRkEIKrl/XUr78Ts7Z+5uTUkSBm2b+5q8n1o1rP5eMEsqe3JLY0RoalrthmN hFx904A+BhryeG5r014WnM3Ppb3ppkCbzLzH2yCCxevVIGIPrbxabKc4WEHvr1hDjdWq L/LVrgMDOlTc5LLNV02Y5nFswYHoZ5VQBrw1jc/Tr9If50zwJx+P5Y1yCzBki5O9QmoV jpsuQe/Le47+ZzAJ/OtWbMAAmrQXUAz2S+vcQfsEzEf0wfD0P5OU6toS75gEFj6v1Ew9 9iBMry8hXEIvXdyzwh28L1Lk442e7oC4GWrHMsdBUKtvG15pRphJ+Qpmq6lB9ynjNzuZ ZBnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OuTM33XGtLwqa8MYciwrkAYfeQ5kekKTaJ8lI00J+rs=; b=Z5wOmT4N29nxwOSTcl9RHwbojO4K9ya6IkJUsgvQF4v8MGkADXFLVCwMZoqbEy+t99 TMMITzxyG1s65bHunWNgiiNQUSTu6HSl9mDKtz+16yEcGTkjLdDBGdgqvGYjmuq/Zp50 nJX+iCj8rSp5sHgDQGOVpOX07F87ZWgyoBxSGGD14E2f+fH5z3lp1e+9w73AENfoyhzl zGg2NOgNHFFAfiilcwWhY1uYx7c+crlmpOpCmas7jqEbvAjprXCGc8TfTeftZgMe+szl NxkW4IoRiB7m1+8LBnGj1v/5a+pyaFAtGv3HD1ZEJCDswPZoL+Qbr70wmxj1KiHgaKWI avVA== X-Gm-Message-State: AOAM5322soze1PnIJv561c2dUUnA5Kw0n3axhUSVHlE7U3A3TbIa+WUu OzKhbA0LeOVY3B1S5GLHEQ8z9mPb7RJk7pH1BwtppA== X-Google-Smtp-Source: ABdhPJzXvwNyBIFBAGkgV+vqz4OfOm7bjiZHvKaE/3qxTD4SKunmkPBqDuIYym7TgM9jIoYc0T7bA2xvseQYyURg98U= X-Received: by 2002:a19:b0b:: with SMTP id 11mr5814348lfl.291.1621382997090; Tue, 18 May 2021 17:09:57 -0700 (PDT) MIME-Version: 1.0 References: <20210426024533.20840-1-zhiyong.tao@mediatek.com> <20210426024533.20840-2-zhiyong.tao@mediatek.com> In-Reply-To: <20210426024533.20840-2-zhiyong.tao@mediatek.com> From: Linus Walleij Date: Wed, 19 May 2021 02:09:45 +0200 Message-ID: Subject: Re: [PATCH v7] pinctrl: mediatek: add rsel setting on MT8195 To: Zhiyong Tao Cc: Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream@mediatek.com, hui.liu@mediatek.com, huang eddie , Biao Huang , Hongzhou Yang , Sean Wang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , Linux ARM , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_170959_211767_027342FA X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 26, 2021 at 4:45 AM Zhiyong Tao wrote: > This patch provides rsel setting on MT8195. > > Signed-off-by: Zhiyong Tao I am suspicious about this patch, sorry for taking so long to answer. First explain what "rsel" means, because with no explanation I suspect it means "rail select" which is what we already have the existing generic property PIN_CONFIG_POWER_SOURCE and power-source = <> in DT for. Also add the custom properties to: Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml (separate patch) Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel