From: Linus Walleij <linus.walleij@linaro.org>
To: Victor Hassan <victor@allwinnertech.com>
Cc: linux@armlinux.org.uk, rmk+kernel@armlinux.org.uk,
yanfei.xu@windriver.com, ardb@kernel.org, tglx@linutronix.de,
mirq-linux@rere.qmqm.pl, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
allwinner-opensource-support@allwinnertech.com
Subject: Re: [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug
Date: Mon, 18 Apr 2022 01:21:10 +0200 [thread overview]
Message-ID: <CACRpkdabVpD8fQYowCFibdc-r7of6JQnUJAeo0Quqg=cCuOjAQ@mail.gmail.com> (raw)
In-Reply-To: <20220316023356.120595-1-victor@allwinnertech.com>
On Wed, Mar 16, 2022 at 3:33 AM Victor Hassan <victor@allwinnertech.com> wrote:
> earlycon uses fixmap to create a memory map,
> So we need to close earlycon before closing fixmap,
> otherwise printk will access illegal addresses.
> After creating a new memory map, we open earlycon again.
>
> Signed-off-by: Victor Hassan <victor@allwinnertech.com>
I think noone really noticed this because everyone on Arm systems
use CONFIG_DEBUG_LL, and that makes printascii hammer out
stuff on the console very early, it even accounts for whether we have
MMU on or not.
How are you using this on Arm even? What system and what serial
driver?
That said, it looks correct.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-17 23:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 2:33 [PATCH] ARM: mmu: fix access to illegal address when using earlycon & memblock=debug Victor Hassan
2022-04-17 23:21 ` Linus Walleij [this message]
2022-04-18 15:08 ` Victor Hassan
2022-06-17 13:30 ` Victor Hassan
2022-06-28 8:34 ` Linus Walleij
[not found] ` <CGME20220831115257eucas1p20d37a01c51e42767860920a936255bd7@eucas1p2.samsung.com>
2022-08-31 11:52 ` Marek Szyprowski
2022-08-31 12:37 ` Victor Hassan
2022-09-01 12:53 ` Victor Hassan
2022-09-01 13:21 ` Rob Herring
2022-09-01 13:49 ` Rob Herring
2022-09-03 8:54 ` Victor Hassan
2022-08-31 13:51 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdabVpD8fQYowCFibdc-r7of6JQnUJAeo0Quqg=cCuOjAQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=allwinner-opensource-support@allwinnertech.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mirq-linux@rere.qmqm.pl \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tglx@linutronix.de \
--cc=victor@allwinnertech.com \
--cc=yanfei.xu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).