From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3718C433ED for ; Sun, 9 May 2021 00:33:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72A146101E for ; Sun, 9 May 2021 00:33:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72A146101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WvRa/nN4hT4dc8ms8XPH7wl3Sov7Z+Iymo/4e6coqtY=; b=XGT8WJ7YFQnlRFnzl7lIArqoZ fw4U6UHSyxeUEwwcObcUyKKq9SKXOSyoB8OlPUQ5Cmn6EyRJJWsLlRle+X3exX2MQbfJPAOnSsDBh TTwENqRysfobLToHSQcOEYee2k9BpnJ7wvQEUIQNijR8bqyLGjUpecagJ2NK6yZgGKNlNfq5JGF/J IT5zaNrEJLmwbhwkWXT1Qsoaom+Hq+OprUVZ7MpvuQYbO/D0l8VRXS/stH0wRvs3MVXylDlPvr1fF JpqafZU6SzM/zn86rKWlsKE+F5pkJcNbRYsUdyMozO5PjI67VI79++HTyNma3ZvLEyzjYWdtnNn8S V7yDlhyLQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfXM4-00Ad4A-RT; Sun, 09 May 2021 00:31:33 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfXIa-00AchV-AA for linux-arm-kernel@desiato.infradead.org; Sun, 09 May 2021 00:28:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sOG7GoczpFfze5AyMT4RluOASRTehzGf0LNWttOKk5c=; b=J3qFFGRbR+/LNZLULQ20mEyYDL OcFJLzKLjtdwKK6q/HENPlTc9vj4x+QQYcj3Oe4BkfE98jy8noaKzQWTg8lnD7KHYTKDK73BQyYTX 8J9ta1p3qa83KDorWcSAPtt0qtlaBXFfoBSAyvNkLlOunIfjS3w/v0FS1ZDxSoGl0IhFNh/6IlZcM 30WXzaO90T2HFKc0W8MA47yHg47hFPibvqGkIduDr96Uo63XBmS5EWx1in0B+KcFno/Gql0mWMiHM P+9P3B0HZ8RQFo0PHvU7nf0/MC3vlaNDQIwISd+0l2gJmymu/UlhBH/ASMNS1QYeaZ7pT/NSshajd JbxGW1MQ==; Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfXIX-007n1r-AP for linux-arm-kernel@lists.infradead.org; Sun, 09 May 2021 00:27:54 +0000 Received: by mail-lj1-x229.google.com with SMTP id b21so16284589ljf.11 for ; Sat, 08 May 2021 17:27:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sOG7GoczpFfze5AyMT4RluOASRTehzGf0LNWttOKk5c=; b=fd/VQghyl1il11WcKIahjTpti38ABPOV+dWJY++N6qi+RgRaK1GW8Sk7C+ltz/7Xga z0doL14X6Ldz+/jney8rR8LcRGt+D2mcXm9tdfOGM6mOugc45rNXotg+pcpI6ZU/Tuex uG4xC2vISLas1g8vYAfDvc/8Vwhd6Rdc/JSw5APFXzlTg+j3aXEKzb2YGGeHPcTbK+Zz qaDpZ7G34rsLW5ylHIuAe5pKPqjvDpmVNXKM8lnDzNkxYjZWOua/S1Cml+oCCo6j343y cKeiz60axq1J9KfnYqCtYJfJxfVXxyJ1JA0Pl6fAzDQdiOBkEMgO3cW4jlJ4Mn16HamA RMng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sOG7GoczpFfze5AyMT4RluOASRTehzGf0LNWttOKk5c=; b=I3EeYB6z15pOVGOJbcubtlJz01lbZUaApiIaow4P3RWmpfQqWo9K14w6LwY0cTQev/ KB4qOJeP1zZdaI0LoZCnwssyEBs9HlumsKohJCRrZ+Kncf/czroNla35dS+7ask0pFLt ELKdIf9O6dXZYpSmkHXWzrlYngd3uT7vD5t9zE4fmWFTk+gLz1k5Xn7P3JPULBss2DNO P64T/ZCDbcVc2YQQ42HzeQyBFIsleKQ+edBu0vt1NmzPbrFSfKMDzR/smKIW5jldaTIS lDaXk1xZgjG6sfNCCzP4flU/9EP3Qd6LN5toJ4IUqyAHTLRhezb3VLEOUw8QmxMNWyhm jvqQ== X-Gm-Message-State: AOAM531MrDuiVdVpiJEOGoYDHRTiLK2ba7/rhKeAFZ+O7CeRKuGI3C0r X1EirUmE1cFibssy2mUmKjxdB8DkVPxseFc6IVYxNA== X-Google-Smtp-Source: ABdhPJytxvCNL0+i08ru81BLLE5rAKxOEzAlmjHrXOhOGfZ4saKKLNoNxxgTYNohihYYlBVogll59unffk6oK9h0E/k= X-Received: by 2002:a2e:22c3:: with SMTP id i186mr5939134lji.273.1620520071392; Sat, 08 May 2021 17:27:51 -0700 (PDT) MIME-Version: 1.0 References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> In-Reply-To: From: Linus Walleij Date: Sun, 9 May 2021 02:27:40 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple, pinctrl To: Mark Kettenis Cc: kettenis@openbsd.org, Krzysztof Kozlowski , Tomasz Figa , Marc Zyngier , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hector Martin , Rob Herring , Linux ARM , "open list:GPIO SUBSYSTEM" , linux-kernel , Bartosz Golaszewski , sven@svenpeter.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210508_172753_388142_94CCC294 X-CRM114-Status: GOOD ( 29.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 9, 2021 at 1:02 AM Mark Kettenis wrote: > [Me] > > On Sat, May 8, 2021 at 4:20 PM Mark Kettenis wrote: > My U-Boot driver is here: Thanks! Looks nice. > > > +description: | > > > + The Apple GPIO controller is a simple combined pin and GPIO controller > > > > spelling > > Not sure I'm seeing a spelling mistake here. Do you want a comma > inserted somewhere? Your original mail says "conroller" but the helpful google mail editor autocorrected the mistake when I hit enter after it. > > So is this an entirely Apple thing now, and not based on some Samsung > > block from S3C like what we have seen before? > > As far as I can tell, yes. This Apple controller has a single > register per pin that controls the muxing and gpio functions, whereas > the S3C controller seems to have 4 registers per pin. Fair enough. > > What I am really wondering is if these interrupts are hierarchical, > > i.e. that they match 1-to-1 to a GPIO line. > > They don't match 1-1. The GPIOs can be assigned to one of > (apparently) 7 interrupt groups. Aha so it is a 1-to-1..* thing. How delicate. > I haven't looked to closely at this > yet since U-Boot doesn't need/use the interrupt capability. But I > suspect that pins don't have to be assigned to a interrupt group and > that explains why there are only 7 interrupt groups as the 8th state > is reserved for "unasigned". The number of pins per controller > varies, but one of them has 212 pins. Wow. > Multiple pins can be assigned to the same interrupt group as far as I > can tell. So in that case the driver will have to look at status > bits. OK then this is not hierarchical. > > Marc Zyngier can probably tell the story of why it is handled > > like this, > > Ok, hopefully Marc can say something sensible here, but I'd say the > interrupts on this hardware are cascaded. Yes looks like so, it will be an interesting interrupt driver when you get to that. I have only the question in my second mail (just sent) but in any case you are not doing anything out of the ordinary (it looks very similar to the STM32) so I'm pleased with this binding. I wanna give the DT reviewers some time to look at it as well but I imagine we can soon merge this. Yours. Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel