From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E04C3A589 for ; Tue, 20 Aug 2019 07:12:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03AE8214DA for ; Tue, 20 Aug 2019 07:12:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BQTJ+3nE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VwuASG2R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03AE8214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2U5KShoJ1RZCnVxP9Dfy/nXb5iYRUAziuivSFmwug9g=; b=BQTJ+3nEFm4ayC 5vqIam5zLJCuff8vCpAqsI+3U4J/dVZF/D2y/cWBVIfv5jkhJVLE1hcjmnN7dX5vJpShKoDLJCWv8 aU3S1BCHKfAhamN9uie1l1WGWeC+0eh/M9JIDgUz67fgTSo+d+McG0PU9tmsnClOjbMcYro1uInSA mz5aVXC1baygee/NHjKqPKkRR9OIAhvcV4njTWTJNNutVy7ATrgBYBEqpMyruI0VcrRJqX5g2ZPbt 902YR35tQm79gNRElf5Xhu1B+VCqSqRo6Yx0p6ldnvk7RyLgP/vumB4GUrwY23SY6nrnYwLBQvGlV 558ru/eehrFb2P99jFxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzyJx-0000Kg-AM; Tue, 20 Aug 2019 07:12:45 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzyJZ-00006L-8h for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2019 07:12:22 +0000 Received: by mail-lj1-x241.google.com with SMTP id l14so4092736ljj.9 for ; Tue, 20 Aug 2019 00:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HHSoqWKZEGvJJ3+or43k3Z7aZ0JM++edMhoQlijfvls=; b=VwuASG2RtKyMhxNLREWp421hmIqGZ521c56swV/Ot1Rmmo369Vat8gqvMuAkadMD6t FmKFqdcsB6UzQT0DifyJW4Z7hm1fVoMPU5RFTlMtdPVX0u6u3sJp34Ib7iQTQo3LBrDx jii1kap3+W20kvr6AHOfLCFFEgML4W9rrcMSXcq0OTNJGMJIjosVGwjzfSDFZjI55zuV HTmpqVNvjrOZUCRcmNf6lHkbvdoO3zzUCVWTq5Zeuiwr8+SjtUmyF1XnyYXGurmr5MSX nHwGFXZTHrXdySpLKbUrZmnA9xXlqVqPxZp08uSHbRmmRiWI6EokTiZBOd37z1KwEN4U ty0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HHSoqWKZEGvJJ3+or43k3Z7aZ0JM++edMhoQlijfvls=; b=Py9qkODO8/GbNDp9Z7LmIObC5FncPxEGq2w5iXE29Kh+HdTWRXSCDF87oEvZg456fl 3tB/lvJHhyVK4tR3OJRAg7ay0xpxtBXIaLZpdzlq7GEDbsSnx4ZhN0Y0tCeo7gNdTH6o h8l8GhEvTahmFkBZzQLWu9iDRXSl+wGqOqVCIdszrk7v7gJGzJfV6d+JUI1Rj4+J8G9P jdy+ZOh6x0Sl82dht+4kEvVXzN8S2AMG9LFKUiGTrwHcFgqa1GXe7b4K434AC2lg9ECq Jgo3NaMoC0pyORbasx+LUrv7li8uH0KylIW6HdhsXPXPGSk3sGDt99sKEK6BJCBYWEt+ bwvw== X-Gm-Message-State: APjAAAVeMHkUORc3WxrEkF2ROxUY5htNfbnDDI3D9P4PNttSflZBNs3+ MfxsHtWv9NPh3G0QWnrhM/3j9+DQ9NjZ58CDNvxpnA== X-Google-Smtp-Source: APXvYqzvOU/pXCt+Y4om2H2xOwRjllpQArHaRTouxDBCQgr1luDhMaWUq5i1R1z6lbicAftr6o4Jr+oiaQox7/zjQ3Y= X-Received: by 2002:a05:651c:28c:: with SMTP id b12mr14924495ljo.69.1566285136324; Tue, 20 Aug 2019 00:12:16 -0700 (PDT) MIME-Version: 1.0 References: <1566221225-5170-1-git-send-email-xuwei5@hisilicon.com> In-Reply-To: From: Linus Walleij Date: Tue, 20 Aug 2019 09:12:04 +0200 Message-ID: Subject: Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion To: Andy Shevchenko , Thierry Reding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_001221_368793_AB33406A X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Salil Mehta , jinying@hisilicon.com, Tangkunshan , "Liguozhu \(Kenneth\)" , John Garry , "Rafael J. Wysocki" , Linux Kernel Mailing List , Wei Xu , Linuxarm , "open list:GPIO SUBSYSTEM" , Shameerali Kolothum Thodi , huangdaode , Jonathan Cameron , Shiju Jose , Mika Westerberg , Zhangyi ac , linux-arm Mailing List , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko wrote: > The proper fix is to revert the culprit since we call > acpi_gpiochip_request_interrupts() for all controllers. > Linus, please re-do the approach with IRQ handling, Exactly what do you refer to when you want me to "re-do the approach for IRQ handling"? Do you mean this driver or are you referring to: commit e0d89728981393b7d694bd3419b7794b9882c92d Author: Thierry Reding Date: Tue Nov 7 19:15:54 2017 +0100 gpio: Implement tighter IRQ chip integration Currently GPIO drivers are required to add the GPIO chip and its corresponding IRQ chip separately, which can result in a lot of boilerplate. Use the newly introduced struct gpio_irq_chip, embedded in struct gpio_chip, that drivers can fill in if they want the GPIO core to automatically register the IRQ chip associated with a GPIO chip. Signed-off-by: Thierry Reding Acked-by: Grygorii Strashko Signed-off-by: Linus Walleij The new API introduced by this patch is what I am trying to switch everything over to, because the forked paths inside of gpiolib is causing me a maintenance headache and also increasing the footprint of the library. > it seems broadly > regress with ACPI enabled platforms. It only becomes a problem if the platform uses ACPI right? But it's a problem if I can't really tell if a driver is using ACPI or not, there is no sign in the pl061 driver that it would be used on ACPI systems until now, so how do I design for it? The problem comes from the problem/mess I am trying to clean up in the first place. So if the new way of registering GPIO irqchips is not working for ACPI, then we have to fix that instead of reverting all attempts to use the new API IMO. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel